Review main Merged

92058[TASK] Add workspace selector to module menu

Oli Bartsch CR +2 V +2 Expert +1507 −700 updated 02/12/26, 12:34

Commit message

This moves the workspace switcher from the topbar
to the sidebar. The workspace switcher is now
a prominent sidebar component and by displaying
the full name of the current active workspace
together with a dedicated color indication,
the overal usability for editors, working with
workspaces, is improved.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Andreas Nedbal +1
    • Benjamin Kott +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Andreas Nedbal +1
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 2

Files 37

Show 17 more files

Review log 6092

Show 4267 earlier messages
  1. Oli Bartsch uploaded patch set 1 12/09/25, 11:52

  2. Oli Bartsch uploaded patch set 2 12/09/25, 11:59

  3. core-ci voted on patch set 1 V -1 12/09/25, 12:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91881

  4. core-ci voted on patch set 2 V -1 12/09/25, 12:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91882

  5. Oli Bartsch uploaded patch set 3 V -1 12/09/25, 12:32

  6. core-ci voted on patch set 3 V +1 12/09/25, 12:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91885

  7. Oli Bartsch updated the commit message in patch set 4 V +1 12/09/25, 13:36

  8. core-ci voted on patch set 4 V +1 12/09/25, 13:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91891

  9. Oli Bartsch uploaded patch set 5 V +1 12/09/25, 17:15

  10. core-ci voted on patch set 5 V +1 12/09/25, 17:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91920

  11. Soren Malling voted on patch set 5 V +1 12/10/25, 15:17

  12. Benni Mack commented on patch set 5 12/10/25, 17:34

    ModuleMenu.fluid.html:6

    this is a concrete dependency from EXT:workspaces into EXT:backend, so we need to adjust this.

    ModuleMenu.fluid.html:9

    I assume we could do this in the event listener by adding the inline language labels directly? Other option: Hand in the labels in the custom element.
  13. Benjamin Kott commented on patch set 5 12/11/25, 08:33

    sys_workspace.php:50

    not having the field added will brick the backend completely, sice it has way more impact than before we now need to use the install tool to fix it.
  14. Benjamin Kott commented on patch set 5 12/11/25, 08:36

    workspace-selector-element.ts:272

    it uses the wrong icon
  15. Benjamin Kott commented on patch set 5 12/11/25, 08:37

    patch is breaking the collapsed view, as the scollable area is not accounted anymore
  16. Benjamin Kott commented on patch set 5 12/11/25, 08:39

    ModuleMenu.fluid.html:6

    the workspace selector is not part of the module menu, it sits in the same spot but it´s not the same.
  17. Benjamin Kott commented on patch set 5 12/11/25, 08:45

    workspace-selector-element.ts:114

    hard assignments of --typo3 properties, these need to be set on root and assigned from the outside.
  18. Soren Malling commented on patch set 5 V 0 12/11/25, 09:24

    Long workspace name is not readable
  19. Benjamin Kott updated the commit message in patch set 6 V +1 12/11/25, 10:28

  20. core-ci voted on patch set 6 V +1 12/11/25, 10:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92057

  21. Oli Bartsch uploaded patch set 7 V +1 12/16/25, 10:01

  22. Oli Bartsch uploaded patch set 8 12/16/25, 10:02

  23. Oli Bartsch commented on patch set 8 12/16/25, 10:13

    workspace-selector-element.ts:114 Reply

    Done

    workspace-selector-element.ts:272 Reply

    Done

    ModuleMenu.fluid.html:6 Reply

    Done

    ModuleMenu.fluid.html:9 Reply

    Done

    sys_workspace.php:50 Reply

    Done
  24. core-ci voted on patch set 7 V +1 12/16/25, 10:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92281

  25. core-ci voted on patch set 8 V -1 12/16/25, 10:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92282

  26. Benjamin Kott uploaded patch set 9 V -1 12/16/25, 10:41

  27. core-ci voted on patch set 9 V -1 12/16/25, 10:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92287

  28. Benjamin Kott uploaded patch set 10 V -1 12/16/25, 11:40

  29. core-ci voted on patch set 10 V -1 12/16/25, 11:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92292

  30. Benjamin Kott rebased onto patch set 11 V -1 12/16/25, 13:16

  31. Benjamin Kott rebased onto patch set 12 12/16/25, 13:21

  32. core-ci voted on patch set 11 V -1 12/16/25, 13:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92296

  33. core-ci voted on patch set 12 V -1 12/16/25, 13:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92299

  34. Benjamin Kott commented on patch set 12 12/16/25, 13:56

    - endpoints should always deliver valid workspace items including description and color - we need events to refresh the workspace selector (gloal refresh / workspace changed) - workspace selector should only get the current selected workspace - workspace selector needs to be able to refresh it´s data
  35. Benjamin Kott commented on patch set 12 12/16/25, 13:58

    Reply

    - question, what happens when an active workspace is removed
  36. Benjamin Kott commented on patch set 12 12/16/25, 14:01

    Reply

    - we need to be able to access the selected workspace information through the backend, for example to color (note something in the header)
  37. Oli Bartsch uploaded patch set 13 V -1 01/28/26, 12:10

  38. core-ci voted on patch set 13 V +1 01/28/26, 12:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94499

  39. Oli Bartsch uploaded patch set 14 V +1 01/28/26, 16:26

  40. core-ci voted on patch set 14 V +1 01/28/26, 16:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94517

  41. Oli Bartsch uploaded patch set 15 V +1 01/29/26, 11:55

  42. core-ci voted on patch set 15 V +1 01/29/26, 12:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94566

  43. Benjamin Franzke uploaded patch set 16 V +1 01/29/26, 12:28

  44. core-ci voted on patch set 16 V +1 01/29/26, 12:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94568

  45. Benjamin Franzke commented on patch set 16 01/29/26, 13:21

    WorkspaceService.php:97

    We should avoid catching `DBALException`s here, an error is an error. I understand that this has been done to be graceful regarding the additional for the color column, but we can do better based on `SchemaInformation` (will propose a solution)
  46. Benjamin Franzke uploaded patch set 17 V +1 01/29/26, 13:45

  47. core-ci voted on patch set 17 V -1 01/29/26, 13:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94577

  48. Benjamin Franzke uploaded patch set 18 V -1 01/29/26, 14:07

  49. core-ci voted on patch set 18 V +1 01/29/26, 14:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94583

  50. Oli Bartsch uploaded patch set 19 V +1 01/29/26, 21:08

  51. core-ci voted on patch set 19 V +1 01/29/26, 21:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94604

  52. Benjamin Franzke uploaded patch set 20 V +1 01/30/26, 10:15

  53. Benjamin Franzke commented on patch set 20 01/30/26, 10:15

    WorkspaceService.php:97 Reply

    Done
  54. Benjamin Franzke rebased onto patch set 21 01/30/26, 10:17

  55. core-ci voted on patch set 21 V +1 01/30/26, 11:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94639

  56. core-ci voted on patch set 20 V -1 01/30/26, 11:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94637

  57. Benjamin Kott commented on patch set 21 CR -1 02/03/26, 08:03

    - on it
  58. Benjamin Kott uploaded patch set 22 CR -1 V +1 02/03/26, 20:05

  59. Benjamin Kott commented on patch set 22 CR -2 02/03/26, 20:05

    on it
  60. core-ci voted on patch set 22 V -1 02/03/26, 20:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94940

  61. Benjamin Kott uploaded patch set 23 V -1 02/04/26, 11:51

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  62. core-ci voted on patch set 23 V -1 02/04/26, 12:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95014

  63. Benjamin Kott uploaded patch set 24 V -1 02/04/26, 15:01

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  64. Benjamin Kott uploaded patch set 25 02/04/26, 15:08

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  65. core-ci voted on patch set 24 V -1 02/04/26, 15:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95046

  66. core-ci voted on patch set 25 V +1 02/04/26, 15:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95049

  67. Benjamin Kott uploaded patch set 26 V +1 02/04/26, 16:15

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  1. Benjamin Kott voted on patch set 26 CR 0 02/04/26, 16:15

  2. Benjamin Kott commented on patch set 26 02/04/26, 16:16

    ModuleMenu.fluid.html:6 Reply

    Done
  3. core-ci voted on patch set 26 V +1 02/04/26, 16:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95066

  4. Benjamin Kott rebased onto patch set 27 V +1 02/05/26, 15:28

  5. core-ci voted on patch set 27 V +1 02/05/26, 15:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95173

  6. Oli Bartsch uploaded patch set 28 V +1 02/10/26, 12:02

  7. Oli Bartsch uploaded patch set 29 02/10/26, 12:26

  8. core-ci voted on patch set 29 V +1 02/10/26, 12:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95541

  9. core-ci voted on patch set 28 V -1 02/10/26, 12:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95539

  10. Benjamin Kott uploaded patch set 30 V +1 02/10/26, 13:53

  11. core-ci voted on patch set 30 V -1 02/10/26, 14:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95550

  12. Benjamin Kott uploaded patch set 31 V -1 02/10/26, 14:17

  13. Benjamin Kott voted on patch set 31 CR +1 V +1 02/10/26, 14:17

  14. core-ci voted on patch set 31 V +1 02/10/26, 14:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95553

  15. Riccardo De Contardi commented on patch set 31 02/10/26, 14:34

    Not entirely sure of the choice of red as the color for LIVE workspace (that's the color of danger); also not entirely sure of the bar with the workspace name at the very top of the page, but I'm worried just for the LIVE version. That's nice for workspaces, though. Wild suggestion: what about making it temporary? So it disappears after some time and just a 2px height line survives?
  16. Benjamin Kott uploaded patch set 32 CR +1 V +1 02/10/26, 14:42

  17. Benjamin Kott commented on patch set 32 02/10/26, 14:44

    Reply

    We have discussed this, and we will prefix the indicator in the top. As soon as you work with workspaces you need to be aware in what context you are working in. Especially live, we will now announce the workspaces always for instances that are using workspaces - other instances will not see the indicator at all.
  18. Benjamin Kott voted on patch set 32 CR +1 V +1 02/10/26, 14:49

  19. core-ci voted on patch set 32 V +1 02/10/26, 14:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95556

  20. Andreas Nedbal voted on patch set 32 CR +1 V +1 02/10/26, 16:51

  21. Oli Bartsch voted on patch set 32 CR +2 V +2 02/10/26, 17:23

  22. Oli Bartsch merged patch set 33 02/10/26, 17:23

  23. Simon Schaufelberger commented on patch set 33 02/10/26, 20:45

    When I uninstall the workspace extension, I expect that the topbar is removed but it is still there. The url is also changed to typo3/module/extensions/List/index?refreshModuleMenu=1&refreshTopbar=1 but does not nothing
  24. Josef Glatz commented on patch set 33 02/11/26, 12:01

    Reply

    I can reproduce. Also the workspace selector in the module-menu (above the module-menu) isn't updated. The scenario exists also in the other way when you activate the workspaces extension in classic mode. _however a hard reload of the backend tab fixes it._ followup: https://review.typo3.org/c/Packages/TYPO3.CMS/+/92793
  25. Oli Bartsch commented on patch set 33 02/12/26, 12:34

    Reply

    Done