92063[TASK] Make properties in final classes private in core tests
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oliver Klee +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- core-ci +1 CI
Issues 1
Files 71
- Build/phpstan/phpstan-baseline.neon+0 −24
- typo3/sysext/core/Tests/Acceptance/Application/Scheduler/TaskGroupsCest.php+1 −1
- typo3/sysext/core/Tests/Functional/Authentication/Mfa/MfaProviderPropertyManagerTest.php+1 −1
- typo3/sysext/core/Tests/Functional/Authentication/Mfa/MfaProviderRegistryTest.php+2 −2
- typo3/sysext/core/Tests/Functional/Authentication/AuthenticationServiceTest.php+1 −4
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/CheckboxValidationTest.php+1 −1
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/SelectCheckBoxTest.php+2 −4
- typo3/sysext/core/Tests/Functional/Domain/Access/RecordAccessVoterTest.php+1 −1
- typo3/sysext/core/Tests/Functional/Html/EventListener/RteHtmlParserTest.php+1 −1
- typo3/sysext/core/Tests/Functional/Imaging/IconProvider/BitmapIconProviderTest.php+2 −5
- typo3/sysext/core/Tests/Functional/Imaging/IconProvider/SvgIconProviderTest.php+2 −2
- typo3/sysext/core/Tests/Functional/Imaging/IconProvider/SvgSpriteIconProviderTest.php+2 −5
- typo3/sysext/core/Tests/Functional/Resource/ResourceFactoryTest.php+4 −8
- typo3/sysext/core/Tests/Functional/Resource/SynchronizeFolderRelationsTest.php+1 −1
- typo3/sysext/core/Tests/Functional/Service/SilentConfigurationUpgradeServiceTest.php+1 −1
- typo3/sysext/core/Tests/Functional/Session/Backend/DatabaseSessionBackendTest.php+2 −8
- typo3/sysext/core/Tests/Functional/Session/Backend/RedisSessionBackendTest.php+1 −1
- typo3/sysext/core/Tests/Functional/Session/SessionManagerTest.php+2 −8
- typo3/sysext/core/Tests/Functional/Upgrades/CustomCTypeMigrationTest.php+5 −5
- typo3/sysext/core/Tests/Functional/Upgrades/MigrateExtensionDataImportRegistryKeysUpdateTest.php+2 −2
Show 51 more files
- typo3/sysext/core/Tests/Functional/Upgrades/NullToDefaultUpdateWizardTest.php+2 −2
- typo3/sysext/core/Tests/Functional/Upgrades/PagesRecyclerDoktypeMigrationTest.php+2 −2
- typo3/sysext/core/Tests/Functional/Upgrades/UserPermissionsForRenamedModulesMigrationTest.php+2 −2
- typo3/sysext/core/Tests/Functional/Utility/PathUtilityPublicPathsTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Authentication/Mfa/Provider/RecoveryCodesTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Authentication/Mfa/Provider/TotpTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Compatibility/PublicPropertyDeprecationTraitTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Configuration/ConfigurationManagerTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Configuration/SiteConfigurationTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Core/SystemEnvironmentBuilderTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Crypto/HashServiceTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Database/Query/BulkInsertTest.php+2 −4
- typo3/sysext/core/Tests/Unit/Database/Schema/ConnectionMigratorTest.php+4 −6
- typo3/sysext/core/Tests/Unit/Database/Schema/DefaultTcaSchemaTest.php+1 −2
- typo3/sysext/core/Tests/Unit/DataHandling/Localization/StateTest.php+1 −1
- typo3/sysext/core/Tests/Unit/DataHandling/DataHandlerTest.php+3 −5
- typo3/sysext/core/Tests/Unit/DependencyInjection/ServiceProviderRegistryTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Error/DebugExceptionHandlerTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Error/ErrorHandlerTest.php+1 −3
- typo3/sysext/core/Tests/Unit/EventDispatcher/ListenerProviderTest.php+2 −9
- typo3/sysext/core/Tests/Unit/FormProtection/BackendFormProtectionTest.php+3 −3
- typo3/sysext/core/Tests/Unit/FormProtection/FormProtectionFactoryTest.php+2 −2
- typo3/sysext/core/Tests/Unit/FormProtection/InstallToolFormProtectionTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Html/Event/AfterTransformTextForPersistenceEventTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Html/Event/AfterTransformTextForRichTextEditorEventTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Html/Event/BeforeTransformTextForPersistenceEventTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Html/Event/BeforeTransformTextForRichTextEditorEventTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Html/HtmlParserTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Html/RteHtmlParserTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Http/MessageTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Http/ResponseTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Http/ServerRequestTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Http/UploadedFileTest.php+1 −1
- typo3/sysext/core/Tests/Unit/LinkHandling/TypoLinkCodecServiceTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Localization/LocalesTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Locking/LockFactoryTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Log/Processor/IntrospectionProcessorTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Log/Writer/FileWriterTest.php+3 −3
- typo3/sysext/core/Tests/Unit/Log/Writer/RotatingFileWriterTest.php+3 −3
- typo3/sysext/core/Tests/Unit/Mail/FileSpoolTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Messaging/FlashMessageServiceTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Package/PackageManagerTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Package/PackageTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Pagination/ArrayPaginatorTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Pagination/SimplePaginationTest.php+1 −5
- typo3/sysext/core/Tests/Unit/Pagination/SlidingWindowPaginationTest.php+8 −8
- typo3/sysext/core/Tests/Unit/Resource/Rendering/VimeoRendererTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Resource/Rendering/YouTubeRendererTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Resource/ProcessedFileTest.php+3 −3
- typo3/sysext/core/Tests/Unit/Service/MarkerBasedTemplateServiceTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.php+2 −4
Review log 69
-
Simon Schaufelberger uploaded patch set 1 12/09/25, 13:31
-
core-ci voted on patch set 1 V -1 12/09/25, 13:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91890
-
Simon Schaufelberger uploaded patch set 2
V -112/09/25, 13:47 -
core-ci voted on patch set 2 V -1 12/09/25, 13:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91892
-
Simon Schaufelberger uploaded patch set 3
V -112/09/25, 14:17 -
core-ci voted on patch set 3 V +1 12/09/25, 14:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91895
-
Oliver Klee voted on patch set 3 CR +1 V +1 12/09/25, 15:05
-
Christian Kuhn voted on patch set 3 CR +2 V +2 12/09/25, 15:21
-
Christian Kuhn merged patch set 4 12/09/25, 15:21