Review main Abandoned

92067[WIP][BUGFIX] Allow saving versioned records for ignoreWebMountRestriction=true

Andreas Wolf CR 0 V -1 Easy +8 −1 updated 09/02/26, 16:54

Commit message

Saving a record on page ID 0 in a workspace, e.g. file metadata, was broken
because the check incorrectly assumed that the user does not have any
permission to change the record. This assumption was incorrect because
ignoreWebMountRestriction was not respected.

Review

  • Code review CR 0
  • Verified V -1
    • core-ci -1 CI

Issues 1

Files 1

Review log 1016

  1. Andreas Wolf uploaded patch set 1 12/09/25, 15:03

  2. Andreas Wolf uploaded patch set 2 12/09/25, 15:05

  3. core-ci voted on patch set 1 V -1 12/09/25, 15:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91902

  4. Stefan Bürk updated the commit message in patch set 3 12/09/25, 15:14

  5. core-ci voted on patch set 2 V -1 12/09/25, 15:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91904

  6. core-ci voted on patch set 3 V -1 12/09/25, 15:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91906

  7. Andreas Wolf uploaded patch set 4 V -1 12/09/25, 15:26

  8. Christian Kuhn updated the commit message in patch set 5 12/09/25, 15:28

  9. core-ci voted on patch set 4 V -1 12/09/25, 15:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91910

  10. core-ci voted on patch set 5 V -1 12/09/25, 15:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91911

  11. Stefan Bürk commented on patch set 5 12/09/25, 16:50

    I guess not that simple, see related: 91338: [WIP][BUGFIX] Allow versioned `PID=0` records with ignoreRootLevelRestriction | https://review.typo3.org/c/Packages/TYPO3.CMS/+/91338 needs really deep look into it.
  12. Andreas Wolf uploaded patch set 6 V -1 12/11/25, 08:25

  13. core-ci voted on patch set 6 V -1 12/11/25, 08:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92053

  14. Benni Mack marked it work in progress 04/21/26, 15:16

  15. Sebastian Michaelsen commented on patch set 6 06/10/26, 10:40

    I used this WIP to patch our project and functionally it is fine. I just want to point out that DataHandler does the same kind of check multiple times already (search "shallIgnoreRootLevelRestriction"). Maybe it would be worth it to extract something to a central place. Alternatively at least take inspiration from there, I think the `$this->BE_USER->isAdmin() ||` is still needed.
  16. Benni Mack abandoned the change 09/02/26, 16:54

    will abandon this now - fixed via 8f04953cb71 and ee251c96d55