92069[TASK] Make properties in final classes private in extbase tests
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oliver Klee +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- core-ci +1 CI
Issues 1
Files 21
- Build/phpstan/phpstan-baseline.neon+0 −18
- typo3/sysext/extbase/Tests/Functional/Persistence/AddTest.php+2 −2
- typo3/sysext/extbase/Tests/Functional/Persistence/CountTest.php+2 −2
- typo3/sysext/extbase/Tests/Functional/Persistence/InTest.php+2 −2
- typo3/sysext/extbase/Tests/Functional/Persistence/UpdateTest.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Persistence/WorkspaceTest.php+2 −2
- typo3/sysext/extbase/Tests/Functional/Service/FileHandlingServiceTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Error/ResultTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Mvc/Controller/ArgumentTest.php+1 −3
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/QueryResultTest.php+7 −20
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/QueryTest.php+7 −9
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Typo3QuerySettingsTest.php+1 −4
- typo3/sysext/extbase/Tests/Unit/Property/TypeConverter/BooleanConverterTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Property/TypeConverter/CountryConverterTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Property/TypeConverter/DateTimeConverterTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Property/TypeConverter/IntegerConverterTest.php+1 −5
- typo3/sysext/extbase/Tests/Unit/Property/TypeConverter/StringConverterTest.php+1 −5
- typo3/sysext/extbase/Tests/Unit/Property/PropertyMappingConfigurationBuilderTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Reflection/ObjectAccessTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Service/ExtensionServiceTest.php+2 −2
Review log 68
-
Simon Schaufelberger uploaded patch set 1 12/09/25, 16:40
-
core-ci voted on patch set 1 V -1 12/09/25, 16:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91915
-
Simon Schaufelberger uploaded patch set 2
V -112/09/25, 16:52 -
core-ci voted on patch set 2 V +1 12/09/25, 16:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91916
-
Christian Kuhn voted on patch set 2 CR +1 V +1 12/09/25, 17:02
-
Oliver Klee voted on patch set 2 CR +1 V +1 12/09/25, 17:04
-
Christian Kuhn voted on patch set 2 CR +2 V +2 12/09/25, 17:04
-
Christian Kuhn merged patch set 3 12/09/25, 17:05