92072[BUGFIX] Add parent module access when migrating renamed modules
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Lina Wolf +1
-
Verified V +2 Done
- Benni Mack +2
- Lina Wolf +1
- core-ci +1 CI
Issues 2
Files 6
- typo3/sysext/core/Classes/Upgrades/UserPermissionsForRenamedModulesMigration.php+42 −4
- typo3/sysext/core/Tests/Functional/Upgrades/Fixtures/UserPermissionsForRenamedModulesAlreadyMigrated.csvnew+10 −0
- typo3/sysext/core/Tests/Functional/Upgrades/Fixtures/UserPermissionsForRenamedModulesAlreadyMigratedResult.csvnew+10 −0
- typo3/sysext/core/Tests/Functional/Upgrades/Fixtures/UserPermissionsForRenamedModulesBase.csv+9 −3
- typo3/sysext/core/Tests/Functional/Upgrades/Fixtures/UserPermissionsForRenamedModulesMigrated.csv+13 −7
- typo3/sysext/core/Tests/Functional/Upgrades/UserPermissionsForRenamedModulesMigrationTest.php+41 −0
Review log 1114
-
Oli Bartsch uploaded patch set 1 12/09/25, 17:44
-
core-ci voted on patch set 1 V +1 12/09/25, 17:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91922
-
Oli Bartsch rebased onto patch set 2
V +112/12/25, 07:21 -
core-ci voted on patch set 2 V +1 12/12/25, 07:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92111
-
Lina Wolf commented on patch set 2 12/17/25, 05:44
I tested this with a group that had group Mods `redirects,records` and link_management did not get added -
Oli Bartsch commented on patch set 2 12/17/25, 08:12
Reply
Yes, you would need `site_redirects`. `redirects` is already the new module name. -
Lina Wolf commented on patch set 2 12/17/25, 08:14
Reply
If you ran the migration wizard with 14.0 you now have only 'redirects' which is not visible because the parent is missing -
Oli Bartsch uploaded patch set 3
V +112/17/25, 08:59 -
Oli Bartsch commented on patch set 3 12/17/25, 09:00
Reply
While I think this is really an edge case, I have added corresponding functionality now. -
Lina Wolf commented on patch set 3 CR +1 V +1 12/17/25, 09:03
Tested with groups containing redirects or site_redirects, code and tests look good to me -
core-ci voted on patch set 3 V +1 12/17/25, 09:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92337
-
Benni Mack voted on patch set 3 CR +1 V +1 12/17/25, 22:56
-
Benni Mack voted on patch set 3 CR +2 V +2 12/17/25, 23:02
-
Benni Mack merged patch set 4 12/17/25, 23:02