Review main Merged

92072[BUGFIX] Add parent module access when migrating renamed modules

Oli Bartsch CR +2 V +2 Normal +125 −14 updated 12/17/25, 23:02

Commit message

When modules are renamed and moved to a new parent
in the hierarchy (e.g., site_redirects → redirects
under link_management), users need access to both
the renamed module and its parent to maintain
functionality.

The migration now automatically grants required
parent module permissions and also deduplicates
module lists and normalizes whitespace.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Lina Wolf +1
  • Verified V +2 Done
    • Benni Mack +2
    • Lina Wolf +1
    • core-ci +1 CI

Issues 2

Files 6

Review log 1114

  1. Oli Bartsch uploaded patch set 1 12/09/25, 17:44

  2. core-ci voted on patch set 1 V +1 12/09/25, 17:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91922

  3. Oli Bartsch rebased onto patch set 2 V +1 12/12/25, 07:21

  4. core-ci voted on patch set 2 V +1 12/12/25, 07:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92111

  5. Lina Wolf commented on patch set 2 12/17/25, 05:44

    I tested this with a group that had group Mods `redirects,records` and link_management did not get added
  6. Oli Bartsch commented on patch set 2 12/17/25, 08:12

    Reply

    Yes, you would need `site_redirects`. `redirects` is already the new module name.
  7. Lina Wolf commented on patch set 2 12/17/25, 08:14

    Reply

    If you ran the migration wizard with 14.0 you now have only 'redirects' which is not visible because the parent is missing
  8. Oli Bartsch uploaded patch set 3 V +1 12/17/25, 08:59

  9. Oli Bartsch commented on patch set 3 12/17/25, 09:00

    Reply

    While I think this is really an edge case, I have added corresponding functionality now.
  10. Lina Wolf commented on patch set 3 CR +1 V +1 12/17/25, 09:03

    Tested with groups containing redirects or site_redirects, code and tests look good to me
  11. core-ci voted on patch set 3 V +1 12/17/25, 09:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92337

  12. Benni Mack voted on patch set 3 CR +1 V +1 12/17/25, 22:56

  13. Benni Mack voted on patch set 3 CR +2 V +2 12/17/25, 23:02

  14. Benni Mack merged patch set 4 12/17/25, 23:02