Review main Merged

92077[BUGFIX] Use configured backendLogo from EXT:backend

Niels Langlotz CR +2 V +2 Easy +1 −1 updated 12/10/25, 10:34

Commit message

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Josef Glatz +1
    • Christian Kuhn +1
    • Helmut Hummel +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Josef Glatz +1
    • Christian Kuhn +1
    • Helmut Hummel +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1215

  1. Niels Langlotz uploaded patch set 1 12/09/25, 23:24

  2. Niels Langlotz uploaded patch set 2 12/09/25, 23:31

  3. core-ci voted on patch set 1 V +1 12/09/25, 23:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91937

  4. Niels Langlotz voted on patch set 2 CR +1 12/09/25, 23:32

  5. Christian Kuhn rebased onto patch set 3 CR +1 12/09/25, 23:38

  6. core-ci voted on patch set 2 V +1 12/09/25, 23:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91938

  7. Christian Kuhn commented on patch set 3 CR +1 V +1 12/09/25, 23:38

    thanks. good catch!
  8. core-ci voted on patch set 3 V +1 12/09/25, 23:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91939

  9. Simon Schaufelberger voted on patch set 3 CR +1 V +1 12/10/25, 01:17

  10. Josef Glatz commented on patch set 3 V -1 12/10/25, 05:09

    testing this with a simple `fileadmin/svgwithlink.svg` results in an exception > `You are not allowed to access that file: "svgwithlink.svg" | TYPO3\CMS\Core\Resource\Exception\InsufficientFileAccessPermissionsException thrown in file /var/www/html/typo3/sysext/core/Classes/Resource/ResourceStorage.php in line 852. Requested URL: https://t3coredev-14-php8-5.ddev.site/typo3/` I personally would never store such file in fileadmin or any other file storage – but the description of EXT:backend suggests: - `fileadmin/images/login-logo.png` - or `EXT:my_theme/Resources/Public/Images/login-logo.png` - or `//domain.tld/login-logo.png` Is this issue another valid forge issue?
  11. Helmut Hummel commented on patch set 3 CR +1 V +1 12/10/25, 08:59

    Reply

    @typo3@josefglatz.at The error you are seeing is not for backendLogo but for loginLogo, right? Then this is unrelated to this issue here and rather an issue related to this one: https://forge.typo3.org/issues/105699 I agree, that this is worth a fix, but not within this one here
  12. Benni Mack commented on patch set 3 CR +1 V +1 12/10/25, 10:04

    Thanks, Niels!
  13. Josef Glatz commented on patch set 3 CR +1 V +1 12/10/25, 10:25

    Reply

    ACK. Sorry for the noise!
  14. Benni Mack voted on patch set 3 CR +2 V +2 12/10/25, 10:34

  15. Benni Mack merged patch set 4 12/10/25, 10:34