Review main Merged

92078[BUGFIX] Re-enable EM unresolvedDependencies modal view

Josef Glatz CR +2 V +2 Easy +23 −2 updated 12/10/25, 15:32

Commit message

This patch adopts the template to reference the specific fluid partial
since fluid files changed suffix from ".html" to ".fluid.html". Trying
to install an TYPO3 extension from TER with unresolved dependencies
shows the modal again.

A search within TYPO3 core showed no other partials that are called
using an explicit file extension. Pattern used:

partial="[^"]+\.(html|json|xml|txt)"

Review

  • Code review CR +2 Done
    • Simon Praetorius +2
    • Georg Ringer +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Simon Praetorius +2
    • Georg Ringer +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1824

  1. Josef Glatz uploaded patch set 1 12/10/25, 05:43

  2. Josef Glatz commented on patch set 1 12/10/25, 05:44

    This change is ready for review.
  3. Josef Glatz commented on patch set 1 12/10/25, 05:48

    1) info for review: I've tried using https://github.com/typo3/typo3/blob/1f83c2dff301376e1b74d94569f47b3306d85e64/typo3/sysext/extensionmanager/Resources/Private/Partials/List/UnresolvedDependencies.fluid.json first, but that was failing and used fluid.html directly. Please review also if this is the real correct way to fix this. 2) Side note: beside the partial file format: I'm not sure if there are connections between the disabled continue anyway button in the modal to this issue.
  4. Josef Glatz updated the commit message in patch set 2 12/10/25, 05:50

  5. Josef Glatz updated the commit message in patch set 3 12/10/25, 05:50

  6. core-ci voted on patch set 1 V +1 12/10/25, 05:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91958

  7. core-ci voted on patch set 2 V +1 12/10/25, 05:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91959

  8. core-ci voted on patch set 3 V +1 12/10/25, 05:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91960

  9. Josef Glatz commented on patch set 3 12/10/25, 06:02

    InstallFromTer.fluid.json:7

    is it somehow a fluid bug that we must specifically add a suffix @simon@praetorius.me? I'm actually not sure if "fluid.html" or "fluid.json" needs to be used here.
  10. Stefan Bürk commented on patch set 3 12/10/25, 06:19

    See https://forge.typo3.org/issues/108455#note-3 Can you please add/share a extension key from TER leading to this issue ?
  11. Josef Glatz commented on patch set 3 12/10/25, 08:12

    Reply

    ext:crowdin
  12. Simon Praetorius uploaded patch set 4 V +1 12/10/25, 09:13

  13. Simon Praetorius commented on patch set 4 12/10/25, 09:18

    The problem was actually located one file deeper. Background: Fluid 5 adds a fallback chain for file names that don't already contain a file extension: File extensions are only added to the specified file name, but not removed/altered. This means that when a specific file with its extension is referenced, the full file extension (with .fluid part) needs to be specified. We could try to resolve this on the Fluid side, but from my point of view it's might not be worth the hassle since this is only really relevant when the format changes within a template (.json template calls .html partial, like in this example).
  14. Simon Praetorius updated the commit message in patch set 5 12/10/25, 09:19

  15. Simon Praetorius commented on patch set 5 12/10/25, 09:20

    InstallFromTer.fluid.json:7 Reply

    Done
  16. core-ci voted on patch set 4 V +1 12/10/25, 09:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91968

  17. core-ci voted on patch set 5 V +1 12/10/25, 09:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91970

  18. Simon Praetorius uploaded patch set 6 V +1 12/10/25, 09:35

  19. core-ci voted on patch set 6 V +1 12/10/25, 09:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91972

  20. Simon Praetorius voted on patch set 6 CR +1 V +1 12/10/25, 12:29

  21. Georg Ringer voted on patch set 6 CR +1 V +1 12/10/25, 12:45

  22. Garvin Hicking voted on patch set 6 CR +1 V +1 12/10/25, 14:17

  23. Simon Praetorius voted on patch set 6 CR +2 V +2 12/10/25, 15:32

  24. Simon Praetorius merged patch set 7 12/10/25, 15:32