Review main Merged

92079[BUGFIX] Ensure autoload of moved interfaces in classic mode

Stefan Bürk CR +2 V +2 Easy +4 −4 updated 01/12/26, 09:39

Commit message

Trying to install an extension providing custom
upgrade wizards using the deprecated interfaces
from `EXT:install` namespace fails hard with the
following exception:

  Class
    "TYPO3\CMS\Install\Updates\UpgradeWizardInterface"
  not found while loading
    "GeorgRinger\News\Updates\NewsSlugUpdater"

The interfaces have been moved from `EXT:install` to
`EXT:core/DeprecatedClasses/` and composer classmap
autoload definition has been added to `EXT:core` as
`autoload-dev` classmap to the monorepository root
`composer.json`, which works good and intended for
composer mode and core development. [2]

Classic mode contains a vendor folder and generated
composer autoload information along with the mono
repository `composer.json` and `composer.lock` files.
Autoload information are generated based on non-dev
dependency composer install execution leading to
missing autoload information for the interfaces in
the `DeprecatedClasses` folder of `EXT:core`.

Extension autoloading is generated during the TYPO3
bootstrap based on `composer.json` information except
system extensions which explains why this kicked not in
as fallback.

This change moves the mono-repository classmap autoload
configuration from dev to non-dev which allows the release
procedure to include autoloading information for the
deprecated interfaces and classes.

Used command(s):

  cat <<< $(
    jq --tab 'del(."autoload-dev"."classmap")' composer.json | \
    jq --tab '."autoload"."classmap" = ["typo3/sysext/core/DeprecatedClasses/ext-install/"]'
  ) > composer.json \
  && Build/Scripts/runTests.sh -s composer -- dumpautoload

[1] https://github.com/georgringer/news/issues/2757
[2] https://review.typo3.org/c/Packages/TYPO3.CMS/+/89697

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Georg Ringer +1
    • Oliver Klee +1
    • Simon Praetorius +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Georg Ringer +1
    • Simon Praetorius +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 913

  1. Stefan Bürk uploaded patch set 1 12/10/25, 06:16

  2. core-ci voted on patch set 1 V +1 12/10/25, 06:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91961

  3. Simon Schaufelberger updated the commit message in patch set 2 V +1 12/10/25, 09:15

  4. core-ci voted on patch set 2 V +1 12/10/25, 09:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91969

  5. Stefan Bürk updated the commit message in patch set 3 V +1 12/10/25, 15:31

  6. core-ci voted on patch set 3 V +1 12/10/25, 15:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92000

  7. Stefan Bürk uploaded patch set 4 V +1 01/12/26, 00:51

  8. core-ci voted on patch set 4 V +1 01/12/26, 01:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93244

  9. Georg Ringer voted on patch set 4 CR +1 V +1 01/12/26, 05:48

  10. Oliver Klee voted on patch set 4 CR +1 01/12/26, 08:29

  11. Simon Praetorius voted on patch set 4 CR +1 V +1 01/12/26, 09:23

  12. Stefan Bürk voted on patch set 4 CR +2 V +2 01/12/26, 09:39

  13. Stefan Bürk merged patch set 5 01/12/26, 09:39