92080[TASK] Adjust and relocate runTests watchRst templates
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Markus Klein +1
- Christian Kuhn +1
-
Verified V +2 Done
- Garvin Hicking +2
- Markus Klein +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 3
Files 5
Review log 1518
-
Garvin Hicking uploaded patch set 1 12/10/25, 07:55
-
core-ci voted on patch set 1 V +1 12/10/25, 08:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91964
-
Garvin Hicking commented on patch set 1 CR -1 12/10/25, 17:28
Hang on, will try to also address 91773: [TASK] Enhance CLI docs for runTests.sh -s watchRst | https://review.typo3.org/c/Packages/TYPO3.CMS/+/91773 -
Garvin Hicking uploaded patch set 2
CR -1V +112/10/25, 18:22 -
core-ci voted on patch set 2 V +1 12/10/25, 18:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92011
-
Markus Klein commented on patch set 2 12/11/25, 08:50
runTests.sh:688This still does not explain which parameters are required, and what there options and meanings are. -
Garvin Hicking commented on patch set 2 12/11/25, 11:33
runTests.sh:688ReplyI think that's the task of the documentation for contribution guide and it follows the "documentation" of the other commands. I'd love to make at least some iterative progress here. I think in the long run the commands might need refactoring. Until then I don't want to try to explain the workarounds and focus on the variations that it can be used for and which seems plausible when written like that...? -
Markus Klein commented on patch set 2 12/11/25, 12:28
runTests.sh:688Reply> I think that's the task of the documentation for contribution guide No it's not, in my opinion: It's a matter of "<command> -h" (or similar) to get proper information on how to use a CLI tool. No external source should be necessary to see all possible options. Maybe we have to make the "interactive" special "file" an option, this would take away some magic already. -
Garvin Hicking commented on patch set 2 12/11/25, 13:36
runTests.sh:688ReplyI do not think we'll get documentation sorted out beyond the proposal I've done here as you can see in the patch of yours. You could try to iterate on this in your patch then and use this patch here as an iterative enhancement of the current status quo. It would help me to make things move forward. Otherwise I would need to remove the helpful example section again, if you're blocking the patch because of this here? -
Markus Klein commented on patch set 2 12/11/25, 13:46
runTests.sh:688ReplyI'm not blocking anything! This is just my opinion on that matter and I'm fine with any other opinion. We can of course still use my other change to iterate on this. -
Markus Klein updated the commit message in patch set 3
V +112/11/25, 13:48 -
Markus Klein voted on patch set 3 CR +1 V +1 12/11/25, 13:48
-
core-ci voted on patch set 3 V +1 12/11/25, 13:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92071
-
Garvin Hicking commented on patch set 3 12/11/25, 13:59
runTests.sh:688ReplySorry, I used bad wording. I just want to satisfy everyone involved and I'm a bit frustrated. Didn't want to lash out, I do appreciate your vote and help/feedback! -
Christian Kuhn commented on patch set 3 CR +1 V +1 12/11/25, 15:43
we need to talk about the example list. i hate it ;) -
Markus Klein commented on patch set 3 12/11/25, 15:56
Reply
😄runTests.sh:688ReplyFull understanding and no worries. No offense taken. 👍 -
Garvin Hicking commented on patch set 3 CR +2 V +2 12/11/25, 17:11
Thanks. I'm aware we need to rework both the help system as well as think about better argument handling. I'm not looking forward to that 🤣 -
Garvin Hicking merged patch set 4 12/11/25, 18:24