92083[FEATURE] Allow to configure "first day of week" datepicker setting
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Georg Ringer +1
- Guido Schmechel +1
-
Verified V +2 Done
- Garvin Hicking +2
- Josef Glatz +1
- Georg Ringer +1
- Guido Schmechel +1
- core-ci +1 CI
Issues 1
Files 9
- Build/Sources/TypeScript/backend/date-time-picker.ts+15 −0
- Build/Sources/TypeScript/backend/user-settings-manager.ts+22 −1
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+7 −0
- typo3/sysext/backend/Resources/Public/JavaScript/date-time-picker.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/user-settings-manager.js+1 −1
- typo3/sysext/core/Documentation/Changelog/14.1/Feature-108463-User-specificconfigurationofdate-timepickerstartofweek.rst4new+37 −0
- typo3/sysext/setup/Classes/Controller/SetupModuleController.php9+38 −2
- typo3/sysext/setup/Resources/Private/Language/locallang.xlf5+6 −0
- typo3/sysext/setup/ext_tables.php2+8 −1
Review log 3747
Show 1522 earlier messages
-
Garvin Hicking uploaded patch set 1 12/10/25, 13:42
-
Garvin Hicking updated the commit message in patch set 2 12/10/25, 13:43
-
Garvin Hicking uploaded patch set 3 12/10/25, 13:45
-
core-ci voted on patch set 1 V -1 12/10/25, 13:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91983
-
core-ci voted on patch set 2 V -1 12/10/25, 13:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91984
-
core-ci voted on patch set 3 V -1 12/10/25, 13:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91985
-
Garvin Hicking uploaded patch set 4
V -112/10/25, 14:02 -
core-ci voted on patch set 4 V +1 12/10/25, 14:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91987
-
Simon Schaufelberger commented on patch set 4 12/11/25, 13:46
Typo? Son algorith?SetupModuleController.php:757Can we use the new domain based language key here?SetupModuleController.php:767Only selected is enough without a value -
Garvin Hicking uploaded patch set 5
V +112/11/25, 14:07 -
Garvin Hicking commented on patch set 5 12/11/25, 14:08
Reply
fixedSetupModuleController.php:757ReplyYes, for new code we should use that, thanks for pointing it out, fixed.SetupModuleController.php:767ReplyI know, but the module uses selected="selected" five more times and I'd rather keep it identical. And changing this would IMO be beyond the scope of this and can be a seperate cleanup to make reviewing this more reduced. -
core-ci voted on patch set 5 V +1 12/11/25, 14:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92072
-
Georg Ringer commented on patch set 5 CR +1 V +1 12/11/25, 18:37
love it so much -
Guido Schmechel commented on patch set 5 12/11/25, 21:03
Feature-108463-User-specificconfigurationofdate-timepickerstartofweek.rst:28be_users?locallang.xlf:166Is it clear to a non-technician what is meant by "locale"? Would "Default" or "Automatic" be better? -
Christian Kuhn commented on patch set 5 12/11/25, 21:20
SetupModuleController.php:761maybe rephrase/remove? i think we won't add symfony/intl just for this single case. i think we need a more important and broader use cases to justify addition of the dependency. we also have own api for various things symfony/intl provides as well. switching to symfony/intl and deprecating own API is thus a bigger task which is currently afaik not on the horizon? i'd be in favor of not suggesting that we'll do that right now here. note we *do* have php-intl for a while already. -
Jasmina Ließmann commented on patch set 5 12/11/25, 21:25
locallang.xlf:162Recently, "Snake Case" was used for newly introduced keys. Perhaps the naming should be adjusted here?ext_tables.php:104I'm unsure whether the addendum "(Datepicker)" in the label is sufficient, or whether a description should be added. Datepickers are somewhat more hidden. -
Garvin Hicking uploaded patch set 6
CR +1V +112/12/25, 07:43 -
Garvin Hicking commented on patch set 6 12/12/25, 07:45
yFeature-108463-User-specificconfigurationofdate-timepickerstartofweek.rst:28ReplyDoneSetupModuleController.php:761ReplyAgreed, I removed that reference. Sadly php-intl doesn't help in this case (well, it does, the weekday is retrieved from it, but with this "ugly" method to which there's no alternative I could find)locallang.xlf:162ReplyIndeed, thanks for noticing, I forgot!locallang.xlf:166ReplyYou're right, I rephrased this, hope that's fine :)ext_tables.php:104ReplyI rephrased that, hope that's better? -
core-ci voted on patch set 6 V +1 12/12/25, 07:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92112
-
Garvin Hicking commented on patch set 7
V +112/12/25, 10:36Published edit on patch set 6. -
Josef Glatz voted on patch set 7 CR +1 V +1 12/12/25, 10:41
-
core-ci voted on patch set 7 V +1 12/12/25, 10:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92128
-
Josef Glatz commented on patch set 7 12/12/25, 10:50
locallang.xlf:166Thank you! That is more clear now -
Georg Ringer voted on patch set 7 CR +1 V +1 12/12/25, 11:02
-
Christian Kuhn commented on patch set 7 12/12/25, 11:20
SetupModuleController.php:140this means the setting will vanish when uc is cleared. should we maybe turn this field into a true db field instead? -
Garvin Hicking commented on patch set 7 12/12/25, 12:01
SetupModuleController.php:140ReplyI would argue this is expected behaviour for the personal preferences and applies to many fields. I'd like to keep this in sync with the other settings there, which also affects their JS logic. (talked this over more in detail via DM, resolving) -
Christian Kuhn commented on patch set 7 CR +1 12/12/25, 12:02
SetupModuleController.php:140Replyack. -
Christian Kuhn voted on patch set 7 V -1 12/12/25, 12:04
-
Christian Kuhn commented on patch set 7 12/12/25, 12:09
my language: default en. i select 'monday' and save. monday is selected. i re-call 'user settings' -> back to 'default from'. -
Garvin Hicking commented on patch set 7 CR -1 12/12/25, 12:46
Reply
There is a problem with the persistence for ("" / "1") values it seems. Will try to understand what happens there. -
Garvin Hicking uploaded patch set 8
CR +1V +112/12/25, 13:45 -
Garvin Hicking commented on patch set 8 12/12/25, 13:50
Reply
I "fixed" it by using the name "format" to the JS event propagation. I don't yet understand why it is called like that and I could not use "dow" as the argument name. So...works now, but I'm a bit lost why :-( -
core-ci voted on patch set 8 V +1 12/12/25, 13:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92147
-
Garvin Hicking commented on patch set 8 CR -1 12/12/25, 13:58
Andi solved it, will do it proper -
Garvin Hicking uploaded patch set 9
CR -1V +112/12/25, 14:26Now with proper naming -
Garvin Hicking commented on patch set 9 12/12/25, 14:26
Reply
Done -
core-ci voted on patch set 9 V +1 12/12/25, 14:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92150
-
Georg Ringer voted on patch set 9 CR +1 V +1 12/12/25, 15:48
-
Guido Schmechel commented on patch set 9 CR -1 12/12/25, 18:25
Feature-108463-User-specificconfigurationofdate-timepickerstartofweek.rst:26"First day of week in calendar popups" Sooooorrryyyy :-) -
Garvin Hicking commented on patch set 10
CR +1V +112/12/25, 18:56Published edit on patch set 9. -
core-ci voted on patch set 10 V +1 12/12/25, 19:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92164
-
Guido Schmechel voted on patch set 10 CR +1 V +1 12/12/25, 19:18
-
Garvin Hicking commented on patch set 10 12/14/25, 18:32
Feature-108463-User-specificconfigurationofdate-timepickerstartofweek.rst:26ReplyDone -
Josef Glatz voted on patch set 10 V +1 12/14/25, 19:54
-
Georg Ringer voted on patch set 10 CR +1 V +1 12/15/25, 06:49
-
Garvin Hicking voted on patch set 10 CR +2 V +2 12/17/25, 06:17
-
Garvin Hicking merged patch set 11 12/17/25, 06:17