Review main Merged

92086[BUGFIX] Fix resource uri generation in subdir environments in installer

Benjamin Franzke CR +2 V +2 Easy +24 −13 updated 01/16/26, 12:44

Commit message

Review

  • Code review CR +2 Done
    • Helmut Hummel +2
    • Markus Klein +1
    • Garvin Hicking +1
    • Elias Häußler +1
  • Verified V +2 Done
    • Helmut Hummel +2
    • Josef Glatz +1
    • Markus Klein +1
    • Garvin Hicking +1
    • Elias Häußler +1
    • core-ci +1 CI

Issues 2

Files 5

Review log 2735

Show 710 earlier messages
  1. Benjamin Franzke uploaded patch set 1 12/10/25, 14:22

  2. core-ci voted on patch set 1 V +1 12/10/25, 14:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91992

  3. Benjamin Franzke commented on patch set 1 12/10/25, 15:09

    Icon API is still broken, generates: ``` <svg class="icon-color"><use xlink:href="/typo3/sysext/core/Resources/Public/Icons/T3Icons/sprites/spinner.svg?1764673178#spinner-circle" /></svg> ``` Instead of ``` <svg class="icon-color"><use xlink:href="/$basePath/typo3/sysext/core/Resources/Public/Icons/T3Icons/sprites/spinner.svg?1764673178#spinner-circle" /></svg> ```
  4. Benjamin Franzke voted on patch set 1 V -1 12/10/25, 15:11

  5. Helmut Hummel uploaded patch set 2 V +1 12/11/25, 12:25

  6. Helmut Hummel commented on patch set 1 12/11/25, 12:26

    Reply

    exposing globals request fixes icon api
  7. Helmut Hummel uploaded patch set 3 12/11/25, 12:28

  8. core-ci voted on patch set 2 V -1 12/11/25, 12:39 Copied votes on follow-up patch sets have been updated: * Verified-1 has been copied to patch set 3 (copy condition: "changekind:NO_CHANGE"). Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92067

  9. core-ci voted on patch set 3 V -1 12/11/25, 12:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92069

  10. Helmut Hummel uploaded patch set 4 V -1 12/11/25, 22:33

  1. core-ci voted on patch set 4 V -1 12/11/25, 22:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92088

  2. Helmut Hummel uploaded patch set 5 V -1 12/11/25, 22:49

  3. core-ci voted on patch set 5 V -1 12/11/25, 23:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92089

  4. Helmut Hummel uploaded patch set 6 V -1 12/12/25, 11:33

  5. core-ci voted on patch set 6 V +1 12/12/25, 11:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92136

  6. Helmut Hummel uploaded patch set 7 V +1 12/15/25, 12:38

  7. core-ci voted on patch set 7 V +1 12/15/25, 12:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92236

  8. Helmut Hummel commented on patch set 7 12/15/25, 13:00

    Reply

    Done
  9. Simon Schaufelberger commented on patch set 7 12/16/25, 09:14

    I guess this can also go into 14.0
  10. Garvin Hicking commented on patch set 7 12/16/25, 09:51

    I have a general question for this, I'm fine with an answer like "don't mind this" or "beyond scope", but I had to share my thoughts. For example, `typo3/sysext/adminpanel/Classes/Log/InMemoryLogWriter.php` has a method `writeLog` which does some things depending on the existence of `$GLOBALS['TYPO3_REQUEST']` which might now change due to this variable now being populated and no longer NULL. If I read this right, the variable would mainly be set in install/maintenance context, so only code checking for this that might run in this context is involved. So regular frontend, CLI tasks, regular backend already has `GLOBALS['TYPO3_REQUEST']. I wonder, if the logger in such a context might now write stuff into a logfile that it would not do before this patch, and if it does, if that's actually relevant. My feeling is, this should unlikely happen within install/maintenance context, but are you aware of this? I've searched for all occurences of TYPO3_REQUEST in the codebase (except tests) and found these places that might behave differently, grouped by my "assessment feeling": Likely Irrelevant: ------------------ * `typo3/sysext/backend/Classes/Clipboard/Clipboard.php->initializeClipboard` * `typo3/sysext/backend/Classes/Security/CategoryPermissionsAspect.php->addUserPermissionsToCategoryTreeData()` * `typo3/sysext/core/Classes/Resource/Security/StoragePermissionsAspect.php->addUserPermissionsToStorage` * `typo3/sysext/backend/Classes/Security/EmailLoginNotification.php->emailAtLogin` * `typo3/sysext/core/Classes/Authentication/AbstractUserAuthentication.php->isCookieSet` * `typo3/sysext/core/Classes/Hooks/CreateSiteConfiguration.php->getNormalizedParams` * `typo3/sysext/core/Classes/Messaging/FlashMessageQueue.php->getUserByContext` * `typo3/sysext/core/Classes/Messaging/FlashMessageRendererResolver.php->resolveContext` * `typo3/sysext/core/Classes/Page/PageRenderer.php->getApplicationType` * `typo3/sysext/core/Classes/PasswordPolicy/Validator/AbstractPasswordValidator.php->getLanguageService` * `typo3/sysext/core/Classes/Resource/File(Collection)Repository.php->isFrontendRequest` * `typo3/sysext/core/Classes/FormProtection/FormProtectionFactory.php->createForType` * `typo3/sysext/core/Classes/Utility/File/ExtendedFileUtility.php->isBackendScope` * Extbase: `typo3/sysext/extbase/Classes/Configuration/ConfigurationManager.php->getConfiguration`, `typo3/sysext/extbase/Classes/Persistence/Generic/Storage/Typo3DbBackend.php->getUidOfAlreadyPersistedValueObject`, `typo3/sysext/extbase/Classes/Persistence/Generic/Storage/Typo3DbQueryParser.php->getVisibilityConstraintStatement`, `typo3/sysext/extbase/Classes/Service/ImageService.php->getImageFromSource`, `typo3/sysext/extbase/Classes/Utility/LocalizationUtility.php->translate` * `typo3/sysext/fluid/Classes/ViewHelpers/Format/DateViewHelper.php->resolveLocale` * EXT:form `typo3/sysext/form/Classes/Domain/Configuration/ConfigurationService.php->getFormSettings`, `typo3/sysext/form/Classes/EventListener/DataStructureIdentifierListener.php->modifyDataStructure`, `typo3/sysext/form/Classes/Service/TranslationService.php->translate` * `typo3/sysext/frontend/Classes/Aspect/FileMetadataOverlayAspect.php->languageAndWorkspaceOverlay` * `typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php->getRequest` * `typo3/sysext/workspaces/Classes/Notification/StageChangeNotification.php->sendEmail` Might be relevant: ------------------ * `typo3/sysext/backend/Classes/Resource/Processing/DeferredBackendImageProcessor.php->canProcessTask` * `typo3/sysext/backend/Classes/Routing/UriBuilder.php->buildUri` * `typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php->logoff` * `typo3/sysext/core/Classes/Error/AbstractExceptionHandler.php->writeLogEntries` (related to initial example) * `typo3/sysext/core/Classes/Error/ErrorHandler.php->getFormattedLogMessage` (related to initial example) * `typo3/sysext/core/Classes/Resource/ResourceFactory.php->getFileReferenceData` * `typo3/sysext/core/Classes/Resource/ResourceStorage.php->isOnline` Unsure: ------- * `typo3/sysext/fluid/Classes/Core/ViewHelper/ViewHelperResolver.php` * `typo3/sysext/frontend/Classes/Utility/CanonicalizationUtility.php->getParamsToExcludeForCanonicalizedUrl` * `typo3/sysext/styleguide/Classes/TcaDataGenerator/GeneratorFrontend.php->create` Intentionally left out because that's what the fix is about: ------------------------------------------------------------ * `typo3/sysext/core/Classes/Utility/GeneralUtility.php->createVersionNumberedFilename` * `typo3/sysext/core/Classes/SystemResource/Publishing/DefaultSystemResourcePublisher.php->generateUri` * `typo3/sysext/frontend/Classes/Resource/PublicUrlPrefixer.php->prefixWithAbsRefPrefix`
  11. Markus Klein commented on patch set 7 12/16/25, 10:00

    Reply

    That would be new to me. We never fix stuff in non LTS versions, unless those are SEC
  12. Simon Schaufelberger wrote 12/16/25, 10:01

    Removed cc Simon Schaufelberger.
  13. Markus Klein commented on patch set 7 V +1 12/16/25, 10:18

    installer works for me in classic install within subdirectory
  14. Simon Schaufelberger commented on patch set 7 12/16/25, 11:08

    Reply

    I just saw a couple of commits also go into v14.0: https://review.typo3.org/q/project:Packages/TYPO3.CMS+branch:14.0 but I also don't understand why.
  15. Garvin Hicking commented on patch set 7 12/16/25, 11:32

    Reply

    That was my misunderstanding and "now I know". Disregard 14.0 backports please. :)
  16. Garvin Hicking updated the commit message in patch set 8 V +1 12/22/25, 07:40

  17. core-ci voted on patch set 8 V +1 12/22/25, 07:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92575

  18. Markus Klein voted on patch set 8 V +1 12/22/25, 08:16

  19. Markus Klein voted on patch set 8 CR +1 12/22/25, 08:16

  20. Elias Häußler voted on patch set 8 CR +1 V +1 01/12/26, 08:19

  21. Helmut Hummel commented on patch set 8 01/15/26, 08:07

    Reply

    Thanks Garvin. I checked all of those and my assessment is, that this change does not negatively affect the code you mention. Either because it isn't called at all in install tool, or because the outcome is the same.
  22. Garvin Hicking commented on patch set 8 CR +1 V +1 01/15/26, 09:19

    Reply

    Thanks for taking the time and to confirm that I need not worry.
  23. Josef Glatz voted on patch set 8 V +1 01/15/26, 19:44

  24. Helmut Hummel voted on patch set 8 CR +2 V +2 01/16/26, 12:44

  25. Helmut Hummel merged patch set 9 01/16/26, 12:44