Review main Merged

92088[TASK] Enlarge DB field `tx_scheduler_task.selected_tables`

Garvin Hicking CR +2 V +2 Easy +1 −0 updated 12/11/25, 08:05

Commit message

The default TCA automatic DB migration for the new field
`tx_scheduler_task.selected_tables` applied a `varchar(255)`
to that field.

However, creating a task and selecting multiple tables can
easily exceed this limit.

The character limit has now been raised to 4000 using the
TCA `dbFieldLength` attribute, to prevent needing either
a custom  `ext_tables.sql` entry, or needing to adjust the
`DefaultTcaSchema` for custom non-string (longtext) storage.

There the problem would be that `items` is by default set
to an empty array, so no length evaluation can take place,
because actual items are only populated later on.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Josef Glatz +1
    • Oliver Klee +1
    • Guido Schmechel +1
  • Verified V +2 Done
    • Benni Mack +2
    • Josef Glatz +1
    • Guido Schmechel +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 78

  1. Garvin Hicking uploaded patch set 1 12/10/25, 14:33

  2. core-ci voted on patch set 1 V +1 12/10/25, 14:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91995

  3. Oliver Klee voted on patch set 1 CR +1 12/10/25, 14:45

  4. Benni Mack voted on patch set 1 CR +1 V +1 12/10/25, 15:11

  5. Josef Glatz voted on patch set 1 CR +1 V +1 12/11/25, 07:56

  6. Guido Schmechel voted on patch set 1 CR +1 V +1 12/11/25, 08:02

  7. Benni Mack voted on patch set 1 CR +2 V +2 12/11/25, 08:05

  8. Benni Mack merged patch set 2 12/11/25, 08:05