92092[TASK] Add return type declarations in DI processors
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oliver Klee +1
-
Verified V +2 Done
- Benni Mack +2
- Oliver Klee +1
- core-ci +1 CI
Issues 2
Files 8
- typo3/sysext/core/Classes/DependencyInjection/AllowedCallablePass.php+1 −1
- typo3/sysext/core/Classes/DependencyInjection/AutowireInjectMethodsPass.php2+1 −3
- typo3/sysext/core/Classes/DependencyInjection/ConsoleCommandPass.php+1 −4
- typo3/sysext/core/Classes/DependencyInjection/LoggerAwarePass.php+1 −4
- typo3/sysext/core/Classes/DependencyInjection/LoggerInterfacePass.php2+1 −2
- typo3/sysext/core/Classes/DependencyInjection/PublicServicePass.php+1 −4
- typo3/sysext/core/Classes/DependencyInjection/SingletonPass.php+1 −4
- typo3/sysext/fluid/Configuration/Services.php+1 −1
Review log 1724
-
Benjamin Franzke uploaded patch set 1 12/10/25, 17:23
-
core-ci voted on patch set 1 V +1 12/10/25, 17:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92008
-
Benjamin Franzke uploaded patch set 2
V +112/10/25, 18:31 -
Benjamin Franzke uploaded patch set 3 12/10/25, 18:39
-
core-ci voted on patch set 3 V +1 12/10/25, 18:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92015
-
Benjamin Franzke rebased onto patch set 4
V +112/10/25, 22:09 -
core-ci voted on patch set 4 V -1 12/10/25, 22:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92026
-
Benni Mack updated the commit message in patch set 5
V -112/18/25, 20:00 -
core-ci voted on patch set 5 V -1 12/18/25, 20:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92443
-
Benni Mack rebased onto patch set 6
V -112/19/25, 11:19 -
core-ci voted on patch set 6 V +1 12/19/25, 11:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92472
-
Benni Mack marked it ready for review 12/19/25, 11:35
-
Benni Mack voted on patch set 6 CR +1 V +1 12/19/25, 11:35
-
Garvin Hicking commented on patch set 6 12/19/25, 13:07
-
Benni Mack commented on patch set 7
CR +1V +112/19/25, 13:43Published edit on patch set 6. -
Benni Mack commented on patch set 7 12/19/25, 13:44
LoggerInterfacePass.php:36ReplyDone -
core-ci voted on patch set 7 V +1 12/19/25, 13:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92481
-
Oliver Klee commented on patch set 7 V +1 12/19/25, 14:15
AutowireInjectMethodsPass.php:31We can remove this redundant PHPDoc return type, too. -
Benni Mack commented on patch set 8
V +112/19/25, 14:20Published edit on patch set 7. -
Oliver Klee voted on patch set 8 CR +1 V +1 12/19/25, 14:26
-
Oliver Klee commented on patch set 8 12/19/25, 14:26
AutowireInjectMethodsPass.php:31ReplyDone -
core-ci voted on patch set 8 V +1 12/19/25, 14:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92482
-
Benni Mack voted on patch set 8 CR +2 V +2 12/19/25, 14:35
-
Benni Mack merged patch set 9 12/19/25, 14:35
LoggerInterfacePass.php:36