Review main Merged

92092[TASK] Add return type declarations in DI processors

Benjamin Franzke CR +2 V +2 Easy +8 −23 updated 12/19/25, 14:35

Commit message

This change prepares TYPO3 core code to be compatible
with Symfony 8 while keeping compatibility with previous
Symfony versions, specifically Symfony 7.x.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 2

Files 8

Review log 1724

  1. Benjamin Franzke uploaded patch set 1 12/10/25, 17:23

  2. core-ci voted on patch set 1 V +1 12/10/25, 17:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92008

  3. Benjamin Franzke uploaded patch set 2 V +1 12/10/25, 18:31

  4. Benjamin Franzke uploaded patch set 3 12/10/25, 18:39

  5. core-ci voted on patch set 3 V +1 12/10/25, 18:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92015

  6. Benjamin Franzke rebased onto patch set 4 V +1 12/10/25, 22:09

  7. core-ci voted on patch set 4 V -1 12/10/25, 22:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92026

  8. Benni Mack updated the commit message in patch set 5 V -1 12/18/25, 20:00

  9. core-ci voted on patch set 5 V -1 12/18/25, 20:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92443

  10. Benni Mack rebased onto patch set 6 V -1 12/19/25, 11:19

  11. core-ci voted on patch set 6 V +1 12/19/25, 11:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92472

  12. Benni Mack marked it ready for review 12/19/25, 11:35

  13. Benni Mack voted on patch set 6 CR +1 V +1 12/19/25, 11:35

  14. Garvin Hicking commented on patch set 6 12/19/25, 13:07

    LoggerInterfacePass.php:36

    remove return from phpdoc? Also that param could go due to redundancy?
  15. Benni Mack commented on patch set 7 CR +1 V +1 12/19/25, 13:43

    Published edit on patch set 6.
  16. Benni Mack commented on patch set 7 12/19/25, 13:44

    LoggerInterfacePass.php:36 Reply

    Done
  17. core-ci voted on patch set 7 V +1 12/19/25, 13:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92481

  18. Oliver Klee commented on patch set 7 V +1 12/19/25, 14:15

    AutowireInjectMethodsPass.php:31

    We can remove this redundant PHPDoc return type, too.
  19. Benni Mack commented on patch set 8 V +1 12/19/25, 14:20

    Published edit on patch set 7.
  20. Oliver Klee voted on patch set 8 CR +1 V +1 12/19/25, 14:26

  21. Oliver Klee commented on patch set 8 12/19/25, 14:26

    AutowireInjectMethodsPass.php:31 Reply

    Done
  22. core-ci voted on patch set 8 V +1 12/19/25, 14:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92482

  23. Benni Mack voted on patch set 8 CR +2 V +2 12/19/25, 14:35

  24. Benni Mack merged patch set 9 12/19/25, 14:35