92096[TASK] Rename SystemInformationController to EventListener and modernize class
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Lina Wolf +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Christian Kuhn +2
- Lina Wolf +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 1
Review log 2024
-
Simon Schaufelberger uploaded patch set 1 12/10/25, 21:45
-
core-ci voted on patch set 1 V +1 12/10/25, 21:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92023
-
Christian Kuhn voted on patch set 1 CR +1 V +1 12/10/25, 22:30
-
Lina Wolf commented on patch set 1 CR +1 V +1 12/11/25, 05:50
My fingers where actually itching to do the same just yesterday ;) -
Torben Hansen voted on patch set 1 CR +1 V +1 12/11/25, 09:55
-
Benni Mack commented on patch set 1 12/11/25, 10:13
SystemInformationEventListener.php:70if you go with DI, you could also use the UriBuilder to inject as well :) -
Simon Schaufelberger commented on patch set 1 12/11/25, 10:34
SystemInformationEventListener.php:70ReplyI was thinking about that but the UriBuilder has state and I wasn't sure if this could lead to side effects -
Benni Mack uploaded patch set 2
CR +1V +112/11/25, 10:48 -
Simon Schaufelberger commented on patch set 2 CR +1 V +1 12/11/25, 10:50
SystemInformationEventListener.php:70ReplyDone -
core-ci voted on patch set 2 V +1 12/11/25, 10:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92058
-
Lina Wolf commented on patch set 2 12/11/25, 11:05
SystemInformationEventListener.php:75```suggestion 'belog.messages', ``` -
Simon Schaufelberger commented on patch set 3
CR +1V +112/11/25, 11:13Published edit on patch set 2. -
Simon Schaufelberger commented on patch set 3 12/11/25, 11:13
SystemInformationEventListener.php:75ReplyFix applied. -
core-ci voted on patch set 3 V +1 12/11/25, 11:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92061
-
Lina Wolf commented on patch set 3 CR +1 V +1 12/11/25, 11:28
Count is displayed correctly in the system menu -
Simon Schaufelberger voted on patch set 3 CR +1 V +1 12/11/25, 11:46
-
Garvin Hicking updated the commit message in patch set 4
CR +1V +112/11/25, 12:01 -
Lina Wolf voted on patch set 4 CR +1 V +1 12/11/25, 12:07
-
core-ci voted on patch set 4 V +1 12/11/25, 12:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92065
-
Simon Schaufelberger voted on patch set 4 CR +1 V +1 12/11/25, 12:44
-
Christian Kuhn commented on patch set 4 12/11/25, 15:47
SystemInformationEventListener.php:70Replyyeah. that's why i didn't do that, too. -
Christian Kuhn commented on patch set 4 CR +2 V +2 12/11/25, 15:50
thx. note i would have picked patch set 1 just as it was: this was a no-brainer. now i mixed 2 other topics: injecting the stateful UriBuilder, and changing label stuff. -
Christian Kuhn merged patch set 5 12/11/25, 15:50
-
Benni Mack commented on patch set 5 12/11/25, 16:43
Reply
note 2: UriBuilder contains state, just like ConnectionPool, Router, TcaSchemaFactory. State that I consider "configuration".