Review main Merged

92097[TASK] Avoid Symfony\Component\Console\Application::add

Benjamin Franzke CR +2 V +2 Easy +1 −1 updated 12/19/25, 16:32

Commit message

Symfony introduced addCommands() as an alternative
to add() method. The latter method is marked as deprecated
and thus, should not be used anymore.

This change adapts the affected piece of code.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 811

  1. Benjamin Franzke uploaded patch set 1 12/10/25, 22:09

  2. core-ci voted on patch set 1 V -1 12/10/25, 22:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92028

  3. Benjamin Franzke rebased onto patch set 2 V -1 12/19/25, 14:35

  4. core-ci voted on patch set 2 V +1 12/19/25, 14:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92485

  5. Benni Mack updated the commit message in patch set 3 V +1 12/19/25, 15:58

  6. Benni Mack marked it ready for review 12/19/25, 15:58

  7. core-ci voted on patch set 3 V +1 12/19/25, 16:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92489

  8. Benni Mack voted on patch set 3 CR +1 V +1 12/19/25, 16:09

  9. Oliver Klee voted on patch set 3 CR +1 V +1 12/19/25, 16:21

  10. Benni Mack voted on patch set 3 CR +2 V +2 12/19/25, 16:32

  11. Benni Mack merged patch set 4 12/19/25, 16:32