Review main Merged

92098[BUGFIX] Naturally sort extension settings

Thomas Hohn CR +2 V +2 Easy +2 −2 updated 12/12/25, 06:17

Commit message

The SettingsController sorts the categories and items read from
ext_conf_template.txt.
The ksort calls should be called with the option SORT_NATURAL to
preserve the sort order correctly.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1317

  1. Thomas Hohn uploaded patch set 1 12/11/25, 09:28

  2. Mathias Brodala updated the commit message in patch set 2 12/11/25, 09:29

  3. core-ci voted on patch set 1 V +1 12/11/25, 09:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92054

  4. core-ci voted on patch set 2 V +1 12/11/25, 09:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92055

  5. Andreas Kienast commented on patch set 2 12/11/25, 10:01

    That's not true, `SORT_NATURAL` is always applied (which is fine).
  6. Thomas Hohn commented on patch set 2 12/11/25, 10:19

    Reply

    So you just want to have another text? The ksort calls should be called with the option SORT_NATURAL to preserve the sort order correctly .
  7. Thomas Hohn updated the commit message in patch set 3 V +1 12/11/25, 10:59

  8. Thomas Hohn commented on patch set 3 12/11/25, 10:59

    Reply

    Done
  9. core-ci voted on patch set 3 V +1 12/11/25, 11:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92059

  10. Garvin Hicking commented on patch set 3 12/11/25, 11:20

    I think we should scope this to v13+main as it's not a high-priority bugfix
  11. Thomas Hohn updated the commit message in patch set 4 V +1 12/11/25, 11:32

  12. Thomas Hohn commented on patch set 4 12/11/25, 11:33

    Reply

    Acknowledged
  13. core-ci voted on patch set 4 V +1 12/11/25, 11:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92064

  14. Garvin Hicking voted on patch set 4 CR +1 V +1 12/11/25, 12:04

  15. Christian Kuhn voted on patch set 4 CR +1 V +1 12/11/25, 21:32

  16. Garvin Hicking voted on patch set 4 CR +2 V +2 12/12/25, 05:53

  17. Garvin Hicking merged patch set 5 12/12/25, 06:17