92103[TASK] Introduce centralized sidebar state management
Commit message
Review
-
Code review CR +2 Done
- Benjamin Kott +2
- Georg Ringer +1
- Oli Bartsch +1
-
Verified V +2 Done
- Benjamin Kott +2
- Georg Ringer +1
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 34
- Build/Sources/Sass/component/scaffold/_modulemenu.scss+2 −2
- Build/Sources/Sass/component/scaffold/_scaffold.scss+55 −30
- Build/Sources/Sass/component/_module.scss+1 −1
- Build/Sources/Sass/component/_root.scss+49 −15
- Build/Sources/Sass/libs/_nprogress.scss+2 −2
- Build/Sources/TypeScript/backend/element/sidebar-toggle-element.tsnew+110 −0
- Build/Sources/TypeScript/backend/enum/viewport/scaffold-identifier.ts+1 −1
- Build/Sources/TypeScript/backend/viewport/scaffold-state.tsnew+268 −0
- Build/Sources/TypeScript/backend/viewport/toolbar.ts+75 −0
- Build/Sources/TypeScript/backend/module-menu.ts+4 −80
- Build/Sources/TypeScript/backend/toolbar.ts+8 −5
- Build/Sources/TypeScript/install/router.ts+5 −29
- Build/tests/playwright/e2e/layout/sidebar-toggle.spec.tsnew+67 −0
- Build/tests/playwright/fixtures/backend-page.ts+19 −0
- Build/tests/playwright/fixtures/sidebar.tsnew+40 −0
- Build/tests/playwright/helper/login.setup.ts+1 −1
- typo3/sysext/backend/Classes/Controller/BackendController.php+3 −3
- typo3/sysext/backend/Resources/Private/Language/locallang_toolbar.xlf+5 −2
- typo3/sysext/backend/Resources/Private/Partials/Backend/Topbar.fluid.html5+7 −24
- typo3/sysext/backend/Resources/Private/Templates/Backend/Main.fluid.html3+7 −7
Show 14 more files
- typo3/sysext/backend/Resources/Public/Css/backend.css+25 −19
- typo3/sysext/backend/Resources/Public/JavaScript/element/sidebar-toggle-element.jsnew+13 −0
- typo3/sysext/backend/Resources/Public/JavaScript/enum/viewport/scaffold-identifier.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/viewport/scaffold-state.jsnew+13 −0
- typo3/sysext/backend/Resources/Public/JavaScript/viewport/toolbar.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/module-menu.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/toolbar.js+1 −1
- typo3/sysext/core/Tests/Acceptance/Application/Login/BackendLoginCest.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Application/Styleguide/NotificationCest.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Application/Topbar/BookmarkCest.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Application/Topbar/ModuleMenuButtonCest.phpdeleted+0 −88
- typo3/sysext/install/Classes/Controller/AbstractController.php3+1 −1
- typo3/sysext/install/Resources/Private/Templates/Layout/MainLayout.fluid.html+8 −11
- typo3/sysext/install/Resources/Public/JavaScript/router.js+1 −1
Review log 1829
Show 24 earlier messages
-
Benjamin Kott uploaded patch set 1 12/11/25, 17:21
-
core-ci voted on patch set 1 V -1 12/11/25, 17:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92081
-
Benjamin Kott uploaded patch set 2
V -112/12/25, 16:52 -
core-ci voted on patch set 2 V -1 12/12/25, 17:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92157
-
Benjamin Kott uploaded patch set 3
V -112/15/25, 15:33 -
Benjamin Kott uploaded patch set 4 12/15/25, 15:41
-
core-ci voted on patch set 4 V -1 12/15/25, 15:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92244
-
core-ci voted on patch set 3 V -1 12/15/25, 16:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92241
-
Benjamin Kott rebased onto patch set 5
V -112/16/25, 07:17 -
core-ci voted on patch set 5 V -1 12/16/25, 07:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92274
-
Benjamin Kott uploaded patch set 6
V -112/16/25, 09:04 -
core-ci voted on patch set 6 V -1 12/16/25, 09:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92276
-
Benjamin Kott uploaded patch set 7
V -112/16/25, 09:48 -
core-ci voted on patch set 7 V +1 12/16/25, 09:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92277
-
Benjamin Kott uploaded patch set 8
V +112/16/25, 10:00 -
Benjamin Kott updated the commit message in patch set 9 12/16/25, 10:05
-
core-ci voted on patch set 8 V +1 12/16/25, 10:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92280
-
core-ci voted on patch set 9 V +1 12/16/25, 10:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92283
-
Oli Bartsch commented on patch set 9 12/16/25, 11:14
Main.fluid.html:29We should also check for "hasSidebarContent" here. Additionally, we might think of if we place the before and after content in specific container, because having the after content be fixed on the bottom should be done by the system and not decided by extensions individually.AbstractController.php:51Why do we need this change here? -
Benjamin Kott commented on patch set 9 12/16/25, 11:43
Topbar.fluid.html:15Replyyes, did not have a better solution here without additional additionsMain.fluid.html:29Replythis needs to be done in the workspace patchAbstractController.php:51Replyyes we need to detect the context to define if it´s in the install tool or not to change the storage to localstoage and not persistence storage -
Oli Bartsch commented on patch set 9 12/16/25, 13:10
Topbar.fluid.html:14needs to be `backend.toolbar` -
Benjamin Kott uploaded patch set 10
V +112/16/25, 13:14 -
Benjamin Kott uploaded patch set 11 12/16/25, 13:21
-
core-ci voted on patch set 10 V +1 12/16/25, 13:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92295
-
Oli Bartsch commented on patch set 11 CR +1 V +1 12/16/25, 13:23
Topbar.fluid.html:14ReplyDoneAbstractController.php:51ReplyDone -
core-ci voted on patch set 11 V +1 12/16/25, 13:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92298
-
Georg Ringer voted on patch set 11 CR +1 V +1 12/16/25, 13:57
-
Benjamin Kott commented on patch set 11 CR +2 V +2 12/16/25, 14:01
Topbar.fluid.html:15ReplyDoneMain.fluid.html:29ReplyDone -
Benjamin Kott merged patch set 12 12/16/25, 14:02
Topbar.fluid.html:15