Review main Merged

92103[TASK] Introduce centralized sidebar state management

Benjamin Kott CR +2 V +2 Expert +797 −329 updated 12/16/25, 14:02

Commit message

This patch separates the concerns of the sidebar and module menu by
introducing a unified ScaffoldState class that manages all sidebar
and toolbar state transitions.

The sidebar now behaves responsively: on desktop (≥992px) it expands
and collapses in place with the state persisted per user preference,
while on mobile (<992px) it appears as a flyout overlay that
automatically closes when loading a module for improved mobile UX.

A new typo3-backend-sidebar-toggle web component with proper ARIA
attributes replaces the previous module menu button implementation.
The toolbar toggle functionality has been moved to a dedicated
viewport/toolbar module for cleaner separation of concerns.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Georg Ringer +1
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Georg Ringer +1
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 34

Show 14 more files

Review log 1829

Show 24 earlier messages
  1. Benjamin Kott uploaded patch set 1 12/11/25, 17:21

  2. core-ci voted on patch set 1 V -1 12/11/25, 17:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92081

  3. Benjamin Kott uploaded patch set 2 V -1 12/12/25, 16:52

  4. core-ci voted on patch set 2 V -1 12/12/25, 17:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92157

  1. Benjamin Kott uploaded patch set 3 V -1 12/15/25, 15:33

  2. Benjamin Kott uploaded patch set 4 12/15/25, 15:41

  3. core-ci voted on patch set 4 V -1 12/15/25, 15:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92244

  4. core-ci voted on patch set 3 V -1 12/15/25, 16:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92241

  5. Benjamin Kott rebased onto patch set 5 V -1 12/16/25, 07:17

  6. core-ci voted on patch set 5 V -1 12/16/25, 07:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92274

  7. Benjamin Kott uploaded patch set 6 V -1 12/16/25, 09:04

  8. core-ci voted on patch set 6 V -1 12/16/25, 09:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92276

  9. Benjamin Kott uploaded patch set 7 V -1 12/16/25, 09:48

  10. core-ci voted on patch set 7 V +1 12/16/25, 09:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92277

  11. Benjamin Kott uploaded patch set 8 V +1 12/16/25, 10:00

  12. Benjamin Kott updated the commit message in patch set 9 12/16/25, 10:05

  13. core-ci voted on patch set 8 V +1 12/16/25, 10:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92280

  14. core-ci voted on patch set 9 V +1 12/16/25, 10:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92283

  15. Oli Bartsch commented on patch set 9 12/16/25, 11:14

    Topbar.fluid.html:15

    We need another condition here, because the sidebar does no longer depend on module menu but on any component like workspace selector or user settings link. I will do this in the worksapces patch when also introducing the events.

    Main.fluid.html:29

    We should also check for "hasSidebarContent" here. Additionally, we might think of if we place the before and after content in specific container, because having the after content be fixed on the bottom should be done by the system and not decided by extensions individually.

    AbstractController.php:51

    Why do we need this change here?
  16. Benjamin Kott commented on patch set 9 12/16/25, 11:43

    Topbar.fluid.html:15 Reply

    yes, did not have a better solution here without additional additions

    Main.fluid.html:29 Reply

    this needs to be done in the workspace patch

    AbstractController.php:51 Reply

    yes we need to detect the context to define if it´s in the install tool or not to change the storage to localstoage and not persistence storage
  17. Oli Bartsch commented on patch set 9 12/16/25, 13:10

    Topbar.fluid.html:14

    needs to be `backend.toolbar`
  18. Benjamin Kott uploaded patch set 10 V +1 12/16/25, 13:14

  19. Benjamin Kott uploaded patch set 11 12/16/25, 13:21

  20. core-ci voted on patch set 10 V +1 12/16/25, 13:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92295

  21. Oli Bartsch commented on patch set 11 CR +1 V +1 12/16/25, 13:23

    Topbar.fluid.html:14 Reply

    Done

    AbstractController.php:51 Reply

    Done
  22. core-ci voted on patch set 11 V +1 12/16/25, 13:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92298

  23. Georg Ringer voted on patch set 11 CR +1 V +1 12/16/25, 13:57

  24. Benjamin Kott commented on patch set 11 CR +2 V +2 12/16/25, 14:01

    Topbar.fluid.html:15 Reply

    Done

    Main.fluid.html:29 Reply

    Done
  25. Benjamin Kott merged patch set 12 12/16/25, 14:02