92107[TASK] Make methods for final classes private in tests
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oliver Klee +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- core-ci +1 CI
Issues 3
Files 88
- typo3/sysext/backend/Tests/Functional/Controller/ContentElement/NewContentElementControllerTest.php+1 −1
- typo3/sysext/backend/Tests/Functional/Controller/EditDocumentControllerTest.php+2 −2
- typo3/sysext/backend/Tests/Functional/Controller/FormInlineAjaxControllerTest.php+1 −1
- typo3/sysext/backend/Tests/Functional/Controller/MfaAjaxControllerTest.php+1 −1
- typo3/sysext/backend/Tests/Functional/Form/Element/MfaInfoElementTest.php+1 −1
- typo3/sysext/backend/Tests/Functional/Form/FormDataProvider/TcaCategoryTest.php+2 −2
- typo3/sysext/backend/Tests/Functional/History/RecordHistoryStoreTest.php+1 −1
- typo3/sysext/backend/Tests/Functional/RecordList/DownloadRecordListTest.php+1 −1
- typo3/sysext/backend/Tests/Functional/View/Drawing/BackendLayoutRendererTest.php+1 −1
- typo3/sysext/backend/Tests/Functional/ViewHelpers/Mfa/IfHasStateViewHelperTest.php+1 −1
- typo3/sysext/backend/Tests/Unit/CodeEditor/Registry/AddonRegistryTest.php+1 −1
- typo3/sysext/backend/Tests/Unit/ElementBrowser/ElementBrowserRegistryTest.php+1 −1
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaCheckboxItemsTest.php+1 −1
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaLanguageTest.php+2 −2
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaRadioItemsTest.php+1 −1
- typo3/sysext/backend/Tests/Unit/Module/ModuleRegistryTest.php+1 −1
- typo3/sysext/backend/Tests/Unit/Security/EmailLoginNotificationTest.php+1 −1
- typo3/sysext/backend/Tests/Unit/Tree/SortedTreeNodeCollectionTest.php+2 −2
- typo3/sysext/beuser/Tests/Functional/Controller/BackendUserControllerTest.php+1 −1
- typo3/sysext/core/Tests/Functional/Authentication/Mfa/Provider/RecoveryCodesProviderTest.php+1 −1
Show 68 more files
- typo3/sysext/core/Tests/Functional/Authentication/Mfa/Provider/TotpProviderTest.php+1 −1
- typo3/sysext/core/Tests/Functional/Authentication/Mfa/MfaProviderPropertyManagerTest.php+2 −2
- typo3/sysext/core/Tests/Functional/Authentication/Mfa/MfaProviderRegistryTest.php+3 −3
- typo3/sysext/core/Tests/Functional/Cache/Backend/MemcachedBackendTest.php+1 −1
- typo3/sysext/core/Tests/Functional/Cache/Backend/RedisBackendTest.php+1 −1
- typo3/sysext/core/Tests/Functional/Cache/Backend/Typo3DatabaseBackendTest.php+1 −1
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/SelectCheckBoxTest.php+1 −1
- typo3/sysext/core/Tests/Functional/DataHandling/RecordFieldTransformerTest.php+3 −3
- typo3/sysext/core/Tests/Functional/Domain/Repository/PageRepositoryTest.php+2 −2
- typo3/sysext/core/Tests/Functional/Imaging/IconFactoryTest.php+2 −2
- typo3/sysext/core/Tests/Functional/Page/ImportMapTest.php+1 −1
- typo3/sysext/core/Tests/Functional/Page/PageRendererTest.php+1 −1
- typo3/sysext/core/Tests/Functional/PasswordPolicy/PasswordPolicyValidatorTest.php+1 −1
- typo3/sysext/core/Tests/Functional/Resource/SynchronizeFolderRelationsTest.php+1 −1
- typo3/sysext/core/Tests/Functional/Utility/PathUtilityPublicPathsTest.php+5 −5
- typo3/sysext/core/Tests/Unit/Configuration/ConfigurationManagerTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Database/Schema/Parser/TableOptionsTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Database/Schema/ConnectionMigratorTest.php+2 −2
- typo3/sysext/core/Tests/Unit/DependencyInjection/ListenerProviderPassTest.php+1 −1
- typo3/sysext/core/Tests/Unit/DependencyInjection/ServiceProviderCompilationPassTest.php+1 −1
- typo3/sysext/core/Tests/Unit/DependencyInjection/ServiceProviderRegistryTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Html/HtmlParserTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Log/Writer/FileWriterTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Log/Writer/RotatingFileWriterTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Log/LogRecordTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Mail/TransportFactoryTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Package/AbstractServiceProviderTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Package/PackageManagerTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Resource/Rendering/RendererRegistryTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Resource/TextExtraction/TextExtractorRegistryTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Resource/FileReferenceTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Resource/FolderTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Resource/ProcessedFileTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Utility/ExtensionManagementUtilityTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.php+2 −2
- typo3/sysext/dashboard/Tests/Functional/WidgetRegistryTest.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/ActionControllerTest.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/BlogPostEditingControllerTest.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Mvc/Validation/ActionControllerValidationTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Error/ResultTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Mvc/Controller/MvcPropertyMappingConfigurationServiceTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Reflection/ObjectAccessTest.php+2 −2
- typo3/sysext/extbase/Tests/Unit/Service/ExtensionServiceTest.php+0 −31
- typo3/sysext/extensionmanager/Tests/Unit/Controller/ActionControllerTest.php+1 −1
- typo3/sysext/extensionmanager/Tests/Unit/Report/ExtensionStatusTest.php+2 −2
- typo3/sysext/felogin/Tests/Unit/Configuration/RecoveryConfigurationTest.php+1 −1
- typo3/sysext/felogin/Tests/Unit/Redirect/RedirectHandlerTest.php+0 −11
- typo3/sysext/felogin/Tests/Unit/Validation/RedirectUrlValidatorTest.php+1 −1
- typo3/sysext/filelist/Tests/Unit/Matcher/ResourceFileExtensionMatcherTest.php+1 −1
- typo3/sysext/fluid/Tests/Functional/View/TemplatesPathsTest.php+1 −1
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Link/FileViewHelperTest.php+3 −3
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/SvgImageViewHelperTest.php+1 −1
- typo3/sysext/fluid_styled_content/Tests/Functional/Rendering/SecureHtmlRenderingTest.php+1 −1
- typo3/sysext/frontend/Tests/Functional/Aspect/FileMetadataOverlayAspectTest.php+2 −2
- typo3/sysext/frontend/Tests/Functional/Rendering/AbsoluteUriPrefixRenderingTest.php+2 −2
- typo3/sysext/frontend/Tests/Functional/Rendering/ScriptAndLinkTagRenderingTest.php+2 −2
- typo3/sysext/frontend/Tests/Functional/Rendering/SvgImageRenderingTest.php+2 −2
- typo3/sysext/frontend/Tests/Functional/Rendering/UriPrefixRenderingTest.php+2 −2
- typo3/sysext/frontend/Tests/Functional/Resource/FilePathSanitizerTest.php+1 −1
- typo3/sysext/impexp/Tests/Functional/Export/PagesAndTtContentWithImagesTest.php+1 −1
- typo3/sysext/impexp/Tests/Functional/Import/PagesAndTtContentWithImagesInFilledDatabaseTest.php+1 −1
- typo3/sysext/linkvalidator/Tests/Unit/Linktype/LinktypeRegistryTest.php+1 −1
- typo3/sysext/reactions/Tests/Functional/Reaction/CreateRecordReactionTest.php+2 −2
- typo3/sysext/reactions/Tests/Functional/ReactionRegistryTest.php+1 −1
- typo3/sysext/redirects/Tests/Functional/EventListener/AddPageTypeZeroSourceTest.php+2 −2
- typo3/sysext/redirects/Tests/Functional/RedirectUpdate/SlugRedirectChangeItemFactoryTest.php+1 −1
- typo3/sysext/redirects/Tests/Functional/WebhookExecutionTest.php+1 −1
- typo3/sysext/redirects/Tests/Unit/RedirectUpdate/SlugRedirectChangeItemTest.php+1 −1
Review log 710
-
Simon Schaufelberger uploaded patch set 1 12/12/25, 00:25
-
core-ci voted on patch set 1 V -1 12/12/25, 00:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92090
-
Simon Schaufelberger uploaded patch set 2
V -112/12/25, 00:42 -
Simon Schaufelberger uploaded patch set 3 12/12/25, 00:47
-
core-ci voted on patch set 2 V -1 12/12/25, 00:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92091
-
core-ci voted on patch set 3 V +1 12/12/25, 00:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92092
-
Oliver Klee voted on patch set 3 V +1 12/12/25, 07:37
-
Oliver Klee voted on patch set 3 CR +1 12/12/25, 07:38
-
Christian Kuhn voted on patch set 3 CR +2 V +2 12/12/25, 11:02
-
Christian Kuhn merged patch set 4 12/12/25, 11:02