Review main Merged

92122[BUGFIX] Prevent TypeError on empty server type input in setup command

Lina Wolf CR +2 V +2 Easy +1 −1 updated 12/18/25, 14:43

Commit message

When running the interactive setup command, pressing Enter at the
"Which web server is used?" prompt results in Symfony passing `null`
to the server type validator. The validator was declared with a
strict `string` parameter type, causing a PHP TypeError before TYPO3
could raise its intended validation exception.

By relaxing the validator signature to `?string`, empty input is now
handled gracefully and routed through the existing validation logic.
This restores the expected behavior where invalid or empty input
triggers the question to be asked again rather than aborting with a
fatal error.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Jochen Roth +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Lina Wolf uploaded patch set 1 12/13/25, 03:17

  2. core-ci voted on patch set 1 V +1 12/13/25, 03:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92173

  3. Oliver Klee voted on patch set 1 CR +1 12/13/25, 08:45

  4. Jochen Roth voted on patch set 1 CR +1 V +1 12/18/25, 13:58

  5. Christian Kuhn voted on patch set 1 CR +2 V +2 12/18/25, 13:59

  6. Christian Kuhn merged patch set 2 12/18/25, 14:43