92123[FEATURE] Fluid components integration
Commit message
Review
-
Code review CR +2 Done
- Simon Praetorius +2
- Garvin Hicking +1
- Matthias Vogel +1
- Helmut Hummel +1
-
Verified V +2 Done
- Simon Praetorius +2
- Garvin Hicking +1
- Matthias Vogel +1
- Helmut Hummel +1
- core-ci +1 CI
Issues 1
Files 36
- typo3/sysext/core/Classes/Package/AbstractServiceProvider.php+13 −0
- typo3/sysext/core/Classes/ServiceProvider.php+6 −0
- typo3/sysext/core/Configuration/DefaultConfiguration.php+5 −0
- typo3/sysext/core/Documentation/Changelog/14.1/Feature-108508-FluidComponentsIntegration.rst5new+222 −0
- typo3/sysext/core/Documentation/Changelog/14.1/Feature-108508-PSR-14EventsForFluidComponents.rst2new+171 −0
- typo3/sysext/fluid/Classes/Core/Component/ComponentCollectionRegistry.php2new+80 −0
- typo3/sysext/fluid/Classes/Core/Component/DeclarativeComponentCollection.php6new+148 −0
- typo3/sysext/fluid/Classes/Core/Component/EventBasedComponentRenderer.phpnew+61 −0
- typo3/sysext/fluid/Classes/Core/ViewHelper/ViewHelperResolver.php+4 −1
- typo3/sysext/fluid/Classes/Core/ViewHelper/ViewHelperResolverFactory.php2+7 −1
- typo3/sysext/fluid/Classes/Event/ModifyComponentDefinitionEvent.phpnew+48 −0
- typo3/sysext/fluid/Classes/Event/ProvideStaticVariablesToComponentEvent.phpnew+70 −0
- typo3/sysext/fluid/Classes/Event/RenderComponentEvent.phpnew+128 −0
- typo3/sysext/fluid/Classes/ServiceProvider.php2+4 −0
- typo3/sysext/fluid/Configuration/Services.yaml+5 −0
- typo3/sysext/fluid/Tests/Functional/Core/Component/ComponentsTest.phpnew+136 −0
- typo3/sysext/fluid/Tests/Functional/Fixtures/Extensions/components_override_test/Configuration/Fluid/ComponentCollections.phpnew+7 −0
- typo3/sysext/fluid/Tests/Functional/Fixtures/Extensions/components_override_test/Resources/Private/Components/ToBeOverwritten/ToBeOverwritten.fluid.htmlnew+3 −0
- typo3/sysext/fluid/Tests/Functional/Fixtures/Extensions/components_override_test/composer.jsonnew+15 −0
- typo3/sysext/fluid/Tests/Functional/Fixtures/Extensions/components_override_test/ext_emconf.phpnew+19 −0
Show 16 more files
- typo3/sysext/fluid/Tests/Functional/Fixtures/Extensions/components_test/Classes/Components/ClassBasedComponentCollection.phpnew+34 −0
- typo3/sysext/fluid/Tests/Functional/Fixtures/Extensions/components_test/Classes/Components/LegacyComponentCollection.phpnew+34 −0
- typo3/sysext/fluid/Tests/Functional/Fixtures/Extensions/components_test/Classes/EventListener/ComponentsEventListener.phpnew+95 −0
- typo3/sysext/fluid/Tests/Functional/Fixtures/Extensions/components_test/Configuration/Fluid/ComponentCollections.phpnew+18 −0
- typo3/sysext/fluid/Tests/Functional/Fixtures/Extensions/components_test/Configuration/Services.yamlnew+8 −0
- typo3/sysext/fluid/Tests/Functional/Fixtures/Extensions/components_test/Resources/Private/AlternativeStructure/AlternativeStructureComponent.fluid.htmlnew+1 −0
- typo3/sysext/fluid/Tests/Functional/Fixtures/Extensions/components_test/Resources/Private/ClassBased/ClassBasedComponent/ClassBasedComponent.fluid.htmlnew+1 −0
- typo3/sysext/fluid/Tests/Functional/Fixtures/Extensions/components_test/Resources/Private/Components/AlternativeRenderer/AlternativeRenderer.fluid.htmlnew+3 −0
- typo3/sysext/fluid/Tests/Functional/Fixtures/Extensions/components_test/Resources/Private/Components/ExtendedRenderer/ExtendedRenderer.fluid.htmlnew+2 −0
- typo3/sysext/fluid/Tests/Functional/Fixtures/Extensions/components_test/Resources/Private/Components/ModifiedComponent/ModifiedComponent.fluid.htmlnew+3 −0
- typo3/sysext/fluid/Tests/Functional/Fixtures/Extensions/components_test/Resources/Private/Components/StaticVariables/StaticVariables.fluid.htmlnew+1 −0
- typo3/sysext/fluid/Tests/Functional/Fixtures/Extensions/components_test/Resources/Private/Components/TestComponent/TestComponent.fluid.htmlnew+3 −0
- typo3/sysext/fluid/Tests/Functional/Fixtures/Extensions/components_test/Resources/Private/Components/ToBeOverwritten/ToBeOverwritten.fluid.htmlnew+1 −0
- typo3/sysext/fluid/Tests/Functional/Fixtures/Extensions/components_test/composer.jsonnew+19 −0
- typo3/sysext/fluid/Tests/Functional/Fixtures/Extensions/components_test/ext_emconf.phpnew+18 −0
- composer.json+1 −0
Review log 4671
Show 2646 earlier messages
-
Simon Praetorius uploaded patch set 1 12/13/25, 19:38
-
core-ci voted on patch set 1 V -1 12/13/25, 19:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92193
-
Simon Praetorius uploaded patch set 2
V -112/14/25, 09:48 -
core-ci voted on patch set 2 V -1 12/14/25, 09:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92210
-
Simon Praetorius uploaded patch set 3
V -112/14/25, 13:05 -
core-ci voted on patch set 3 V -1 12/14/25, 13:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92213
-
Simon Praetorius uploaded patch set 4
V -112/14/25, 13:35 -
core-ci voted on patch set 4 V -1 12/14/25, 13:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92214
-
Simon Praetorius uploaded patch set 5
V -112/14/25, 14:11 -
core-ci voted on patch set 5 V +1 12/14/25, 14:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92215
-
Simon Praetorius uploaded patch set 6
V +112/14/25, 14:42 -
core-ci voted on patch set 6 V +1 12/14/25, 14:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92217
-
Simon Praetorius uploaded patch set 7
V +112/14/25, 19:45 -
core-ci voted on patch set 7 V +1 12/14/25, 19:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92219
-
Simon Praetorius uploaded patch set 8
V +112/15/25, 19:11 -
core-ci voted on patch set 8 V -1 12/15/25, 19:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92249
-
Simon Praetorius uploaded patch set 9
V -112/15/25, 19:26 -
core-ci voted on patch set 9 V -1 12/15/25, 19:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92250
-
Simon Praetorius uploaded patch set 10
V -112/15/25, 19:37 -
core-ci voted on patch set 10 V -1 12/15/25, 19:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92251
-
Simon Praetorius uploaded patch set 11
V -112/15/25, 19:52 -
core-ci voted on patch set 11 V -1 12/15/25, 20:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92252
-
Helmut Hummel commented on patch set 11 12/16/25, 12:48
This change is ready for review.ViewHelperResolverFactory.php:53I would rather move all this factory code to DI creation, which would remove the dependency to FailsafeContainer here as well, and let this class only receive ready made componentCollections -
Helmut Hummel commented on patch set 11 12/16/25, 12:54
ServiceProvider.php:81ViewHelperResolverFactory does not need any of those in failsafe mode, right? -
Simon Praetorius rebased onto patch set 12
V -112/17/25, 15:36 -
core-ci voted on patch set 12 V +1 12/17/25, 15:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92355
-
Simon Praetorius uploaded patch set 13
V +112/17/25, 17:38 -
core-ci voted on patch set 13 V +1 12/17/25, 17:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92368
-
Simon Praetorius uploaded patch set 14
V +112/18/25, 13:11 -
core-ci voted on patch set 14 V -1 12/18/25, 13:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92415
-
Simon Praetorius uploaded patch set 15
V -112/18/25, 13:27 -
core-ci voted on patch set 15 V +1 12/18/25, 13:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92417
-
Simon Praetorius uploaded patch set 16
V +101/09/26, 14:14 -
Simon Praetorius uploaded patch set 17 01/09/26, 14:23
-
core-ci voted on patch set 17 V -1 01/09/26, 14:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93149
-
Simon Praetorius uploaded patch set 18
V -101/09/26, 14:56 -
core-ci voted on patch set 18 V +1 01/09/26, 15:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93155
-
core-ci voted on patch set 16 V -1 01/09/26, 15:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93147
-
Simon Praetorius uploaded patch set 19
V +101/10/26, 12:19 -
Simon Praetorius commented on patch set 19 01/10/26, 12:22
ViewHelperResolverFactory.php:53ReplyI've introduced a new `ComponentCollectionRegistry`, which takes care of creating component collection objects based on the provided configuration. This registry is now an optional dependency of `ViewHelperResolverFactory`, which means that it won't be provided at all in installtool context and the FailsafeContainer check is no longer necessary.ServiceProvider.php:81ReplyDone -
core-ci voted on patch set 19 V -1 01/10/26, 12:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93203
-
Simon Praetorius uploaded patch set 20
V -101/10/26, 12:30 -
core-ci voted on patch set 20 V +1 01/10/26, 12:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93204
-
Simon Schaufelberger voted on patch set 20 CR +1 01/10/26, 16:26
-
Matthias Vogel voted on patch set 20 CR +1 01/13/26, 15:35
-
Matthias Vogel commented on patch set 20 V -1 01/14/26, 09:40
DeclarativeComponentCollection.php:90"Hots-Mox-Components--molleti.bottomHost" is not a valid cache entry identifier.
-
Matthias Vogel uploaded patch set 21
CR +1V +101/14/26, 09:57 -
Matthias Vogel commented on patch set 21 CR +1 V +1 01/14/26, 09:57
DeclarativeComponentCollection.php:90ReplyDone -
Matthias Vogel uploaded patch set 22 01/14/26, 09:58
Copied Votes: * Code-Review+1 (copy condition: "**changekind:NO_CHANGE** OR is:MIN") * Verified+1 (copy condition: "**changekind:NO_CHANGE**") -
Matthias Vogel uploaded patch set 23
CR +1V +101/14/26, 09:59 -
Matthias Vogel voted on patch set 23 CR +1 V +1 01/14/26, 09:59
-
core-ci voted on patch set 21 V -1 01/14/26, 10:07 Copied votes on follow-up patch sets have been updated: * Verified-1 has been copied to patch set 22 (copy condition: "changekind:NO_CHANGE"). Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93429
-
core-ci voted on patch set 22 V -1 01/14/26, 10:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93430
-
core-ci voted on patch set 23 V +1 01/14/26, 10:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93431
-
Helmut Hummel commented on patch set 23 01/15/26, 08:23
Feature-108508-FluidComponentsIntegration.rst:62It would be great, if you can add an example on how a component can look like in this place, so that consumers of this document can try it with everything documented in one place -
Helmut Hummel commented on patch set 23 01/15/26, 09:24
ComponentCollectionRegistry.php:64shouldn't this rather fail, than silently fall back to empty array, which will break later at rendering level then?DeclarativeComponentCollection.php:91I'd always reverse the condition (actually check instanceof) and return early, to make it a guard clauseDeclarativeComponentCollection.php:129maybe keep the variable name from the interface -
Simon Praetorius uploaded patch set 24
CR +1V +101/15/26, 10:41 -
Simon Praetorius commented on patch set 24 01/15/26, 10:42
Feature-108508-FluidComponentsIntegration.rst:62ReplyI've added a chapter about creating components and referred to the Fluid documentation.ComponentCollectionRegistry.php:64ReplyI've added an exception.DeclarativeComponentCollection.php:91ReplyDoneDeclarativeComponentCollection.php:129ReplyDone -
core-ci voted on patch set 24 V -1 01/15/26, 10:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93506
-
Matthias Vogel voted on patch set 24 CR +1 V +1 01/15/26, 10:49
-
Simon Praetorius uploaded patch set 25
CR +1V +101/15/26, 10:51 -
Matthias Vogel voted on patch set 25 CR +1 V +1 01/15/26, 10:53
-
core-ci voted on patch set 25 V +1 01/15/26, 10:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93507
-
Helmut Hummel commented on patch set 25 CR +1 V -1 01/16/26, 12:48
Very nice by reading (+1 code review), thanks. Will give it a test later tonite (therefore adding -1 verified until my tests are done) -
Garvin Hicking commented on patch set 25 01/16/26, 15:00
Feature-108508-FluidComponentsIntegration.rst:117```suggestion :caption: EXT:my_extension/Resources/Private/Components/Molecule/TeaserCard/TeaserCard.fluid.html ``` -
Simon Praetorius commented on patch set 25 01/16/26, 15:15
Feature-108508-FluidComponentsIntegration.rst:117ReplyLet's do minor docs changes as follow-ups. This patch is laying around for some time now, and I really don't want to move it to 14.2. -
Garvin Hicking commented on patch set 25 CR +1 V +1 01/16/26, 15:18
Great work! Works well even for someone who today created his first component 😄Feature-108508-PSR-14EventsForFluidComponents.rst:154```suggestion // Add bundled components CSS if a component is used on the page ``` -
Helmut Hummel commented on patch set 25 V +1 01/16/26, 22:31
Feature-108508-FluidComponentsIntegration.rst:117ReplyAcknowledged -
Simon Praetorius voted on patch set 25 CR +2 V +2 01/16/26, 22:33
-
Simon Praetorius merged patch set 26 01/16/26, 22:34
-
Garvin Hicking commented on patch set 26 01/17/26, 00:24
Followup for the mentioned changelog changes: https://review.typo3.org/c/Packages/TYPO3.CMS/+/92361Feature-108508-PSR-14EventsForFluidComponents.rst:154ReplyDone