Review main Merged

92123[FEATURE] Fluid components integration

Simon Praetorius CR +2 V +2 Expert +1394 −2 updated 01/17/26, 00:24

Commit message

This patch properly integrates Fluid's components feature, introduced
first with Fluid 4.3, into TYPO3. It introduces a new extension-level
configuration file, which can be used to register component collections.
These files are collected and merged during DI initialization and
then provided to Fluid.

`DeclarativeComponentCollection` implements the necessary interfaces
to make Fluid aware of the available component files. The PSR-14
`ModifyComponentDefinitionEvent` allows to programmatically adjust
the definition of component definitions before they are written to
a new component definitions cache. The
PSR-14 `ProvideStaticVariablesToComponentEvent` allows to provide
additional static variables to component templates. The
`EventBasedComponentRenderer` allows to alter or replace the
rendering of Fluid components with the new PSR-14
`RenderComponentEvent`.

Review

  • Code review CR +2 Done
    • Simon Praetorius +2
    • Garvin Hicking +1
    • Matthias Vogel +1
    • Helmut Hummel +1
  • Verified V +2 Done
    • Simon Praetorius +2
    • Garvin Hicking +1
    • Matthias Vogel +1
    • Helmut Hummel +1
    • core-ci +1 CI

Issues 1

Files 36

Show 16 more files

Review log 4671

Show 2646 earlier messages
  1. Simon Praetorius uploaded patch set 1 12/13/25, 19:38

  2. core-ci voted on patch set 1 V -1 12/13/25, 19:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92193

  3. Simon Praetorius uploaded patch set 2 V -1 12/14/25, 09:48

  4. core-ci voted on patch set 2 V -1 12/14/25, 09:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92210

  5. Simon Praetorius uploaded patch set 3 V -1 12/14/25, 13:05

  6. core-ci voted on patch set 3 V -1 12/14/25, 13:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92213

  7. Simon Praetorius uploaded patch set 4 V -1 12/14/25, 13:35

  8. core-ci voted on patch set 4 V -1 12/14/25, 13:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92214

  9. Simon Praetorius uploaded patch set 5 V -1 12/14/25, 14:11

  10. core-ci voted on patch set 5 V +1 12/14/25, 14:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92215

  11. Simon Praetorius uploaded patch set 6 V +1 12/14/25, 14:42

  12. core-ci voted on patch set 6 V +1 12/14/25, 14:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92217

  13. Simon Praetorius uploaded patch set 7 V +1 12/14/25, 19:45

  14. core-ci voted on patch set 7 V +1 12/14/25, 19:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92219

  15. Simon Praetorius uploaded patch set 8 V +1 12/15/25, 19:11

  16. core-ci voted on patch set 8 V -1 12/15/25, 19:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92249

  17. Simon Praetorius uploaded patch set 9 V -1 12/15/25, 19:26

  18. core-ci voted on patch set 9 V -1 12/15/25, 19:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92250

  19. Simon Praetorius uploaded patch set 10 V -1 12/15/25, 19:37

  20. core-ci voted on patch set 10 V -1 12/15/25, 19:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92251

  21. Simon Praetorius uploaded patch set 11 V -1 12/15/25, 19:52

  22. core-ci voted on patch set 11 V -1 12/15/25, 20:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92252

  23. Helmut Hummel commented on patch set 11 12/16/25, 12:48

    This change is ready for review.

    ViewHelperResolverFactory.php:53

    I would rather move all this factory code to DI creation, which would remove the dependency to FailsafeContainer here as well, and let this class only receive ready made componentCollections
  24. Helmut Hummel commented on patch set 11 12/16/25, 12:54

    ServiceProvider.php:81

    ViewHelperResolverFactory does not need any of those in failsafe mode, right?
  25. Simon Praetorius rebased onto patch set 12 V -1 12/17/25, 15:36

  26. core-ci voted on patch set 12 V +1 12/17/25, 15:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92355

  27. Simon Praetorius uploaded patch set 13 V +1 12/17/25, 17:38

  28. core-ci voted on patch set 13 V +1 12/17/25, 17:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92368

  29. Simon Praetorius uploaded patch set 14 V +1 12/18/25, 13:11

  30. core-ci voted on patch set 14 V -1 12/18/25, 13:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92415

  31. Simon Praetorius uploaded patch set 15 V -1 12/18/25, 13:27

  32. core-ci voted on patch set 15 V +1 12/18/25, 13:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92417

  33. Simon Praetorius uploaded patch set 16 V +1 01/09/26, 14:14

  34. Simon Praetorius uploaded patch set 17 01/09/26, 14:23

  35. core-ci voted on patch set 17 V -1 01/09/26, 14:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93149

  36. Simon Praetorius uploaded patch set 18 V -1 01/09/26, 14:56

  37. core-ci voted on patch set 18 V +1 01/09/26, 15:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93155

  38. core-ci voted on patch set 16 V -1 01/09/26, 15:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93147

  39. Simon Praetorius uploaded patch set 19 V +1 01/10/26, 12:19

  40. Simon Praetorius commented on patch set 19 01/10/26, 12:22

    ViewHelperResolverFactory.php:53 Reply

    I've introduced a new `ComponentCollectionRegistry`, which takes care of creating component collection objects based on the provided configuration. This registry is now an optional dependency of `ViewHelperResolverFactory`, which means that it won't be provided at all in installtool context and the FailsafeContainer check is no longer necessary.

    ServiceProvider.php:81 Reply

    Done
  41. core-ci voted on patch set 19 V -1 01/10/26, 12:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93203

  42. Simon Praetorius uploaded patch set 20 V -1 01/10/26, 12:30

  43. core-ci voted on patch set 20 V +1 01/10/26, 12:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93204

  44. Simon Schaufelberger voted on patch set 20 CR +1 01/10/26, 16:26

  45. Matthias Vogel voted on patch set 20 CR +1 01/13/26, 15:35

  46. Matthias Vogel commented on patch set 20 V -1 01/14/26, 09:40

    DeclarativeComponentCollection.php:90

    "Hots-Mox-Components--molleti.bottomHost" is not a valid cache entry identifier.
  1. Matthias Vogel uploaded patch set 21 CR +1 V +1 01/14/26, 09:57

  2. Matthias Vogel commented on patch set 21 CR +1 V +1 01/14/26, 09:57

    DeclarativeComponentCollection.php:90 Reply

    Done
  3. Matthias Vogel uploaded patch set 22 01/14/26, 09:58

    Copied Votes: * Code-Review+1 (copy condition: "**changekind:NO_CHANGE** OR is:MIN") * Verified+1 (copy condition: "**changekind:NO_CHANGE**")
  4. Matthias Vogel uploaded patch set 23 CR +1 V +1 01/14/26, 09:59

  5. Matthias Vogel voted on patch set 23 CR +1 V +1 01/14/26, 09:59

  6. core-ci voted on patch set 21 V -1 01/14/26, 10:07 Copied votes on follow-up patch sets have been updated: * Verified-1 has been copied to patch set 22 (copy condition: "changekind:NO_CHANGE"). Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93429

  7. core-ci voted on patch set 22 V -1 01/14/26, 10:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93430

  8. core-ci voted on patch set 23 V +1 01/14/26, 10:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93431

  9. Helmut Hummel commented on patch set 23 01/15/26, 08:23

    Feature-108508-FluidComponentsIntegration.rst:62

    It would be great, if you can add an example on how a component can look like in this place, so that consumers of this document can try it with everything documented in one place
  10. Helmut Hummel commented on patch set 23 01/15/26, 09:24

    ComponentCollectionRegistry.php:64

    shouldn't this rather fail, than silently fall back to empty array, which will break later at rendering level then?

    DeclarativeComponentCollection.php:91

    I'd always reverse the condition (actually check instanceof) and return early, to make it a guard clause

    DeclarativeComponentCollection.php:129

    maybe keep the variable name from the interface
  11. Simon Praetorius uploaded patch set 24 CR +1 V +1 01/15/26, 10:41

  12. Simon Praetorius commented on patch set 24 01/15/26, 10:42

    Feature-108508-FluidComponentsIntegration.rst:62 Reply

    I've added a chapter about creating components and referred to the Fluid documentation.

    ComponentCollectionRegistry.php:64 Reply

    I've added an exception.

    DeclarativeComponentCollection.php:91 Reply

    Done

    DeclarativeComponentCollection.php:129 Reply

    Done
  13. core-ci voted on patch set 24 V -1 01/15/26, 10:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93506

  14. Matthias Vogel voted on patch set 24 CR +1 V +1 01/15/26, 10:49

  15. Simon Praetorius uploaded patch set 25 CR +1 V +1 01/15/26, 10:51

  16. Matthias Vogel voted on patch set 25 CR +1 V +1 01/15/26, 10:53

  17. core-ci voted on patch set 25 V +1 01/15/26, 10:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93507

  18. Helmut Hummel commented on patch set 25 CR +1 V -1 01/16/26, 12:48

    Very nice by reading (+1 code review), thanks. Will give it a test later tonite (therefore adding -1 verified until my tests are done)
  19. Garvin Hicking commented on patch set 25 01/16/26, 15:00

    Feature-108508-FluidComponentsIntegration.rst:117

    ```suggestion :caption: EXT:my_extension/Resources/Private/Components/Molecule/TeaserCard/TeaserCard.fluid.html ```
  20. Simon Praetorius commented on patch set 25 01/16/26, 15:15

    Feature-108508-FluidComponentsIntegration.rst:117 Reply

    Let's do minor docs changes as follow-ups. This patch is laying around for some time now, and I really don't want to move it to 14.2.
  21. Garvin Hicking commented on patch set 25 CR +1 V +1 01/16/26, 15:18

    Great work! Works well even for someone who today created his first component 😄

    Feature-108508-PSR-14EventsForFluidComponents.rst:154

    ```suggestion // Add bundled components CSS if a component is used on the page ```
  22. Helmut Hummel commented on patch set 25 V +1 01/16/26, 22:31

    Feature-108508-FluidComponentsIntegration.rst:117 Reply

    Acknowledged
  23. Simon Praetorius voted on patch set 25 CR +2 V +2 01/16/26, 22:33

  24. Simon Praetorius merged patch set 26 01/16/26, 22:34

  25. Garvin Hicking commented on patch set 26 01/17/26, 00:24

    Followup for the mentioned changelog changes: https://review.typo3.org/c/Packages/TYPO3.CMS/+/92361

    Feature-108508-PSR-14EventsForFluidComponents.rst:154 Reply

    Done