92127[FEATURE] Improve page module preview
Commit message
Review
-
Code review CR +2 Done
- Anja Leichsenring +2
- Garvin Hicking +1
-
Verified V +2 Done
- Anja Leichsenring +2
- Garvin Hicking +1
Issues 1
Files 10
- typo3/sysext/backend/Classes/Preview/RecordFieldPreviewProcessor.php+12 −0
- typo3/sysext/backend/Classes/Preview/StandardContentPreviewRenderer.php+1 −1
- typo3/sysext/backend/Tests/Functional/Preview/RecordFieldPreviewProcessorTest.php+3 −1
- typo3/sysext/backend/Tests/Unit/Preview/RecordFieldPreviewProcessorTest.php+5 −1
- typo3/sysext/core/Classes/Html/Visitor/UnwrapTagVisitor.php2new+71 −0
- typo3/sysext/core/Classes/Html/PreviewSanitizerBuilder.phpnew+41 −0
- typo3/sysext/core/Configuration/DefaultConfiguration.php+1 −0
- typo3/sysext/core/Documentation/Changelog/14.2/Feature-108580-ImprovedPageModuleContentPreview.rstnew+52 −0
- typo3/sysext/core/Tests/Functional/Html/PreviewSanitizerBuilderTest.phpnew+279 −0
- typo3/sysext/core/Tests/Unit/Html/Visitor/UnwrapTagVisitorTest.php7new+186 −0
Review log 3957
Show 2232 earlier messages
-
Georg Ringer uploaded patch set 1 12/15/25, 21:49
-
core-ci voted on patch set 1 V -1 12/15/25, 21:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92255
-
Georg Ringer uploaded patch set 2
V -112/16/25, 20:16 -
core-ci voted on patch set 2 V -1 12/16/25, 20:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92313
-
Georg Ringer uploaded patch set 3
V -112/16/25, 20:35 -
core-ci voted on patch set 3 V -1 12/16/25, 20:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92314
-
Georg Ringer uploaded patch set 4
V -112/16/25, 20:44 -
core-ci voted on patch set 4 V +1 12/16/25, 20:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92315
-
Georg Ringer rebased onto patch set 5
V +112/29/25, 16:26 -
core-ci voted on patch set 5 V +1 12/29/25, 16:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92774
-
Georg Ringer uploaded patch set 6
V +112/29/25, 16:37 -
core-ci voted on patch set 6 V -1 12/29/25, 16:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92775
-
Georg Ringer uploaded patch set 7
V -112/29/25, 18:08 -
core-ci voted on patch set 7 V +1 12/29/25, 18:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92789
-
Georg Ringer commented on patch set 7 01/09/26, 07:51
This change is ready for review. -
Simon Schaufelberger commented on patch set 7 01/09/26, 09:06
UnwrapTagVisitor.php:24Remove a -
Simon Schaufelberger commented on patch set 7 01/09/26, 11:07
looks like a lot of AI has been used here ;)UnwrapTagVisitorTest.php:107divContent is not used. can this line be removed?UnwrapTagVisitorTest.php:145unusedUnwrapTagVisitorTest.php:171unused -
Simon Schaufelberger uploaded patch set 8
V +101/09/26, 11:09 -
core-ci voted on patch set 8 V +1 01/09/26, 11:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93143
-
Simon Schaufelberger commented on patch set 8 01/17/26, 19:58
UnwrapTagVisitor.php:24ReplyDone -
Guido Schmechel commented on patch set 8 01/18/26, 14:29
I understand the approach, but two things immediately struck me during testing: - A list of 50 US states in the backend greatly increases the length of the output. - I used a Soundcloud embed code as the HTML element. Yes, the code is sanitized and displayed. But I don't see the benefit, and the code is so long that a horizontal scrollbar is added in the backend. -
Guido Schmechel commented on patch set 8 01/18/26, 14:41
Reply
I would just like to add that the list is not new. Therefore, my hint is obsolete. -
Benni Mack uploaded patch set 9
V +101/23/26, 21:06 -
core-ci voted on patch set 9 V +1 01/23/26, 21:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94212
-
Guido Schmechel uploaded patch set 10
V +101/25/26, 10:37 -
core-ci voted on patch set 10 V +1 01/25/26, 10:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94301
-
Guido Schmechel voted on patch set 10 CR +1 V +1 01/26/26, 10:19
-
Georg Ringer voted on patch set 10 CR +1 V +1 01/26/26, 11:02
-
Simon Schaufelberger commented on patch set 10 CR -1 01/26/26, 11:13
Still some unresolved comments -
Georg Ringer uploaded patch set 11
CR +1V +101/29/26, 14:01 -
Georg Ringer commented on patch set 11 01/29/26, 14:01
UnwrapTagVisitorTest.php:145Replyit is used the next line -
Georg Ringer commented on patch set 11 01/29/26, 14:02
UnwrapTagVisitorTest.php:107ReplyDoneUnwrapTagVisitorTest.php:145ReplyDoneUnwrapTagVisitorTest.php:171ReplyDone
-
core-ci voted on patch set 11 V -1 01/29/26, 15:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94581
-
core-ci voted on patch set 11 V +1 01/29/26, 16:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94581
-
Simon Schaufelberger commented on patch set 11 CR +1 V +1 01/29/26, 22:27
Reply
Done -
Benni Mack uploaded patch set 12
CR +1V +102/01/26, 13:36 -
core-ci voted on patch set 12 V -1 02/01/26, 14:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94762
-
Simon Schaufelberger commented on patch set 12 02/13/26, 22:42
I have prepared a patch that will render flexform settings dynamically instead of the hardcoded way here: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82287 -
Benni Mack commented on patch set 12 02/18/26, 21:26
Reply
how about we take the felogin change out of this patch and finish it? Care to do this? -
Georg Ringer uploaded patch set 13
V -102/20/26, 17:11 -
Simon Schaufelberger commented on patch set 13 CR +1 V +1 02/20/26, 17:50
Reply
Done -
core-ci voted on patch set 13 V -1 02/20/26, 17:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96389
-
Simon Schaufelberger uploaded patch set 14
CR +1V +102/20/26, 22:50 -
core-ci voted on patch set 14 V -1 02/20/26, 23:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96417
-
Simon Schaufelberger uploaded patch set 15
V -103/03/26, 18:17 -
core-ci voted on patch set 15 V +1 03/03/26, 18:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97210
-
Simon Schaufelberger voted on patch set 15 CR +1 V +1 03/03/26, 19:43
-
Garvin Hicking uploaded patch set 16
CR +1V +103/03/26, 21:15 -
core-ci voted on patch set 16 V +1 03/03/26, 21:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97227
-
Simon Schaufelberger voted on patch set 16 CR +1 V +1 03/03/26, 21:26
-
Garvin Hicking voted on patch set 16 CR +1 V +1 03/03/26, 21:48
-
Anja Leichsenring updated the commit message in patch set 17
CR +1V +103/04/26, 08:40 -
Anja Leichsenring voted on patch set 17 CR +1 V +1 03/04/26, 08:41
-
Garvin Hicking voted on patch set 17 CR +1 V +1 03/04/26, 08:43
-
Anja Leichsenring voted on patch set 17 CR +2 V +2 03/04/26, 08:45
-
Anja Leichsenring merged patch set 18 03/04/26, 08:45
-
core-ci voted on patch set 17 V +1 03/04/26, 09:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97275