Review main Merged

92127[FEATURE] Improve page module preview

Georg Ringer CR +2 V +2 Hard +651 −3 updated 03/04/26, 09:00

Commit message

Improve the preview in the page module in various places

- Use a custom sanitizer for content of bodytext to render HTML as is
- Enhanced bullet list preview
- Harmonized menu element rendering

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Garvin Hicking +1

Issues 1

Files 10

Review log 3957

Show 2232 earlier messages
  1. Georg Ringer uploaded patch set 1 12/15/25, 21:49

  2. core-ci voted on patch set 1 V -1 12/15/25, 21:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92255

  3. Georg Ringer uploaded patch set 2 V -1 12/16/25, 20:16

  4. core-ci voted on patch set 2 V -1 12/16/25, 20:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92313

  5. Georg Ringer uploaded patch set 3 V -1 12/16/25, 20:35

  6. core-ci voted on patch set 3 V -1 12/16/25, 20:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92314

  7. Georg Ringer uploaded patch set 4 V -1 12/16/25, 20:44

  8. core-ci voted on patch set 4 V +1 12/16/25, 20:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92315

  9. Georg Ringer rebased onto patch set 5 V +1 12/29/25, 16:26

  10. core-ci voted on patch set 5 V +1 12/29/25, 16:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92774

  11. Georg Ringer uploaded patch set 6 V +1 12/29/25, 16:37

  12. core-ci voted on patch set 6 V -1 12/29/25, 16:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92775

  13. Georg Ringer uploaded patch set 7 V -1 12/29/25, 18:08

  14. core-ci voted on patch set 7 V +1 12/29/25, 18:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92789

  15. Georg Ringer commented on patch set 7 01/09/26, 07:51

    This change is ready for review.
  16. Simon Schaufelberger commented on patch set 7 01/09/26, 09:06

    UnwrapTagVisitor.php:24

    Remove a
  17. Simon Schaufelberger commented on patch set 7 01/09/26, 11:07

    looks like a lot of AI has been used here ;)

    UnwrapTagVisitorTest.php:107

    divContent is not used. can this line be removed?

    UnwrapTagVisitorTest.php:145

    unused

    UnwrapTagVisitorTest.php:171

    unused
  18. Simon Schaufelberger uploaded patch set 8 V +1 01/09/26, 11:09

  19. core-ci voted on patch set 8 V +1 01/09/26, 11:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93143

  20. Simon Schaufelberger commented on patch set 8 01/17/26, 19:58

    UnwrapTagVisitor.php:24 Reply

    Done
  21. Guido Schmechel commented on patch set 8 01/18/26, 14:29

    I understand the approach, but two things immediately struck me during testing: - A list of 50 US states in the backend greatly increases the length of the output. - I used a Soundcloud embed code as the HTML element. Yes, the code is sanitized and displayed. But I don't see the benefit, and the code is so long that a horizontal scrollbar is added in the backend.
  22. Guido Schmechel commented on patch set 8 01/18/26, 14:41

    Reply

    I would just like to add that the list is not new. Therefore, my hint is obsolete.
  23. Benni Mack uploaded patch set 9 V +1 01/23/26, 21:06

  24. core-ci voted on patch set 9 V +1 01/23/26, 21:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94212

  25. Guido Schmechel uploaded patch set 10 V +1 01/25/26, 10:37

  26. core-ci voted on patch set 10 V +1 01/25/26, 10:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94301

  27. Guido Schmechel voted on patch set 10 CR +1 V +1 01/26/26, 10:19

  28. Georg Ringer voted on patch set 10 CR +1 V +1 01/26/26, 11:02

  29. Simon Schaufelberger commented on patch set 10 CR -1 01/26/26, 11:13

    Still some unresolved comments
  30. Georg Ringer uploaded patch set 11 CR +1 V +1 01/29/26, 14:01

  31. Georg Ringer commented on patch set 11 01/29/26, 14:01

    UnwrapTagVisitorTest.php:145 Reply

    it is used the next line
  32. Georg Ringer commented on patch set 11 01/29/26, 14:02

    UnwrapTagVisitorTest.php:107 Reply

    Done

    UnwrapTagVisitorTest.php:145 Reply

    Done

    UnwrapTagVisitorTest.php:171 Reply

    Done
  1. core-ci voted on patch set 11 V -1 01/29/26, 15:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94581

  2. core-ci voted on patch set 11 V +1 01/29/26, 16:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94581

  3. Simon Schaufelberger commented on patch set 11 CR +1 V +1 01/29/26, 22:27

    Reply

    Done
  4. Benni Mack uploaded patch set 12 CR +1 V +1 02/01/26, 13:36

  5. core-ci voted on patch set 12 V -1 02/01/26, 14:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94762

  6. Simon Schaufelberger commented on patch set 12 02/13/26, 22:42

    I have prepared a patch that will render flexform settings dynamically instead of the hardcoded way here: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82287
  7. Benni Mack commented on patch set 12 02/18/26, 21:26

    Reply

    how about we take the felogin change out of this patch and finish it? Care to do this?
  8. Georg Ringer uploaded patch set 13 V -1 02/20/26, 17:11

  9. Simon Schaufelberger commented on patch set 13 CR +1 V +1 02/20/26, 17:50

    Reply

    Done
  10. core-ci voted on patch set 13 V -1 02/20/26, 17:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96389

  11. Simon Schaufelberger uploaded patch set 14 CR +1 V +1 02/20/26, 22:50

  12. core-ci voted on patch set 14 V -1 02/20/26, 23:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96417

  13. Simon Schaufelberger uploaded patch set 15 V -1 03/03/26, 18:17

  14. core-ci voted on patch set 15 V +1 03/03/26, 18:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97210

  15. Simon Schaufelberger voted on patch set 15 CR +1 V +1 03/03/26, 19:43

  16. Garvin Hicking uploaded patch set 16 CR +1 V +1 03/03/26, 21:15

  17. core-ci voted on patch set 16 V +1 03/03/26, 21:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97227

  18. Simon Schaufelberger voted on patch set 16 CR +1 V +1 03/03/26, 21:26

  19. Garvin Hicking voted on patch set 16 CR +1 V +1 03/03/26, 21:48

  20. Anja Leichsenring updated the commit message in patch set 17 CR +1 V +1 03/04/26, 08:40

  21. Anja Leichsenring voted on patch set 17 CR +1 V +1 03/04/26, 08:41

  22. Garvin Hicking voted on patch set 17 CR +1 V +1 03/04/26, 08:43

  23. Anja Leichsenring voted on patch set 17 CR +2 V +2 03/04/26, 08:45

  24. Anja Leichsenring merged patch set 18 03/04/26, 08:45

  25. core-ci voted on patch set 17 V +1 03/04/26, 09:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97275