92132[TASK] Standardize and improve labels on EXT:core
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Simon Schaufelberger +1
-
Verified V +2 Done
- Benni Mack +2
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 2
Review log 3144
Show 1319 earlier messages
-
Riccardo De Contardi uploaded patch set 1 12/16/25, 09:57
-
core-ci voted on patch set 1 V +1 12/16/25, 10:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92278
-
Riccardo De Contardi updated the commit message in patch set 2
V +112/16/25, 10:13 -
Riccardo De Contardi commented on patch set 3 12/16/25, 10:14
Published edit on patch set 2. -
core-ci voted on patch set 2 V -1 12/16/25, 10:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92284
-
core-ci voted on patch set 3 V +1 12/16/25, 10:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92285
-
Oliver Klee voted on patch set 3 CR +1 V +1 12/16/25, 11:15
-
Garvin Hicking updated the commit message in patch set 4
CR +1V +112/16/25, 11:17 -
Oliver Klee voted on patch set 4 CR +1 V +1 12/16/25, 11:18
-
Garvin Hicking commented on patch set 4 12/16/25, 11:21
locallang_core.xlf:106I would prefer one of: - Continuing without saving will discard your changes. - If you continue without saving, your changes will be lost. - Continuing without saving will cause your changes to be lost.locallang_core.xlf:1157Use "CAUTION: This" to be in line with other sentence uppercasing after a ":".locallang_core.xlf:1160see above -
core-ci voted on patch set 4 V +1 12/16/25, 11:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92288
-
Riccardo De Contardi commented on patch set 5
CR +1V +112/16/25, 11:29Published edit on patch set 4. -
Riccardo De Contardi commented on patch set 5 12/16/25, 11:29
donelocallang_core.xlf:1157ReplyDonelocallang_core.xlf:1160ReplyDone -
Riccardo De Contardi commented on patch set 6 12/16/25, 11:31
Published edit on patch set 5. -
Riccardo De Contardi commented on patch set 6 12/16/25, 11:31
Donelocallang_core.xlf:106ReplyDone -
Oliver Klee voted on patch set 6 CR +1 V +1 12/16/25, 11:34
-
core-ci voted on patch set 5 V +1 12/16/25, 11:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92289
-
core-ci voted on patch set 6 V -1 12/16/25, 11:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92291
-
Rachel Foucard commented on patch set 6 12/16/25, 12:17
locallang_core.xlf:478I would uppercase this one to be consistent with the others.
-
Lina Wolf commented on patch set 6 12/16/25, 12:37
locallang_core.xlf:478ReplyI would not use uppercase for emphasis at all..? -
Rachel Foucard commented on patch set 6 12/16/25, 12:43
locallang_core.xlf:478Replyno strong opinion on that, as soon as it is consistent. Ideed, probably the no uppercase form will be easier to maintain everywhere. -
Oliver Klee wrote 12/16/25, 12:45
Removed reviewer Oliver Klee with the following votes: * Verified+1 by Oliver Klee * Code-Review+1 by Oliver Klee -
Riccardo De Contardi commented on patch set 7
V -112/16/25, 14:50Published edit on patch set 6. -
Riccardo De Contardi updated the commit message in patch set 8 12/16/25, 14:51
-
Riccardo De Contardi updated the commit message in patch set 9 12/16/25, 14:51
-
Riccardo De Contardi commented on patch set 6 12/16/25, 14:59
Lina pointed out that in the documentation the usage of ALL CAPITALS is discouraged, therefore I adhere to this conventionlocallang_core.xlf:478ReplyDone -
core-ci voted on patch set 7 V -1 12/16/25, 15:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92303
-
core-ci voted on patch set 8 V -1 12/16/25, 15:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92304
-
core-ci voted on patch set 9 V -1 12/16/25, 15:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92305
-
Riccardo De Contardi uploaded patch set 10
V -112/16/25, 15:17 -
Rachel Foucard voted on patch set 10 V +1 12/16/25, 15:23
-
core-ci voted on patch set 10 V +1 12/16/25, 15:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92306
-
Riccardo De Contardi commented on patch set 11
V +112/17/25, 08:56Published edit on patch set 10. -
core-ci voted on patch set 11 V +1 12/17/25, 09:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92336
-
Riccardo De Contardi commented on patch set 12
V +101/08/26, 08:29Published edit on patch set 11. -
core-ci voted on patch set 12 V +1 01/08/26, 08:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93097
-
Benni Mack commented on patch set 12 CR +1 V +1 01/09/26, 10:58
locallang_core.xlf:691not used, but OK for now (= out of scope of this patch) -
Simon Schaufelberger commented on patch set 12 01/09/26, 11:11
The title is only half the through and should be more specific what is happening. -
Riccardo De Contardi updated the commit message in patch set 13
CR +1V +101/09/26, 15:15 -
Riccardo De Contardi commented on patch set 13 01/09/26, 15:15
Reply
Changed commit message. Better? -
core-ci voted on patch set 13 V +1 01/09/26, 15:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93157
-
Simon Schaufelberger commented on patch set 13 CR +1 V +1 01/09/26, 21:29
Reply
Acknowledged -
Benni Mack voted on patch set 13 CR +2 V +2 01/10/26, 10:12
-
Benni Mack merged patch set 14 01/10/26, 10:12