Review main Merged

92132[TASK] Standardize and improve labels on EXT:core

Riccardo De Contardi CR +2 V +2 Normal +38 −39 updated 01/10/26, 10:12

Commit message

Changes some labels on EXT:core by applying standards:
- Removes exclamation marks from several messages on EXT:core
- Removes usage of ALL CAPITAL words to be consistent with the
  documentation
- Makes messages more clear
- Avoids filling words like "Do you want..."

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 3144

Show 1319 earlier messages
  1. Riccardo De Contardi uploaded patch set 1 12/16/25, 09:57

  2. core-ci voted on patch set 1 V +1 12/16/25, 10:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92278

  3. Riccardo De Contardi updated the commit message in patch set 2 V +1 12/16/25, 10:13

  4. Riccardo De Contardi commented on patch set 3 12/16/25, 10:14

    Published edit on patch set 2.
  5. core-ci voted on patch set 2 V -1 12/16/25, 10:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92284

  6. core-ci voted on patch set 3 V +1 12/16/25, 10:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92285

  7. Oliver Klee voted on patch set 3 CR +1 V +1 12/16/25, 11:15

  8. Garvin Hicking updated the commit message in patch set 4 CR +1 V +1 12/16/25, 11:17

  9. Oliver Klee voted on patch set 4 CR +1 V +1 12/16/25, 11:18

  10. Garvin Hicking commented on patch set 4 12/16/25, 11:21

    locallang_core.xlf:106

    I would prefer one of: - Continuing without saving will discard your changes. - If you continue without saving, your changes will be lost. - Continuing without saving will cause your changes to be lost.

    locallang_core.xlf:1157

    Use "CAUTION: This" to be in line with other sentence uppercasing after a ":".

    locallang_core.xlf:1160

    see above
  11. core-ci voted on patch set 4 V +1 12/16/25, 11:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92288

  12. Riccardo De Contardi commented on patch set 5 CR +1 V +1 12/16/25, 11:29

    Published edit on patch set 4.
  13. Riccardo De Contardi commented on patch set 5 12/16/25, 11:29

    done

    locallang_core.xlf:1157 Reply

    Done

    locallang_core.xlf:1160 Reply

    Done
  14. Riccardo De Contardi commented on patch set 6 12/16/25, 11:31

    Published edit on patch set 5.
  15. Riccardo De Contardi commented on patch set 6 12/16/25, 11:31

    Done

    locallang_core.xlf:106 Reply

    Done
  16. Oliver Klee voted on patch set 6 CR +1 V +1 12/16/25, 11:34

  17. core-ci voted on patch set 5 V +1 12/16/25, 11:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92289

  18. core-ci voted on patch set 6 V -1 12/16/25, 11:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92291

  19. Rachel Foucard commented on patch set 6 12/16/25, 12:17

    locallang_core.xlf:478

    I would uppercase this one to be consistent with the others.
  1. Lina Wolf commented on patch set 6 12/16/25, 12:37

    locallang_core.xlf:478 Reply

    I would not use uppercase for emphasis at all..?
  2. Rachel Foucard commented on patch set 6 12/16/25, 12:43

    locallang_core.xlf:478 Reply

    no strong opinion on that, as soon as it is consistent. Ideed, probably the no uppercase form will be easier to maintain everywhere.
  3. Oliver Klee wrote 12/16/25, 12:45

    Removed reviewer Oliver Klee with the following votes: * Verified+1 by Oliver Klee * Code-Review+1 by Oliver Klee
  4. Riccardo De Contardi commented on patch set 7 V -1 12/16/25, 14:50

    Published edit on patch set 6.
  5. Riccardo De Contardi updated the commit message in patch set 8 12/16/25, 14:51

  6. Riccardo De Contardi updated the commit message in patch set 9 12/16/25, 14:51

  7. Riccardo De Contardi commented on patch set 6 12/16/25, 14:59

    Lina pointed out that in the documentation the usage of ALL CAPITALS is discouraged, therefore I adhere to this convention

    locallang_core.xlf:478 Reply

    Done
  8. core-ci voted on patch set 7 V -1 12/16/25, 15:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92303

  9. core-ci voted on patch set 8 V -1 12/16/25, 15:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92304

  10. core-ci voted on patch set 9 V -1 12/16/25, 15:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92305

  11. Riccardo De Contardi uploaded patch set 10 V -1 12/16/25, 15:17

  12. Rachel Foucard voted on patch set 10 V +1 12/16/25, 15:23

  13. core-ci voted on patch set 10 V +1 12/16/25, 15:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92306

  14. Riccardo De Contardi commented on patch set 11 V +1 12/17/25, 08:56

    Published edit on patch set 10.
  15. core-ci voted on patch set 11 V +1 12/17/25, 09:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92336

  16. Riccardo De Contardi commented on patch set 12 V +1 01/08/26, 08:29

    Published edit on patch set 11.
  17. core-ci voted on patch set 12 V +1 01/08/26, 08:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93097

  18. Benni Mack commented on patch set 12 CR +1 V +1 01/09/26, 10:58

    locallang_core.xlf:691

    not used, but OK for now (= out of scope of this patch)
  19. Simon Schaufelberger commented on patch set 12 01/09/26, 11:11

    The title is only half the through and should be more specific what is happening.
  20. Riccardo De Contardi updated the commit message in patch set 13 CR +1 V +1 01/09/26, 15:15

  21. Riccardo De Contardi commented on patch set 13 01/09/26, 15:15

    Reply

    Changed commit message. Better?
  22. core-ci voted on patch set 13 V +1 01/09/26, 15:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93157

  23. Simon Schaufelberger commented on patch set 13 CR +1 V +1 01/09/26, 21:29

    Reply

    Acknowledged
  24. Benni Mack voted on patch set 13 CR +2 V +2 01/10/26, 10:12

  25. Benni Mack merged patch set 14 01/10/26, 10:12