Review main Merged

92135[BUGFIX] Avoid scrolling after theme switching in styleguide components

Georg Ringer CR +2 V +2 Easy +3 −3 updated 12/18/25, 09:58

Commit message

Stop the default behavior to avoid scrolling to the top after switching
the theme in EXT:styleguide.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Georg Ringer +1
    • Oli Bartsch +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Georg Ringer +1
    • Oli Bartsch +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1620

  1. Georg Ringer uploaded patch set 1 12/16/25, 21:00

  2. Georg Ringer commented on patch set 1 12/16/25, 21:00

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 12/16/25, 21:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92316

  4. Simon Schaufelberger voted on patch set 1 CR +1 V +1 12/16/25, 22:23

  5. Garvin Hicking updated the commit message in patch set 2 CR +1 V +1 12/17/25, 19:51

  6. Garvin Hicking voted on patch set 2 CR +1 V +1 12/17/25, 19:51

  7. core-ci voted on patch set 2 V +1 12/17/25, 19:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92371

  8. Simon Schaufelberger voted on patch set 2 CR +1 V +1 12/17/25, 23:06

  9. Oli Bartsch commented on patch set 2 CR -1 12/18/25, 07:52

    IMO we should switch to properly use `<button>` because the action is not a link.
  10. Oli Bartsch commented on patch set 2 CR +1 V +1 12/18/25, 07:53

    Reply

    Done
  11. Oli Bartsch uploaded patch set 3 CR +1 V +1 12/18/25, 07:54

  12. Oli Bartsch uploaded patch set 4 12/18/25, 07:55

  13. Oli Bartsch voted on patch set 4 CR +1 V +1 12/18/25, 07:55

  14. core-ci voted on patch set 3 V +1 12/18/25, 08:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92396

  15. core-ci voted on patch set 4 V +1 12/18/25, 08:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92397

  16. Georg Ringer voted on patch set 4 CR +1 V +1 12/18/25, 08:14

  17. Simon Schaufelberger voted on patch set 4 CR +1 V +1 12/18/25, 08:26

  18. Garvin Hicking voted on patch set 4 CR +1 V +1 12/18/25, 09:58

  19. Garvin Hicking voted on patch set 4 CR +2 V +2 12/18/25, 09:58

  20. Garvin Hicking merged patch set 5 12/18/25, 09:58