92136[TASK] Add backend sidebar component registry
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Benjamin Franzke +1
- Georg Ringer +1
-
Verified V +2 Done
- Oli Bartsch +2
- Benjamin Franzke +1
- Georg Ringer +1
- core-ci +1 CI
Issues 1
Files 27
- Build/Sources/Sass/component/scaffold/_modulemenu.scss+0 −3
- Build/Sources/Sass/component/scaffold/_scaffold.scss+22 −17
- Build/Sources/Sass/component/scaffold/_sidebar.scssnew+26 −0
- Build/Sources/Sass/_minimal.scss+1 −0
- typo3/sysext/backend/Classes/Attribute/AsSidebarComponent.php2new+40 −0
- typo3/sysext/backend/Classes/Controller/BackendController.php2+16 −51
- typo3/sysext/backend/Classes/DependencyInjection/SidebarComponentsPass.phpnew+86 −0
- typo3/sysext/backend/Classes/Sidebar/ModuleMenuSidebarComponent.php4new+93 −0
- typo3/sysext/backend/Classes/Sidebar/Sidebar.php5new+78 −0
- typo3/sysext/backend/Classes/Sidebar/SidebarComponentContext.php4new+34 −0
- typo3/sysext/backend/Classes/Sidebar/SidebarComponentInterface.php7new+39 −0
- typo3/sysext/backend/Classes/Sidebar/SidebarComponentResult.php4new+44 −0
- typo3/sysext/backend/Classes/Sidebar/SidebarComponentsRegistry.php2new+75 −0
- typo3/sysext/backend/Classes/Sidebar/SidebarFactory.phpnew+41 −0
- typo3/sysext/backend/Configuration/Services.php+16 −0
- typo3/sysext/backend/Resources/Private/Partials/Backend/Topbar.fluid.html+1 −1
- typo3/sysext/backend/Resources/Private/Templates/Backend/Main.fluid.html+7 −7
- typo3/sysext/backend/Resources/Public/Css/backend.css+8 −5
- typo3/sysext/backend/Tests/Functional/Sidebar/Fixtures/TestComponentA.phpnew+37 −0
- typo3/sysext/backend/Tests/Functional/Sidebar/Fixtures/TestComponentBBefore.phpnew+40 −0
Show 7 more files
- typo3/sysext/backend/Tests/Functional/Sidebar/Fixtures/TestComponentCAfter.phpnew+40 −0
- typo3/sysext/backend/Tests/Functional/Sidebar/Fixtures/TestComponentDuplicate.phpnew+40 −0
- typo3/sysext/backend/Tests/Functional/Sidebar/Fixtures/TestComponentNoAccess.phpnew+37 −0
- typo3/sysext/backend/Tests/Functional/Sidebar/SidebarComponentsRegistryTest.phpnew+213 −0
- typo3/sysext/backend/Tests/Functional/Sidebar/SidebarRenderingTest.phpnew+138 −0
- typo3/sysext/backend/Tests/Unit/DependencyInjection/SidebarComponentsPassTest.phpnew+169 −0
- typo3/sysext/install/Resources/Private/Templates/Layout/MainLayout.fluid.html+98 −94
Review log 4058
Show 2333 earlier messages
-
Oli Bartsch uploaded patch set 1 12/16/25, 22:37
-
core-ci voted on patch set 1 V -1 12/16/25, 22:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92317
-
Benni Mack commented on patch set 1 12/17/25, 06:55
SidebarComponentsRegistry.php:30I think we can remove the singleton hereSidebarComponent.fluid.html:6let's discuss if we should wrap this in a div, or if the component itself should handle this? Same goes with format.raw -
Oli Bartsch uploaded patch set 2
V -112/17/25, 11:27 -
Oli Bartsch commented on patch set 2 12/17/25, 11:28
SidebarComponentInterface.php:38ReplySince this is a backend only component, BackendUserAuthentication seems sufficient.SidebarComponentsRegistry.php:30ReplyDoneSidebarComponent.fluid.html:6ReplyI don't understand. This is already a div? -
core-ci voted on patch set 2 V +1 12/17/25, 11:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92345
-
Benjamin Kott commented on patch set 2 CR -1 12/18/25, 10:59
on it -
Benjamin Kott uploaded patch set 3
CR -1V +112/18/25, 13:46 -
Benjamin Kott commented on patch set 3 12/18/25, 13:47
SidebarComponent.fluid.html:6Replyremoved the templates -
Benjamin Kott commented on patch set 3 12/18/25, 14:04
SidebarComponent.fluid.html:6ReplyDone -
core-ci voted on patch set 3 V -1 12/18/25, 14:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92419
-
Benni Mack commented on patch set 3 CR -1 12/19/25, 08:10
on it -
Benni Mack uploaded patch set 4
CR -1V -112/19/25, 12:08 -
core-ci voted on patch set 4 V -1 12/19/25, 12:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92475
-
Oli Bartsch rebased onto patch set 5
V -101/19/26, 17:03 -
Oli Bartsch commented on patch set 5 01/19/26, 17:03
SidebarComponentInterface.php:38ReplyDone -
core-ci voted on patch set 5 V -1 01/19/26, 17:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93793
-
Oli Bartsch uploaded patch set 6
V -101/27/26, 21:06 -
core-ci voted on patch set 6 V +1 01/27/26, 21:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94450
-
Oli Bartsch uploaded patch set 7
V +101/28/26, 07:19 -
core-ci voted on patch set 7 V -1 01/28/26, 07:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94477
-
Oli Bartsch uploaded patch set 8
V -101/28/26, 07:43 -
core-ci voted on patch set 8 V +1 01/28/26, 07:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94479
-
Oli Bartsch uploaded patch set 9
V +101/28/26, 08:43 -
core-ci voted on patch set 9 V +1 01/28/26, 08:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94483
-
Oli Bartsch uploaded patch set 10
V +101/28/26, 09:01 -
core-ci voted on patch set 10 V +1 01/28/26, 09:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94484
-
Benjamin Franzke commented on patch set 10 01/28/26, 10:00
ModuleMenuSidebarComponent.php:75Since the components are intended to be refreshable, we should not allow `JavaScriptModuleInstruction`s here, since that allows to call initializer functions which then work for initial rendering, but may not update when the component is refreshed. For that reason I'd suggest a simple `getJavaScriptModule(): string` here, as in setting types.Sidebar.php:99Let's return an array of modules (`list<string>`) here to avoid side effects in this components. The modules should be added to javaScriptRenderer/pageRenderer by the controller.SidebarComponentInterface.php:42I don't like that sidebar's receive a request, as its a generic container and does not clarify what is actually needed. I understand that we currently need that because BackendViewFactory requires that :\ To be able to extend the sidebar context i propose to wrap this in final `SidebarComponentContext` object that is passed to `render()` (see dashboard renderers for an example). -
Oli Bartsch commented on patch set 10 01/28/26, 10:08
BackendController.php:213This should return SidebarComponentResult directly. -
Benjamin Franzke commented on patch set 10 01/28/26, 10:10
SidebarComponentInterface.php:42Let's return `SidebarComponentResult` -
Oli Bartsch commented on patch set 10 01/28/26, 10:10
AsSidebarComponent.php:22Add @internal -
Oli Bartsch uploaded patch set 11
V +101/28/26, 11:21 -
Oli Bartsch uploaded patch set 12 01/28/26, 11:24
-
Oli Bartsch commented on patch set 12 01/28/26, 11:30
AsSidebarComponent.php:22ReplyDoneBackendController.php:213ReplyDoneModuleMenuSidebarComponent.php:75ReplyDoneSidebar.php:99ReplyDoneSidebarComponentInterface.php:42ReplyDoneSidebarComponentInterface.php:42ReplyDone -
core-ci voted on patch set 11 V +1 01/28/26, 11:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94493
-
core-ci voted on patch set 12 V +1 01/28/26, 11:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94494
-
Oli Bartsch uploaded patch set 13
V +101/28/26, 11:49 -
core-ci voted on patch set 13 V +1 01/28/26, 11:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94497
-
Benjamin Kott commented on patch set 13 CR -1 01/29/26, 11:47
@ben@bnf.dev is on it and does bnf things -
Benjamin Franzke uploaded patch set 14
CR -1V +101/29/26, 12:28 -
core-ci voted on patch set 14 V -1 01/29/26, 12:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94567
-
Oli Bartsch commented on patch set 14 01/29/26, 12:54
Sidebar.php:55What is the benefit of this type cast?SidebarComponentContext.php:34I see no reason why we should pass this service here. Components, which need this service should fetch / instantiate it themselfs. It is even unused in this patch.SidebarComponentResult.php:31I would like to keep this. I need to know which components result I currently deal with. -
Benjamin Franzke commented on patch set 14 01/29/26, 13:17
Sidebar.php:55ReplyIt is an object instead of an array, no other benefits.SidebarComponentContext.php:34ReplyIt's not a service, it is state, based on the user, that is context. (I've added usage in the workspace selector patch)SidebarComponentResult.php:31Replywhy? it was actually unused -
Benjamin Franzke uploaded patch set 15
V -101/29/26, 13:20 -
core-ci voted on patch set 15 V +1 01/29/26, 13:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94571
-
Oli Bartsch commented on patch set 15 01/29/26, 13:30
ModuleMenuSidebarComponent.php:53```suggestion return new SidebarComponentResult('', ''); ```SidebarComponentContext.php:34ReplyIt's called *Service. ;) But seriously, when needed it can be retrieved from then already provided user. ``` languageServiceFactory->createFromUserPreferences($context-user); ``` I did not find a lot (actually just one) place where core does currently forwarded this in constructor.SidebarComponentResult.php:31ReplyLet me rephrase: I would prefer to know which component this is, though it is not implemented yet. -
Oli Bartsch rebased onto patch set 16
V +101/29/26, 21:08 -
core-ci voted on patch set 16 V +1 01/29/26, 21:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94603
-
Benjamin Franzke uploaded patch set 17
V +101/30/26, 10:15 -
Benjamin Franzke commented on patch set 17 01/30/26, 10:15
ModuleMenuSidebarComponent.php:53ReplyDoneSidebar.php:55ReplyI don't want to discuss here, so I've changed to array.SidebarComponentContext.php:34Replyack, that's something i want for the future – this was a first acceptance test. anyway, postponed.SidebarComponentResult.php:31Replywell, I disagree, but benji wants the same, so I'll change it for you. ;) -
Benjamin Franzke voted on patch set 17 CR +1 V +1 01/30/26, 10:16
-
Benjamin Franzke uploaded patch set 18
CR +1V +101/30/26, 10:17 -
Benjamin Franzke voted on patch set 18 CR +1 V +1 01/30/26, 10:17
-
Georg Ringer voted on patch set 18 CR +1 V +1 01/30/26, 10:26
-
core-ci voted on patch set 17 V -1 01/30/26, 10:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94636
-
core-ci voted on patch set 18 V +1 01/30/26, 11:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94638
-
Oli Bartsch voted on patch set 18 CR +2 V +2 01/30/26, 12:03
-
Oli Bartsch merged patch set 19 01/30/26, 12:03
SidebarComponentInterface.php:38