Review main Merged

92140[TASK] Add modal positions, header visibility and static options

Benjamin Kott CR +2 V +2 Hard +332 −18 updated 12/17/25, 22:57

Commit message

The modal component is extended with a position option that allows
placing modals at the top, end, bottom or start of the viewport.
Each position slides in from its respective edge with appropriate
animations and removes borders and radius on the touching edge.

A new hideHeader option allows rendering modals without a visible
header while maintaining accessibility through aria-label.

All new options are supported via data attributes for markup
triggers: data-position, data-hide-header and data-static-backdrop.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 67

  1. Benjamin Kott uploaded patch set 1 12/17/25, 11:20

  2. core-ci voted on patch set 1 V +1 12/17/25, 11:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92344

  3. Oli Bartsch voted on patch set 1 CR +1 12/17/25, 22:03

  4. Oli Bartsch voted on patch set 1 V +1 12/17/25, 22:08

  5. Simon Schaufelberger voted on patch set 1 CR +1 V +1 12/17/25, 22:23

  6. Benni Mack voted on patch set 1 CR +2 V +2 12/17/25, 22:57

  7. Benni Mack merged patch set 2 12/17/25, 22:57