Review main Merged

92141[BUGFIX] Hide pagination during data fetching in live-search

Benjamin Kott CR +2 V +2 Easy +7 −3 updated 01/05/26, 17:19

Commit message

Previously, the pagination remained visible while new search results
were being fetched, creating a confusing UI state where the spinner
was shown alongside stale pagination controls.

A loading property is now added to the pagination component, which
hides it during data fetching and resets when results arrive.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Oli Bartsch +1
    • Jochen Roth +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Oli Bartsch +1
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 910

  1. Benjamin Kott uploaded patch set 1 12/17/25, 11:51

  2. core-ci voted on patch set 1 V +1 12/17/25, 11:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92348

  3. Oli Bartsch voted on patch set 1 CR +1 V +1 12/17/25, 21:54

  4. Simon Schaufelberger commented on patch set 1 12/17/25, 22:29

    live-search.ts:241

    i guess here should the loading be set to false again
  5. Benjamin Kott commented on patch set 1 12/18/25, 08:45

    live-search.ts:241 Reply

    i am not that deep in the codebase here, and would not change it as it was like this before - but could be handled in a separate patchset.
  6. Andreas Kienast voted on patch set 1 CR +1 12/18/25, 08:49

  7. Oli Bartsch commented on patch set 1 12/18/25, 10:02

    live-search.ts:241 Reply

  8. Jochen Roth voted on patch set 1 CR +1 V +1 01/05/26, 16:58

  9. Benjamin Kott voted on patch set 1 CR +2 V +2 01/05/26, 16:59

  10. Benjamin Kott merged patch set 2 01/05/26, 17:19