Review 13.4 Merged

92146[TASK] Mask database credentials in stacktrace

Simon Praetorius CR +2 V +2 Easy +9 −9 updated 12/30/25, 09:47

Commit message

If `displayErrors` is enabled, TYPO3 shows full stacktraces for
exceptions. This is also the case if the database connection didn't
work (wrong password, server not available, ...). This stacktrace
might then contain the database credentials as plain text.

This patch marks the relevant parameters in `ConnectionPool` and
`Connection` as sensitive parameter, which prevents that output.

Review

  • Code review CR +2 Done
    • Simon Praetorius +2
    • Sven Liebert +1
  • Verified V +2 Done
    • Simon Praetorius +2
    • Sven Liebert +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 67

  1. Simon Praetorius commented on patch set 1 12/17/25, 15:43

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 12/17/25, 15:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92356

  3. Josef Glatz wrote 12/17/25, 16:26

    Removed cc Josef Glatz.
  4. Riccardo De Contardi wrote 12/17/25, 16:30

    Removed reviewer Riccardo De Contardi.
  5. Sven Liebert voted on patch set 1 CR +1 V +1 12/29/25, 22:35

  6. Simon Praetorius voted on patch set 1 CR +2 V +2 12/30/25, 09:47

  7. Simon Praetorius merged patch set 2 12/30/25, 09:47