Review 12.4 Merged

92147[TASK] Mask database credentials in stacktrace

Simon Praetorius CR +2 V +2 Easy +4 −4 updated 12/30/25, 09:47

Commit message

If `displayErrors` is enabled, TYPO3 shows full stacktraces for
exceptions. This is also the case if the database connection didn't
work (wrong password, server not available, ...). This stacktrace
might then contain the database credentials as plain text.

This patch marks the relevant parameters in `ConnectionPool` and
`Connection` as sensitive parameter, which prevents that output.

Review

  • Code review CR +2 Done
    • Simon Praetorius +2
  • Verified V +2 Done
    • Simon Praetorius +2
    • core-ci +1 CI

Issues 2

Files 2

Review log 57

  1. Simon Praetorius commented on patch set 1 12/17/25, 15:44

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/core/Classes/Database/Connection.php * typo3/sysext/core/Classes/Database/ConnectionPool.php
  2. core-ci voted on patch set 1 V -1 12/17/25, 15:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92357

  3. Simon Praetorius uploaded patch set 2 V -1 12/30/25, 09:39

  4. Simon Praetorius marked it ready for review 12/30/25, 09:41

  5. core-ci voted on patch set 2 V +1 12/30/25, 09:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92808

  6. Simon Praetorius voted on patch set 2 CR +2 V +2 12/30/25, 09:47

  7. Simon Praetorius merged patch set 3 12/30/25, 09:47