Review main Merged

92148[TASK] Reflect `non-empty-string` return type in `HashScope::prefix()`

Elias Häußler CR +2 V +2 Easy +6 −0 updated 12/18/25, 13:48

Commit message

The `HashScope::prefix()` methods from EXT:form and EXT:extbase always
return a non-empty string. Since the return values of these methods are
commonly used for HMAC validation secrets, which are required to be
non-empty, appropriate PHPDoc return types are added to said methods.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 69

  1. Elias Häußler uploaded patch set 1 12/17/25, 17:01

  2. Elias Häußler updated the commit message in patch set 2 12/17/25, 17:02

  3. core-ci voted on patch set 1 V -1 12/17/25, 17:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92365

  4. core-ci voted on patch set 2 V +1 12/17/25, 17:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92366

  5. Oliver Klee updated the commit message in patch set 3 V +1 12/18/25, 10:53

  6. Oliver Klee voted on patch set 3 CR +1 V +1 12/18/25, 10:53

  7. core-ci voted on patch set 3 V +1 12/18/25, 11:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92410

  8. Christian Kuhn voted on patch set 3 CR +2 V +2 12/18/25, 13:33

  9. Christian Kuhn merged patch set 4 12/18/25, 13:48