92168[FEATURE] Establish config file for Fluid namespaces
Commit message
Review
-
Code review CR +2 Done
- Simon Praetorius +2
- Georg Ringer +1
- Lina Wolf +1
- Matthias Vogel +1
-
Verified V +2 Done
- Simon Praetorius +2
- Georg Ringer +1
- Lina Wolf +1
- core-ci +1 CI
Issues 1
Files 23
- typo3/sysext/core/Classes/Package/AbstractServiceProvider.php+13 −0
- typo3/sysext/core/Classes/ServiceProvider.php+6 −0
- typo3/sysext/core/Configuration/Fluid/Namespaces.phpnew+7 −0
- typo3/sysext/core/Configuration/DefaultConfiguration.php+2 −9
- typo3/sysext/core/Documentation/Changelog/14.1/Deprecation-108524-FluidNamespacesInTYPO3_CONF_VARS.rstnew+58 −0
- typo3/sysext/core/Documentation/Changelog/14.1/Feature-108524-ConfigurationFileToRegisterGlobalFluidNamespaces.rstnew+167 −0
- typo3/sysext/fluid/Classes/Core/ViewHelper/ViewHelperResolverFactory.php+14 −3
- typo3/sysext/fluid/Classes/Event/ModifyNamespacesEvent.phpnew+46 −0
- typo3/sysext/fluid/Classes/ServiceProvider.php+3 −0
- typo3/sysext/fluid/Configuration/Fluid/Namespaces.phpnew+8 −0
- typo3/sysext/fluid/Tests/Functional/Core/ViewHelper/ViewHelperResolverTest.php+34 −0
- typo3/sysext/fluid/Tests/Functional/Fixtures/Extensions/fluid_namespace/Configuration/Fluid/Namespaces.phpnew+5 −0
- typo3/sysext/fluid/Tests/Functional/Fixtures/Extensions/fluid_namespace/Resources/Public/Icons/Extension.svgnew+1 −0
- typo3/sysext/fluid/Tests/Functional/Fixtures/Extensions/fluid_namespace/composer.jsonnew+19 −0
- typo3/sysext/fluid/Tests/Functional/Fixtures/Extensions/fluid_namespace/ext_emconf.phpnew+18 −0
- typo3/sysext/fluid/Tests/Functional/Fixtures/Extensions/fluid_namespace/ext_localconf.phpnew+4 −0
- typo3/sysext/fluid/Tests/Functional/Fixtures/Extensions/fluid_test/Classes/EventListener/ModifyNamespacesListener.phpnew+36 −0
- typo3/sysext/fluid/Tests/Functional/Fixtures/Extensions/fluid_test/Configuration/Fluid/Namespaces.phpnew+14 −0
- typo3/sysext/fluid/Tests/Functional/Fixtures/Extensions/fluid_test/composer.json+2 −1
- typo3/sysext/fluid/Tests/Functional/Fixtures/Extensions/fluid_test/ext_localconf.phpnew+4 −0
Review log 1519
-
Simon Praetorius uploaded patch set 1 12/18/25, 16:07
-
core-ci voted on patch set 1 V -1 12/18/25, 16:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92431
-
Simon Praetorius uploaded patch set 2
V -112/18/25, 16:22 -
core-ci voted on patch set 2 V +1 12/18/25, 16:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92433
-
Simon Praetorius uploaded patch set 3
V +112/26/25, 16:57 -
core-ci voted on patch set 3 V +1 12/26/25, 17:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92719
-
Simon Praetorius updated the commit message in patch set 4
V +112/26/25, 17:05 -
Simon Praetorius marked it ready for review 12/26/25, 17:05
-
core-ci voted on patch set 4 V +1 12/26/25, 17:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92720
-
Lina Wolf commented on patch set 4 CR +1 V +1 01/04/26, 08:52
I tested this with the Gravator viewHelper of the blogexample extension and it worked fine. Code looks good -
Lina Wolf commented on patch set 4 01/04/26, 08:56
You can use https://github.com/TYPO3-Documentation/blog_example/pull/181 to test this manually -
Matthias Vogel voted on patch set 4 CR +1 01/09/26, 11:47
-
Benni Mack commented on patch set 4 01/09/26, 12:40
hey simon, can you quickly elaborate why having an extra file for this better than one LOC in ext_localconf.php? -
Lina Wolf commented on patch set 4 01/09/26, 12:43
Reply
From my point of view individual files for separate concerns cause less conflicts in merging etc. -
Georg Ringer voted on patch set 4 CR +1 V +1 01/09/26, 12:52
-
Simon Praetorius commented on patch set 4 01/09/26, 12:55
Reply
From my point of view, there are several reasons: * merging is more explicit/standardized. Currently, everyone seems to do it slightly differently (initialize empty array with/without if/at all...) * you can see at one glance which extension adds/extends namespaces * it's consistent to other configuration within TYPO3 The other Fluid-related config in TYPO3_CONF_VARS can probably be replaced with DI soon (probably in v15 because it needs a breaking change in Fluid in one instance). Also, I'd like to introduce another Fluid-related config file in a follow-up to register components, so there would be several config files in the Fluid folder, similar to Extbase. -
Benni Mack commented on patch set 4 01/09/26, 14:03
Reply
thx -
Simon Praetorius voted on patch set 4 CR +2 V +2 01/09/26, 14:06
-
Simon Praetorius merged patch set 5 01/09/26, 14:06