Review main Merged

92181[TASK] Improve wording for clear all caches description

Josef Glatz CR +2 V +2 Easy +2 −2 updated 12/24/25, 09:54

Commit message

The description is refined and mentions frontend
related caches too. Previously, it seemed that
possibly no frontend-related caches were being
cleared when reading the description.

It also changes the error message to a less speculative
variant.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Peter Kraume +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Peter Kraume +1
    • Rachel Foucard +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 2226

Show 1 earlier messages
  1. Josef Glatz uploaded patch set 1 12/19/25, 12:56

  1. core-ci voted on patch set 1 V +1 12/19/25, 13:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92480

  2. Josef Glatz commented on patch set 1 12/19/25, 13:36

    This change is ready for review.
  3. Riccardo De Contardi voted on patch set 1 CR +1 12/19/25, 13:52

  4. Josef Glatz commented on patch set 1 12/19/25, 13:52

    I still see developers who, when deleting the cache in the backend, first clear the frontend cache and then also click on the Clear All Cache button. I think this is a relic from earlier times. If we simply mention in the already very long list that frontend caches are also being taught, it brings added value and a clear statement.
  5. Riccardo De Contardi commented on patch set 1 12/19/25, 13:54

    I've left a suggestion

    locallang_core.xlf:1077

    I'd change this in "An error occurred while clearing the cache. Some caches may not have been cleared successfully" as it sounds less speculative ("...it is likely..."
  6. Rachel Foucard commented on patch set 1 12/19/25, 13:56

    locallang_core.xlf:1071

    I didn't know that and was always clicking both buttons! In that case, it would be even more efficient to start the two descriptions with the same sentence, so that the user quickly visualize and understand that the second button cover the same caches AND additional caches: [ ] Clear frontend and page-related caches. [ ] Clear frontend and page-related caches, all system-related caches, including localization, extension configuration, file and opcode caches. Rebuilding this caches may take some time.
  7. Josef Glatz voted on patch set 1 CR -1 12/19/25, 15:31

  8. Josef Glatz commented on patch set 1 12/23/25, 07:50

    on it
  9. Josef Glatz uploaded patch set 2 CR +1 V +1 12/23/25, 07:54

  10. core-ci voted on patch set 2 V +1 12/23/25, 08:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92607

  11. Josef Glatz commented on patch set 2 12/23/25, 08:15

    locallang_core.xlf:1077 Reply

    Done
  12. Josef Glatz uploaded patch set 3 V +1 12/23/25, 08:16

  13. Josef Glatz commented on patch set 3 12/23/25, 08:17

    locallang_core.xlf:1071 Reply

    Done
  14. Peter Kraume voted on patch set 3 CR +1 V +1 12/23/25, 08:20

  15. core-ci voted on patch set 3 V +1 12/23/25, 08:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92608

  16. Rachel Foucard voted on patch set 3 V +1 12/23/25, 08:27

  17. Riccardo De Contardi voted on patch set 3 CR +1 12/23/25, 08:43

  18. Christian Kuhn commented on patch set 3 CR -1 12/23/25, 13:46

    locallang_core.xlf:1071

    "Rebuilding this cacheS" ?
  19. Riccardo De Contardi commented on patch set 4 CR +1 V +1 12/23/25, 13:51

    Published edit on patch set 3.
  20. Riccardo De Contardi commented on patch set 4 12/23/25, 13:52

    locallang_core.xlf:1071 Reply

    Fixed, discard my change if you think is not correct.
  21. core-ci voted on patch set 4 V +1 12/23/25, 14:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92619

  22. Peter Kraume voted on patch set 4 CR +1 V +1 12/23/25, 20:36

  23. Rachel Foucard voted on patch set 4 V +1 12/24/25, 08:37

  24. Christian Kuhn commented on patch set 4 CR +2 V +2 12/24/25, 09:54

    locallang_core.xlf:1071 Reply

    Done
  25. Christian Kuhn merged patch set 5 12/24/25, 09:54