Review main Merged

92187[TASK] Unify ViewHelper arguments naming

Simon Praetorius CR +2 V +2 Easy +30 −9 updated 01/15/26, 12:43

Commit message

`parts-as` is the only ViewHelper argument that does not use lower
camel case. As a first step, an additional `partsAs` argument is
introduced, which is preferred over `parts-as`.

Review

  • Code review CR +2 Done
    • Simon Praetorius +2
    • Oliver Klee +1
    • Christian Kuhn +1
    • Sven Liebert +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Simon Praetorius +2
    • Josef Glatz +1
    • Oliver Klee +1
    • Christian Kuhn +1
    • Sven Liebert +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1316

  1. Simon Praetorius uploaded patch set 1 12/20/25, 11:03

  2. core-ci voted on patch set 1 V +1 12/20/25, 11:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92509

  3. Simon Praetorius uploaded patch set 2 V +1 12/20/25, 11:11

  4. Simon Praetorius uploaded patch set 3 12/20/25, 11:13

  5. core-ci voted on patch set 2 V +1 12/20/25, 11:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92510

  6. core-ci voted on patch set 3 V +1 12/20/25, 11:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92511

  7. Oliver Klee voted on patch set 3 CR +1 V +1 12/20/25, 17:30

  8. Simon Schaufelberger voted on patch set 3 CR +1 V +1 12/22/25, 00:18

  9. Sven Liebert voted on patch set 3 CR +1 V +1 12/27/25, 08:25

  10. Josef Glatz commented on patch set 3 12/28/25, 07:41

    is it too late to add a "will be deprecated in version x"?
  11. Simon Praetorius commented on patch set 3 12/28/25, 08:21

    Reply

    This patch doesn‘t introduce a deprecation, so we can‘t mention it. There will be a follow-up where this can be discussed and decided.
  12. Josef Glatz commented on patch set 3 12/28/25, 13:42

    Reply

    yes, I know. it was just a suggestion to add an info in the VH code for future
  13. Josef Glatz voted on patch set 3 V +1 12/28/25, 13:42

  14. Christian Kuhn voted on patch set 3 CR +1 V +1 01/15/26, 11:10

  15. Simon Praetorius voted on patch set 3 CR +2 V +2 01/15/26, 12:43

  16. Simon Praetorius merged patch set 4 01/15/26, 12:43