92190[TASK] Decouple module route initialization
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Stefan Bürk +1
- Oliver Hader +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Stefan Bürk +1
- Oliver Hader +1
- core-ci +1 CI
Issues 1
Files 4
Review log 3348
Show 1323 earlier messages
-
Benjamin Franzke uploaded patch set 1 12/20/25, 15:54
-
core-ci voted on patch set 1 V +1 12/20/25, 16:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92518
-
Benjamin Franzke rebased onto patch set 2
V +112/26/25, 09:24 -
core-ci voted on patch set 2 V -1 12/26/25, 09:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92707
-
core-ci voted on patch set 2 V +1 12/26/25, 10:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92707
-
Benjamin Franzke rebased onto patch set 3
V +101/08/26, 07:56 -
core-ci voted on patch set 3 V +1 01/08/26, 08:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93095
-
Benjamin Franzke rebased onto patch set 4
V +101/13/26, 15:04 -
core-ci voted on patch set 4 V +1 01/13/26, 15:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93377
-
Benjamin Franzke rebased onto patch set 5
V +101/27/26, 10:00 -
core-ci voted on patch set 5 V +1 01/27/26, 10:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94404
-
Benjamin Franzke rebased onto patch set 6
V +102/06/26, 15:25 -
core-ci voted on patch set 6 V -1 02/06/26, 15:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95305
-
Benjamin Franzke rebased onto patch set 7
V -102/28/26, 10:24 -
core-ci voted on patch set 7 V +1 02/28/26, 11:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97020
-
Benjamin Franzke rebased onto patch set 8
V +103/03/26, 13:27 -
core-ci voted on patch set 8 V +1 03/03/26, 13:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97181
-
Benjamin Franzke wrote 03/03/26, 17:27
Hashtag added: actions -
Benjamin Franzke rebased onto patch set 9
V +103/04/26, 14:12 -
core-ci voted on patch set 9 V +1 03/04/26, 14:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97328
-
Benni Mack commented on patch set 9 03/04/26, 15:22
I had a similar request in mind for quite some time, as I need to register (or de-register) modules based on other or more flexible criteria than just the list of Modules.php. However, this change now does not accommodate to modify the list of modules but only accommodate the routes. Any chance we can expand this and make it public or will this be added at a later point? -
Benjamin Franzke commented on patch set 9 03/04/26, 17:01
Reply
I don't have plans for that. I think that would/could be an event that is dispatched by the ModuleRegistry. In my opinion that would be out of scope for this patch, since this is about decoupling modules from routes, while you idea is about decoupling module registration from `Modules.php` (which we'd for example need in case we allow to configure modules via PHP attributes or so). -
Benjamin Franzke rebased onto patch set 10
V +103/12/26, 21:14
-
core-ci voted on patch set 10 V +1 03/12/26, 21:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97848
-
Benjamin Franzke marked it ready for review 03/18/26, 05:19
-
Benjamin Franzke commented on patch set 10 03/19/26, 11:51
Reply
Hey Benni! Did this answer your question? -
Benni Mack commented on patch set 10 03/20/26, 13:09
Reply
yes -
Benjamin Franzke rebased onto patch set 11
V +103/22/26, 07:29 -
core-ci voted on patch set 11 V +1 03/22/26, 07:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98374
-
Oli Bartsch commented on patch set 11 03/22/26, 08:34
RouterConfigurationEvent.php:23Could you please provide a use case for this event. -
Benjamin Franzke commented on patch set 11 03/23/26, 08:03
RouterConfigurationEvent.php:23ReplyThe usecase is decoupling of our route providers. Please see commit message: > We now use an event to ensure that the router configurator does not depend on module infrastructure. Fine with you? -
Oli Bartsch commented on patch set 11 03/23/26, 09:13
RouterConfigurationEvent.php:23ReplyI've read the commit message. My question is about: > This will allow to add more route providers in future. What would be such route provider? -
Benjamin Franzke commented on patch set 11 03/23/26, 10:14
RouterConfigurationEvent.php:23ReplyAh, I see. Please see relation chain for a possible future usage example. There is https://review.typo3.org/c/Packages/TYPO3.CMS/+/91563/32/typo3/sysext/backend/Classes/Http/ActionHandler.php which registers routes based on a `AsAction` attribute (and allows to dispatch the actions accordingly). -
Benjamin Franzke rebased onto patch set 12
V +103/27/26, 20:09 -
core-ci voted on patch set 12 V +1 03/27/26, 20:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98913
-
Benjamin Franzke rebased onto patch set 13
V +103/30/26, 15:25 -
core-ci voted on patch set 13 V +1 03/30/26, 16:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99087
-
Hannes Lau voted on patch set 13 CR +1 03/30/26, 19:27
-
Oliver Hader commented on patch set 13 03/30/26, 19:30
ModuleRegistry.php:92What do you think about adding an additional hint how this is called as comment? -
Oliver Hader voted on patch set 13 CR +1 V +1 03/30/26, 19:46
-
Stefan Bürk voted on patch set 13 CR +1 V +1 03/31/26, 09:16
-
Benjamin Franzke uploaded patch set 14
CR +1V +104/01/26, 13:18 -
Benjamin Franzke commented on patch set 14 04/01/26, 13:18
ModuleRegistry.php:92ReplyThx, good point! Done.RouterConfigurationEvent.php:23ReplyHey Oli, Did this answer your question? -
core-ci voted on patch set 14 V +1 04/01/26, 13:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99408
-
Oliver Hader voted on patch set 14 CR +1 V +1 04/01/26, 20:45
-
Stefan Bürk voted on patch set 14 CR +1 V +1 04/02/26, 09:48
-
Benjamin Franzke commented on patch set 14 CR +2 V +2 04/02/26, 10:17
RouterConfigurationEvent.php:23ReplyHey Oli, Since we haven't heard back, I'll go ahead and mark this as resolved in order to merge. Feel free to reopen if you have further remarks that should have been taken into account. I'm also fine to revert in case you see issues with this change. Thanks, Benjamin -
Benjamin Franzke merged patch set 15 04/02/26, 10:17