Review main Merged

92190[TASK] Decouple module route initialization

Benjamin Franzke CR +2 V +2 Easy +41 −6 updated 04/02/26, 10:17

Commit message

Module routes are currently tightly coupled to the
backend router. We now use an event to ensure that the
router configurator does not depend on module infrastructure.

This will allow to add more route providers in future.
This is internal API for the time being.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • Oliver Hader +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 3348

Show 1323 earlier messages
  1. Benjamin Franzke uploaded patch set 1 12/20/25, 15:54

  2. core-ci voted on patch set 1 V +1 12/20/25, 16:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92518

  3. Benjamin Franzke rebased onto patch set 2 V +1 12/26/25, 09:24

  4. core-ci voted on patch set 2 V -1 12/26/25, 09:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92707

  5. core-ci voted on patch set 2 V +1 12/26/25, 10:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92707

  6. Benjamin Franzke rebased onto patch set 3 V +1 01/08/26, 07:56

  7. core-ci voted on patch set 3 V +1 01/08/26, 08:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93095

  8. Benjamin Franzke rebased onto patch set 4 V +1 01/13/26, 15:04

  9. core-ci voted on patch set 4 V +1 01/13/26, 15:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93377

  10. Benjamin Franzke rebased onto patch set 5 V +1 01/27/26, 10:00

  11. core-ci voted on patch set 5 V +1 01/27/26, 10:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94404

  12. Benjamin Franzke rebased onto patch set 6 V +1 02/06/26, 15:25

  13. core-ci voted on patch set 6 V -1 02/06/26, 15:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95305

  14. Benjamin Franzke rebased onto patch set 7 V -1 02/28/26, 10:24

  15. core-ci voted on patch set 7 V +1 02/28/26, 11:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97020

  16. Benjamin Franzke rebased onto patch set 8 V +1 03/03/26, 13:27

  17. core-ci voted on patch set 8 V +1 03/03/26, 13:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97181

  18. Benjamin Franzke wrote 03/03/26, 17:27

    Hashtag added: actions
  19. Benjamin Franzke rebased onto patch set 9 V +1 03/04/26, 14:12

  20. core-ci voted on patch set 9 V +1 03/04/26, 14:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97328

  21. Benni Mack commented on patch set 9 03/04/26, 15:22

    I had a similar request in mind for quite some time, as I need to register (or de-register) modules based on other or more flexible criteria than just the list of Modules.php. However, this change now does not accommodate to modify the list of modules but only accommodate the routes. Any chance we can expand this and make it public or will this be added at a later point?
  22. Benjamin Franzke commented on patch set 9 03/04/26, 17:01

    Reply

    I don't have plans for that. I think that would/could be an event that is dispatched by the ModuleRegistry. In my opinion that would be out of scope for this patch, since this is about decoupling modules from routes, while you idea is about decoupling module registration from `Modules.php` (which we'd for example need in case we allow to configure modules via PHP attributes or so).
  23. Benjamin Franzke rebased onto patch set 10 V +1 03/12/26, 21:14

  1. core-ci voted on patch set 10 V +1 03/12/26, 21:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97848

  2. Benjamin Franzke marked it ready for review 03/18/26, 05:19

  3. Benjamin Franzke commented on patch set 10 03/19/26, 11:51

    Reply

    Hey Benni! Did this answer your question?
  4. Benni Mack commented on patch set 10 03/20/26, 13:09

    Reply

    yes
  5. Benjamin Franzke rebased onto patch set 11 V +1 03/22/26, 07:29

  6. core-ci voted on patch set 11 V +1 03/22/26, 07:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98374

  7. Oli Bartsch commented on patch set 11 03/22/26, 08:34

    RouterConfigurationEvent.php:23

    Could you please provide a use case for this event.
  8. Benjamin Franzke commented on patch set 11 03/23/26, 08:03

    RouterConfigurationEvent.php:23 Reply

    The usecase is decoupling of our route providers. Please see commit message: > We now use an event to ensure that the router configurator does not depend on module infrastructure. Fine with you?
  9. Oli Bartsch commented on patch set 11 03/23/26, 09:13

    RouterConfigurationEvent.php:23 Reply

    I've read the commit message. My question is about: > This will allow to add more route providers in future. What would be such route provider?
  10. Benjamin Franzke commented on patch set 11 03/23/26, 10:14

    RouterConfigurationEvent.php:23 Reply

    Ah, I see. Please see relation chain for a possible future usage example. There is https://review.typo3.org/c/Packages/TYPO3.CMS/+/91563/32/typo3/sysext/backend/Classes/Http/ActionHandler.php which registers routes based on a `AsAction` attribute (and allows to dispatch the actions accordingly).
  11. Benjamin Franzke rebased onto patch set 12 V +1 03/27/26, 20:09

  12. core-ci voted on patch set 12 V +1 03/27/26, 20:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98913

  13. Benjamin Franzke rebased onto patch set 13 V +1 03/30/26, 15:25

  14. core-ci voted on patch set 13 V +1 03/30/26, 16:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99087

  15. Hannes Lau voted on patch set 13 CR +1 03/30/26, 19:27

  16. Oliver Hader commented on patch set 13 03/30/26, 19:30

    ModuleRegistry.php:92

    What do you think about adding an additional hint how this is called as comment?
  17. Oliver Hader voted on patch set 13 CR +1 V +1 03/30/26, 19:46

  18. Stefan Bürk voted on patch set 13 CR +1 V +1 03/31/26, 09:16

  19. Benjamin Franzke uploaded patch set 14 CR +1 V +1 04/01/26, 13:18

  20. Benjamin Franzke commented on patch set 14 04/01/26, 13:18

    ModuleRegistry.php:92 Reply

    Thx, good point! Done.

    RouterConfigurationEvent.php:23 Reply

    Hey Oli, Did this answer your question?
  21. core-ci voted on patch set 14 V +1 04/01/26, 13:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99408

  22. Oliver Hader voted on patch set 14 CR +1 V +1 04/01/26, 20:45

  23. Stefan Bürk voted on patch set 14 CR +1 V +1 04/02/26, 09:48

  24. Benjamin Franzke commented on patch set 14 CR +2 V +2 04/02/26, 10:17

    RouterConfigurationEvent.php:23 Reply

    Hey Oli, Since we haven't heard back, I'll go ahead and mark this as resolved in order to merge. Feel free to reopen if you have further remarks that should have been taken into account. I'm also fine to revert in case you see issues with this change. Thanks, Benjamin
  25. Benjamin Franzke merged patch set 15 04/02/26, 10:17