Review main Merged

92198[TASK] Add typehint int for method doesPageHaveUnallowedTables

Nikita Hovratov CR +2 V +2 Easy +3 −5 updated 12/24/25, 10:51

Commit message

This method is only used in one place in the checkValue method.
There the call to getDefaultLanguagePageId already ensures that
the $recordId is an int.

The check for "not a number" doesn't make any sense anymore.
For safety measures, we can keep an explicit check for zero.
However, it's very unlikely to be zero. The only imaginable
scenario could be userland code providing bogus parameters.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Anja Leichsenring +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Anja Leichsenring +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Nikita Hovratov uploaded patch set 1 12/20/25, 23:12

  2. core-ci voted on patch set 1 V +1 12/20/25, 23:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92536

  3. Oliver Klee voted on patch set 1 CR +1 V +1 12/20/25, 23:41

  4. Simon Schaufelberger voted on patch set 1 CR +1 V +1 12/21/25, 22:36

  5. Anja Leichsenring voted on patch set 1 CR +1 V +1 12/24/25, 10:48

  6. Christian Kuhn commented on patch set 1 CR +2 V +2 12/24/25, 10:51

    DataHandler.php:7441

    we could protect this method as well.
  7. Christian Kuhn merged patch set 2 12/24/25, 10:51