92200[TASK] Simplify usage of substr by replacing it with str_ends_with
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Josua Vogel +1
-
Verified V +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Josua Vogel +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1215
-
Nikita Hovratov uploaded patch set 1 12/20/25, 23:24
-
core-ci voted on patch set 1 V +1 12/20/25, 23:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92538
-
Oliver Klee voted on patch set 1 CR +1 12/20/25, 23:43
-
Oliver Klee commented on patch set 1 12/20/25, 23:47
-
Nikita Hovratov commented on patch set 1 12/21/25, 00:09
VariableProcessor.php:290ReplyNo, if $prefix is an empty string, it will not go into the condition. If we remove the "not empty string" part of the condition, the second part will be "true", as an empty string will never end with the delimiter. Here is a quick test: https://3v4l.org/ot5hv#v8.5.0 -
Oliver Klee commented on patch set 1 12/21/25, 08:13
VariableProcessor.php:290ReplyAh, good to know. Thanks for checking! -
Nikita Hovratov rebased onto patch set 2
CR +1V +101/21/26, 23:49 -
core-ci voted on patch set 2 V -1 01/21/26, 23:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93987
-
Nikita Hovratov rebased onto patch set 3
V -101/22/26, 06:41 -
core-ci voted on patch set 3 V +1 01/22/26, 06:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94008
-
Stefan Bürk voted on patch set 3 CR +1 V +1 01/22/26, 06:53
-
Oliver Klee voted on patch set 3 CR +1 V +1 01/22/26, 08:41
-
Josua Vogel voted on patch set 3 CR +1 V +1 01/23/26, 15:25
-
Stefan Bürk voted on patch set 3 CR +2 V +2 01/23/26, 15:26
-
Stefan Bürk merged patch set 4 01/23/26, 15:26
VariableProcessor.php:290