Review main Merged

92209[TASK] Further cleanup of EditDocumentController

Benni Mack CR +2 V +2 Hard +299 −313 updated 01/05/26, 10:17

Commit message

This commit improves the EditDocumentController
by introducing stronger type safety and
streamlining the code execution flow.

The editconf array is now sanitized at the very
beginning through a new dedicated method to make
numerous redundant checks throughout the codebase
obsolete.

The refactoring introduces proper typing with $elementsData
now defined as FormElementData[] and $firstEl as
?FormElementData, replacing the previous generic types.

Several now unused class properties have been removed
entirely ($storeTitle, $storeArray, $viewId, and $isSavedRecord),
with their functionality either eliminated or relocated into
the FormElementData DTO where it logically belongs.

Methods have been restructured to return values rather
than modify class state, making the code more predictable
and testable. The controller now uses UriBuilder consistently
for URL generation, and complex logic has been extracted
into well-named methods like
prepareColumnsOnlyConfigurationFromRequest()
and closeAndPossiblyRedirectAction().

This change takes the code one further step to allow to
- edit duplicates without persisting them first
- separate persisting logic away from rendering the form

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Jochen Roth +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jochen Roth +1
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1525

  1. Benni Mack uploaded patch set 1 12/22/25, 15:34

  2. core-ci voted on patch set 1 V -1 12/22/25, 15:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92583

  3. Benni Mack uploaded patch set 2 V -1 12/23/25, 07:03

  4. core-ci voted on patch set 2 V -1 12/23/25, 07:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92604

  5. Josef Glatz updated the commit message in patch set 3 V -1 12/28/25, 14:07

  6. core-ci voted on patch set 3 V -1 12/28/25, 14:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92753

  7. Benni Mack uploaded patch set 4 V -1 12/28/25, 15:38

  8. core-ci voted on patch set 4 V +1 12/28/25, 15:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92756

  9. Benni Mack uploaded patch set 5 V +1 12/31/25, 12:13

  10. core-ci voted on patch set 5 V -1 12/31/25, 12:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92844

  11. Benni Mack uploaded patch set 6 V -1 12/31/25, 12:24

  12. core-ci voted on patch set 6 V -1 12/31/25, 12:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92845

  13. Benni Mack uploaded patch set 7 V -1 12/31/25, 14:20

  14. core-ci voted on patch set 7 V +1 12/31/25, 14:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92847

  15. Benni Mack updated the commit message in patch set 8 V +1 12/31/25, 15:05

  16. core-ci voted on patch set 8 V +1 12/31/25, 15:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92848

  17. Benni Mack commented on patch set 9 V +1 01/04/26, 18:38

    Published edit on patch set 8.
  18. core-ci voted on patch set 9 V +1 01/04/26, 18:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92939

  19. Jochen Roth voted on patch set 9 CR +1 V +1 01/04/26, 20:41

  20. Benni Mack updated the commit message in patch set 10 CR +1 V +1 01/05/26, 09:05

  21. Anja Leichsenring voted on patch set 10 CR +1 V +1 01/05/26, 09:14

  22. core-ci voted on patch set 10 V +1 01/05/26, 09:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92976

  23. Jochen Roth voted on patch set 10 CR +1 V +1 01/05/26, 10:05

  24. Benni Mack voted on patch set 10 CR +2 V +2 01/05/26, 10:17

  25. Benni Mack merged patch set 11 01/05/26, 10:17