Review main Abandoned

92213[BUGFIX] Mark processed files as not deleted after processing

Christian Weiske CR +1 V +1 Easy +11 −0 updated 09/07/26, 11:38

Commit message

When renaming a file in a storage driver that does not natively
support renames (like S3), the file modification time changes
- causing preview images to be deleted and regenerated.

`ProcessedFile::needsReprocessing()` deletes the file, and indirectly
marks itself as deleted.
Later the same processed file object is written again, but the
`deleted` property is not reset.

This patch resets the "deleted" property from within the
backend image task processor.
A new "setNotDeleted()" low-level method is added to `AbstractFile`
to make this possible.

Review

  • Code review CR +1
    • Oliver Klee +1
    • Simon Schaufelberger +1
  • Verified V +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1318

  1. Christian Weiske uploaded patch set 1 12/23/25, 09:05

  2. core-ci voted on patch set 1 V +1 12/23/25, 09:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92610

  3. Benni Mack updated the commit message in patch set 2 V +1 04/22/26, 06:38

  4. core-ci voted on patch set 2 V -1 04/22/26, 07:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100744

  5. Christian Weiske rebased onto patch set 3 V -1 05/18/26, 08:27

  6. core-ci voted on patch set 3 V +1 05/18/26, 08:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102119

  7. Christian Weiske rebased onto patch set 4 V +1 06/17/26, 12:05

  8. core-ci voted on patch set 4 V +1 06/17/26, 12:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103607

  9. Simon Schaufelberger voted on patch set 4 CR +1 V +1 06/18/26, 14:18

  10. Oliver Klee commented on patch set 4 06/18/26, 16:41

    AbstractFile.php:393

    If this is to be used inside FAL, maybe we should mark this method as `@internal`. WDYT?
  11. Oliver Klee voted on patch set 4 V +1 06/18/26, 19:26

  12. Christian Weiske commented on patch set 4 06/19/26, 05:38

    AbstractFile.php:393 Reply

    I have no opinion on that and will do whatever you deem necessary.
  13. Christian Weiske commented on patch set 4 06/23/26, 07:55

    AbstractFile.php:393 Reply

    Done
  14. Christian Weiske uploaded patch set 5 CR +1 V +1 06/23/26, 07:58

  15. Oliver Klee voted on patch set 5 CR +1 06/23/26, 07:59

  16. core-ci voted on patch set 5 V +1 06/23/26, 08:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103759

  17. Simon Schaufelberger voted on patch set 5 CR +1 V +1 06/23/26, 08:10

  18. Christian Weiske abandoned the change 09/07/26, 11:38

    Patch 95678 fixed it.