Review main Merged

92215[TASK] Decouple error messages from BackendUserAuthentication

Oliver Hader CR +2 V +2 Hard +303 −133 updated 01/21/26, 12:15

Commit message

Introduce AccessCheckResult value object to replace the anti-pattern
where BackendUserAuthentication::recordEditAccessInternals() returns
a boolean but communicates error details through $errorMsg property.

Changes:
* Add AccessCheckResult readonly class with public $isAllowed and
  $errorMessage properties
* Add BackendUserAuthentication::checkRecordEditAccess() returning
  AccessCheckResult
* Deprecate recordEditAccessInternals() and $errorMsg property
  (both were marked @internal before already)
* Update all core usages to use direct property access:
  - DataHandler & Recycler
  - FormEngine & EditDocumentController

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 18

Review log 2133

Show 58 earlier messages
  1. Oliver Hader uploaded patch set 1 12/23/25, 12:27

  2. core-ci voted on patch set 1 V -1 12/23/25, 12:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92615

  3. Oliver Hader uploaded patch set 2 V -1 12/23/25, 12:39

  4. Oliver Hader uploaded patch set 3 12/23/25, 12:46

  5. core-ci voted on patch set 2 V +1 12/23/25, 12:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92616

  6. core-ci voted on patch set 3 V +1 12/23/25, 12:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92617

  7. Simon Schaufelberger commented on patch set 3 12/23/25, 12:57

    BackendUserAuthentication.php:728

    indentation looks a bit too deep here

    Deprecation-108568-DeprecateBackendUserAuthenticationrecordEditAccessInternals.rst:39

    @internal doesn't need a `:php:` as this is just a string and no php code
  8. Oliver Hader uploaded patch set 4 V +1 12/23/25, 13:42

  1. Oliver Hader commented on patch set 3 12/23/25, 13:42

    BackendUserAuthentication.php:728 Reply

    Done

    Deprecation-108568-DeprecateBackendUserAuthenticationrecordEditAccessInternals.rst:39 Reply

    Ah, I just realized that this deprecation documentation would not have been required, since both locations were `@internal` before already. I dropping the RST file again.
  2. core-ci voted on patch set 4 V +1 12/23/25, 13:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92618

  3. Benni Mack uploaded patch set 5 V +1 12/26/25, 10:01

  4. Benni Mack uploaded patch set 6 12/26/25, 10:04

  5. Benni Mack voted on patch set 6 CR +1 V +1 12/26/25, 10:06

  6. core-ci voted on patch set 5 V +1 12/26/25, 10:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92714

  7. core-ci voted on patch set 6 V +1 12/26/25, 10:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92715

  8. Oliver Hader wrote 01/06/26, 10:28

    Topic set to permission-set
  9. Oliver Hader commented on patch set 6 01/06/26, 10:39

    AccessCheckResult.php:28

    Should already be located in `TYPO3\CMS\Core\Security\PermissionSet` layer
  10. Oliver Hader commented on patch set 6 01/08/26, 19:01

    AccessCheckResult.php:28 Reply

    Never mind, since it's `@internal` - it can be moved any time.
  11. Oliver Hader uploaded patch set 7 CR +1 V +1 01/09/26, 10:54

  12. core-ci voted on patch set 7 V +1 01/09/26, 11:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93141

  13. Oliver Hader uploaded patch set 8 V +1 01/21/26, 08:11

  14. core-ci voted on patch set 8 V +1 01/21/26, 08:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93921

  15. Oliver Hader rebased onto patch set 9 V +1 01/21/26, 08:57

  16. core-ci voted on patch set 9 V +1 01/21/26, 09:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93923

  17. Benni Mack commented on patch set 10 V +1 01/21/26, 09:15

    Published edit on patch set 9.
  18. core-ci voted on patch set 10 V +1 01/21/26, 09:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93927

  19. Oliver Hader uploaded patch set 11 V +1 01/21/26, 09:43

  20. core-ci voted on patch set 11 V -1 01/21/26, 09:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93928

  21. Oliver Hader uploaded patch set 12 V -1 01/21/26, 09:54

  22. core-ci voted on patch set 12 V +1 01/21/26, 10:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93929

  23. Benni Mack voted on patch set 12 CR +1 V +1 01/21/26, 10:18

  24. Georg Ringer voted on patch set 12 CR +2 V +2 01/21/26, 12:15

  25. Georg Ringer merged patch set 13 01/21/26, 12:15