Review main Merged

92227[FEATURE] TCA option allowedRecordTypes for Page Types

Nikita Hovratov CR +2 V +2 Hard +316 −77 updated 01/22/26, 08:51

Commit message

- Move allowedRecordTypes from PageDoktypeRegistry to TCA types
- Move default allowedRecordTypes to TCA ctrl
- Prepare default allowed by ignorePageTypeRestriction in TcaPreparation
- Deprecate PageDoktypeRegistry->add
- Deprecate PageDoktypeRegistry->addAllowedRecordTypes
- PageDoktypeRegistry->isRecordTypeAllowedForDoktype not nullable doktype
- Always enable option onlyAllowedTables -> return always true

Feature: New registration of allowedRecordTypes in TCA
Deprecations: Registration of allowedRecordTypes in PageDoktypeRegistry
Important: onlyAllowedTables is now always on (change in behavior)

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 10

Review log 2333

Show 68 earlier messages
  1. Nikita Hovratov uploaded patch set 1 12/25/25, 02:03

  2. core-ci voted on patch set 1 V -1 12/25/25, 02:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92671

  3. Nikita Hovratov uploaded patch set 2 V -1 12/25/25, 03:05

  4. core-ci voted on patch set 2 V +1 12/25/25, 03:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92673

  5. Soren Malling commented on patch set 2 12/26/25, 18:23

    I agree with the responsibility being moved to TCA - but I see the concept described in this change to be at the wrong place

    pages.php:61

    I suggest moving this to the 'types'. configuration similar to `creationOptions` https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/14.0/Feature-99459-RespectRecordTypeWhileCreatingNewRecords.html to keep type specific settings where relevant. And easily overriable

    pages.php:681

    This comment is targeted towards "sysfolder" and not "BE_USER_SECTION" that is set here
  6. Nikita Hovratov commented on patch set 2 12/26/25, 21:22

    Reply

    Can you elaborate?

    pages.php:61 Reply

    Defaults are not bound to a specific type, but serve as fallback if nothing else is defined.
  7. Soren Malling commented on patch set 2 12/27/25, 10:53

    Reply

    Me misunderstandig the UI here - was targeted my comment regarding "pages.php"

    pages.php:61 Reply

    Would we ever end up in a situation, where no record types is allowed when installing TYPO3 from scratch? Only if changes are, would it be the case.
  8. Soren Malling wrote 01/12/26, 15:02

    Removed cc Soren Malling.
  1. Nikita Hovratov uploaded patch set 3 V +1 01/17/26, 01:44

  2. core-ci voted on patch set 3 V -1 01/17/26, 01:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93653

  3. Nikita Hovratov uploaded patch set 4 V -1 01/17/26, 02:43

  4. Nikita Hovratov commented on patch set 4 01/17/26, 02:45

    pages.php:61 Reply

    Yes, you are right. It could happen, as TCA is mutable. I moved the "hard" defaults back to the method directly.

    pages.php:681 Reply

    Fixed.
  5. core-ci voted on patch set 4 V +1 01/17/26, 02:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93655

  6. Nikita Hovratov uploaded patch set 5 V +1 01/17/26, 09:30

  7. core-ci voted on patch set 5 V +1 01/17/26, 09:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93674

  8. Benni Mack commented on patch set 6 V +1 01/20/26, 15:37

    Published edit on patch set 5.
  9. core-ci voted on patch set 6 V -1 01/20/26, 15:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93873

  10. Benni Mack rebased onto patch set 7 V -1 01/21/26, 08:52

  11. core-ci voted on patch set 7 V +1 01/21/26, 09:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93922

  12. Oliver Hader commented on patch set 7 01/21/26, 09:27

    Important-108557-PageDokTypeRegistryOnlyAllowedTables.rst:6

    e.g. "Drop PDTR onlyAllowedTables option"
  13. Nikita Hovratov uploaded patch set 8 V +1 01/21/26, 13:37

  14. Nikita Hovratov commented on patch set 8 01/21/26, 13:37

    Important-108557-PageDokTypeRegistryOnlyAllowedTables.rst:6 Reply

    Done
  15. core-ci voted on patch set 8 V +1 01/21/26, 13:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93949

  16. Benni Mack uploaded patch set 9 V +1 01/21/26, 21:02

  17. Benni Mack uploaded patch set 10 01/21/26, 21:05

  18. core-ci voted on patch set 9 V +1 01/21/26, 21:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93975

  19. core-ci voted on patch set 10 V +1 01/21/26, 21:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93976

  20. Benni Mack voted on patch set 10 CR +1 V +1 01/21/26, 21:26

  21. Simon Schaufelberger commented on patch set 10 01/21/26, 21:35

    Deprecation-108557-TCAOptionAllowedRecordTypesForPageTypes.rst:61

    before 116 was an integer, now it is a string. is string required here? why is the page type suddenly a string? This information is important for me when I'm writing a rector rule.
  22. Benni Mack commented on patch set 10 01/21/26, 21:54

    Deprecation-108557-TCAOptionAllowedRecordTypesForPageTypes.rst:61 Reply

    The existing types in pages.php are all strings, I kept it that way.
  23. Simon Schaufelberger voted on patch set 10 CR +1 V +1 01/22/26, 08:36

  24. Benni Mack voted on patch set 10 CR +2 V +2 01/22/26, 08:50

  25. Benni Mack merged patch set 11 01/22/26, 08:51