92228[TASK] Remove @internal from SettingDefinition class
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Benjamin Franzke +1
- Oliver Klee +1
- Garvin Hicking +1
- Josua Vogel +1
- Stefan Froemken +1
- Sven Liebert +1
-
Verified V +2 Done
- Georg Ringer +2
- Benjamin Franzke +1
- Oliver Klee +1
- Garvin Hicking +1
- Josua Vogel +1
- Stefan Froemken +1
- Sven Liebert +1
- core-ci +1 CI
Issues 2
Files 1
Review log 1517
-
Josef Glatz uploaded patch set 1 12/28/25, 14:04
-
Josef Glatz commented on patch set 1 12/28/25, 14:05
This change is ready for review. -
core-ci voted on patch set 1 V +1 12/28/25, 14:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92752
-
Oliver Klee updated the commit message in patch set 2
V +112/28/25, 14:17 -
core-ci voted on patch set 2 V +1 12/28/25, 14:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92754
-
Benjamin Franzke voted on patch set 2 CR +1 V +1 12/29/25, 03:56
-
Josua Vogel voted on patch set 2 CR +1 V +1 12/29/25, 07:30
-
Lina Wolf commented on patch set 2 12/29/25, 07:40
If the `@internal` is removed this class becomes public API. So in my eyes there should be either a Feature RST or at least changes to another changelog entry. -
Josef Glatz commented on patch set 2 12/29/25, 07:46
Reply
Is Related enough? Because the Feature RsT already exists at https://docs.typo3.org/c/typo3/cms-dashboard/main/en-us/Developer/ConfigurableWidgets.html#configurable-widget-implementation -
Lina Wolf commented on patch set 2 12/29/25, 08:42
Reply
Ah ok, missed that -
Stefan Froemken voted on patch set 2 CR +1 V +1 12/29/25, 10:00
-
Oliver Klee voted on patch set 2 CR +1 V +1 12/29/25, 10:11
-
Georg Ringer voted on patch set 2 CR +1 V +1 12/29/25, 14:01
-
Garvin Hicking voted on patch set 2 CR +1 V +1 12/29/25, 14:48
-
Sven Liebert voted on patch set 2 CR +1 V +1 12/29/25, 22:30
-
Georg Ringer voted on patch set 2 CR +2 V +2 12/30/25, 07:20
-
Georg Ringer merged patch set 3 12/30/25, 07:20