Review main Merged

92228[TASK] Remove @internal from SettingDefinition class

Josef Glatz CR +2 V +2 Easy +0 −3 updated 12/30/25, 07:20

Commit message

This patch removes the `@internal` flag for
`TYPO3\CMS\Core\Settings\SettingDefinition`
to fulfill the examples for implementing a configurable dashboard
widget. It's necessary to add configurable settings with this class.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benjamin Franzke +1
    • Oliver Klee +1
    • Garvin Hicking +1
    • Josua Vogel +1
    • Stefan Froemken +1
    • Sven Liebert +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benjamin Franzke +1
    • Oliver Klee +1
    • Garvin Hicking +1
    • Josua Vogel +1
    • Stefan Froemken +1
    • Sven Liebert +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1517

  1. Josef Glatz uploaded patch set 1 12/28/25, 14:04

  2. Josef Glatz commented on patch set 1 12/28/25, 14:05

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 12/28/25, 14:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92752

  4. Oliver Klee updated the commit message in patch set 2 V +1 12/28/25, 14:17

  5. core-ci voted on patch set 2 V +1 12/28/25, 14:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92754

  6. Benjamin Franzke voted on patch set 2 CR +1 V +1 12/29/25, 03:56

  7. Josua Vogel voted on patch set 2 CR +1 V +1 12/29/25, 07:30

  8. Lina Wolf commented on patch set 2 12/29/25, 07:40

    If the `@internal` is removed this class becomes public API. So in my eyes there should be either a Feature RST or at least changes to another changelog entry.
  9. Josef Glatz commented on patch set 2 12/29/25, 07:46

  10. Lina Wolf commented on patch set 2 12/29/25, 08:42

    Reply

    Ah ok, missed that
  11. Stefan Froemken voted on patch set 2 CR +1 V +1 12/29/25, 10:00

  12. Oliver Klee voted on patch set 2 CR +1 V +1 12/29/25, 10:11

  13. Georg Ringer voted on patch set 2 CR +1 V +1 12/29/25, 14:01

  14. Garvin Hicking voted on patch set 2 CR +1 V +1 12/29/25, 14:48

  15. Sven Liebert voted on patch set 2 CR +1 V +1 12/29/25, 22:30

  16. Georg Ringer voted on patch set 2 CR +2 V +2 12/30/25, 07:20

  17. Georg Ringer merged patch set 3 12/30/25, 07:20