Review main Merged

92229[BUGFIX] Pass timeout to Symfony Process

Simon Schaufelberger CR +2 V +2 Easy +3 −3 updated 12/31/25, 13:58

Commit message

The migration to use Symfony Process in #104045 misses the point that
previous implementation using `exec` didn't run into timeouts while
using Symfony Process uses a timeout of 60 seconds by default.
This causes problems on long-running scripts like deployments.
With this patch, it is now possible to define custom timeouts.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Josef Glatz +1
    • Oliver Klee +1
    • Mathias Bolt Lesniak +1
  • Verified V +2 Done
    • Benni Mack +2
    • Josef Glatz +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 911

  1. Simon Schaufelberger uploaded patch set 1 12/29/25, 15:33

  2. core-ci voted on patch set 1 V +1 12/29/25, 15:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92773

  3. Garvin Hicking commented on patch set 1 12/29/25, 16:08

    Would be fine by me to make it a task and include 13.4.
  4. Georg Ringer updated the commit message in patch set 2 V +1 12/29/25, 16:38

  5. core-ci voted on patch set 2 V +1 12/29/25, 16:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92776

  6. Benni Mack voted on patch set 2 CR +1 V +1 12/30/25, 21:21

  7. Mathias Bolt Lesniak voted on patch set 2 CR +1 12/30/25, 21:27

  8. Josef Glatz voted on patch set 2 CR +1 V +1 12/31/25, 08:59

  9. Oliver Klee voted on patch set 2 CR +1 12/31/25, 10:13

  10. Benni Mack voted on patch set 2 CR +2 V +2 12/31/25, 13:58

  11. Benni Mack merged patch set 3 12/31/25, 13:58