Review main Merged

92231[BUGFIX] Re-add sorting to foreign table items

Georg Tiefenbrunn CR +2 V +2 Easy +32 −0 updated 03/12/26, 11:43

Commit message

Since 75a14ee `ORDERBY` statements in TCA `foreign_table_where` stopped
working. To return full foreign table records including not TCA managed
columns an innerJoin is used. The join causes the sorting to be lost.

To fix this, ordering definitions must be applied to both the original
query *and* the joined table result.

The original query still needs the ordering definitions to respect any
`LIMIT` or `GROUP BY` requirements.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 811

  1. Georg Tiefenbrunn uploaded patch set 1 12/29/25, 17:03

  2. core-ci voted on patch set 1 V +1 12/29/25, 17:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92780

  3. Georg Tiefenbrunn rebased onto patch set 2 V +1 03/12/26, 09:56

  4. Stefan Bürk commented on patch set 2 CR -1 03/12/26, 10:02

    On it ...
  5. core-ci voted on patch set 2 V +1 03/12/26, 10:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97807

  6. Stefan Bürk uploaded patch set 3 CR -1 V +1 03/12/26, 10:47

  7. Stefan Bürk commented on patch set 3 03/12/26, 10:49

    Reply

    Done
  8. core-ci voted on patch set 3 V +1 03/12/26, 11:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97815

  9. Stefan Bürk voted on patch set 3 CR +1 V +1 03/12/26, 11:32

  10. Georg Ringer voted on patch set 3 CR +2 V +2 03/12/26, 11:43

  11. Georg Ringer merged patch set 4 03/12/26, 11:43