92233[TASK] Centralize and streamline open documents functionality
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Josef Glatz +1
- Georg Ringer +1
- Jochen Roth +1
-
Verified V +2 Done
- Benni Mack +2
- Josef Glatz +1
- Georg Ringer +1
- Jochen Roth +1
- core-ci +1 CI
Issues 1
Files 8
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php+66 −100
- typo3/sysext/backend/Classes/Domain/Model/OpenDocument.php3new+93 −0
- typo3/sysext/backend/Classes/Domain/Repository/OpenDocumentRepository.phpnew+258 −0
- typo3/sysext/backend/Tests/Unit/Domain/Repository/OpenDocumentRepositoryTest.phpnew+501 −0
- typo3/sysext/opendocs/Classes/Backend/ToolbarItems/OpendocsToolbarItem.php+41 −25
- typo3/sysext/opendocs/Classes/Controller/OpenDocumentController.php+16 −4
- typo3/sysext/opendocs/Classes/Service/OpenDocumentService.phpdeleted+0 −118
- typo3/sysext/opendocs/Tests/Unit/Service/OpenDocumentServiceTest.phpdeleted+0 −150
Review log 1115
-
Benni Mack uploaded patch set 1 12/30/25, 16:20
-
Benni Mack updated the commit message in patch set 2 12/30/25, 16:20
-
core-ci voted on patch set 1 V -1 12/30/25, 16:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92810
-
core-ci voted on patch set 2 V -1 12/30/25, 16:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92811
-
Benni Mack uploaded patch set 3
V -112/30/25, 17:38 -
core-ci voted on patch set 3 V -1 12/30/25, 17:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92814
-
Benni Mack uploaded patch set 4
V -112/30/25, 18:35 -
core-ci voted on patch set 4 V +1 12/30/25, 18:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92816
-
Jochen Roth voted on patch set 4 CR +1 V +1 12/30/25, 21:59
-
Georg Ringer voted on patch set 4 CR +1 V +1 12/31/25, 06:12
-
Josef Glatz commented on patch set 4 CR -1 12/31/25, 08:57
Works as expected! Just a note/question on the legacy support partOpenDocument.php:52Loading legacy entries (before applying this patch and running `cache:flush`) does not show any of the legacy records in my dev-main instance. After applying the patch the opendocs dropdown is empty and just filled with new opened records. From my POV we do not need any legacy support at all: upgrading a TYPO3 instance to an new major version includes always the deletion of the user settings as prefered/musthave task. What do you think? -
Benni Mack commented on patch set 4 12/31/25, 09:42
OpenDocument.php:52ReplySeems like the migration is not perfect yet. Quick side note: I kept this part in for the time being, as it fataled when trying to re-use the old data. I hope to change the storage mechanism (= not utilizing the UC), which is now easy, because it's encapsulated in the repository. I'd like to do this separately - and until then I try to avoid fatal errors for some devs with ugly content in it (e.g. I had "Edit multiple content elements" in it) -
Josef Glatz commented on patch set 4 CR +1 V +1 12/31/25, 10:06
OpenDocument.php:52ReplyAcknowledged -
Benni Mack voted on patch set 4 CR +2 V +2 12/31/25, 10:18
-
Benni Mack merged patch set 5 12/31/25, 10:18