Review main Merged

92235[TASK] Transform page title edit to input element

Ayke Halder CR +2 V +2 Normal +77 −77 updated 11/19/26, 10:40

Commit message

This changes the look and feel of the page title edit function.

The icon to trigger page title editing is positioned next to the
title. Before, the icon was positioned on the opposite side of the
screen.

The activated edit function has the look of an input element with
proper buttons 'save' and 'close' now. The overlay of the edit form
introduced with #109525 is kept, so the element keeps its width and
height when switching between both modes, and the title text does not
move when the input appears.

All colors are taken from the input and default state variables of
the backend, which also covers the dark mode. The variables set from
outside of the element are removed, all styling now lives in the
element itself.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 811

  1. Ayke Halder uploaded patch set 1 12/30/25, 18:50

  2. Ayke Halder updated the commit message in patch set 2 12/30/25, 18:57

  3. core-ci voted on patch set 1 V +1 12/30/25, 18:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92817

  4. core-ci voted on patch set 2 V +1 12/30/25, 19:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92818

  5. Benni Mack uploaded patch set 3 V +1 11/11/26, 11:15

  6. Benni Mack commented on patch set 3 11/11/26, 11:22

    Hi Ayke, I took the liberty of reworking your patch because: In the meantime main changed this element quite a bit: #109525 now keeps the <h1> in place and overlays the edit form (for narrow areas like the language comparison view), #109017 already added the cursor placement and returns the focus to the edit icon, and #108865 raised the icon opacity. A plain rebase would have reverted those, so I reworked your idea on top of the overlay in PS3: - The edit icon is placed directly after the title, and long titles still truncate with an ellipsis. - Edit mode looks like a real input with proper save/close buttons. All colors come from the --typo3-input-* / --typo3-state-default-* variables, so dark mode works too. - The overlay is offset by the input padding, so the title text doesn't move when editing starts, and the element keeps its size in both modes. - The variables previously set from outside in the SCSS are gone, all styling now lives in the component. I checked it in Chromium and Firefox, light and dark, in the page and records modules, and with long titles in a narrow width. I kept you as author. It would be great if you could have a look and test it!
  7. core-ci voted on patch set 3 V +1 11/11/26, 11:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114061

  8. Georg Ringer voted on patch set 3 CR +1 V +1 11/13/26, 15:31

  9. Simon Schaufelberger voted on patch set 3 CR +1 V +1 11/14/26, 20:39

  10. Benni Mack voted on patch set 3 CR +2 V +2 11/19/26, 10:40

  11. Benni Mack merged patch set 4 11/19/26, 10:40