92238[TASK] Properly parse prioritized countries with a data attribute
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Georg Ringer +1
-
Verified V +2 Done
- Garvin Hicking +2
- Georg Ringer +1
- core-ci +1 CI
Issues 1
Files 2
Review log 2229
Show 4 earlier messages
-
core-ci voted on patch set 1 V -1 12/31/25, 21:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92850
-
core-ci voted on patch set 2 V -1 12/31/25, 21:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92851
-
core-ci voted on patch set 3 V -1 12/31/25, 21:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92852
-
Josef Glatz marked it work in progress 01/01/26, 06:37
-
Josef Glatz uploaded patch set 4
V -101/01/26, 12:51 -
core-ci voted on patch set 4 V +1 01/01/26, 12:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92871
-
Josef Glatz commented on patch set 4 01/01/26, 13:00
This change is ready for review. -
Oliver Klee updated the commit message in patch set 5
V +101/01/26, 13:15 -
core-ci voted on patch set 5 V +1 01/01/26, 13:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92873
-
Simon Schaufelberger updated the commit message in patch set 6
V +101/01/26, 13:57 -
Simon Schaufelberger uploaded patch set 7 01/01/26, 14:00
-
core-ci voted on patch set 7 V +1 01/01/26, 14:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92875
-
Simon Schaufelberger voted on patch set 7 CR +1 V +1 01/01/26, 15:56
-
Josua Vogel voted on patch set 7 CR +1 V +1 01/06/26, 16:01
-
Georg Ringer voted on patch set 7 CR +1 V +1 01/06/26, 18:57
-
Garvin Hicking voted on patch set 7 CR +1 V +1 01/07/26, 08:59
-
Andreas Kienast commented on patch set 7 01/07/26, 09:45
I understand your intent, but I'm rather reluctant to promote this kind of use-case. The main reason is Safari, which has poor to none support for styling of `option` tags. -
Garvin Hicking commented on patch set 7 01/07/26, 09:54
Reply
Since this only occurs here in the commit message, maybe that's more an issue of the VH's (external) documentation later on? There, we could either attach a disclaimer, or we could hint at a JS use case that adds "[prioritized]" or something like that to the option title (not the value). Or reworks the DOM to introduce optgroups (prioritized, non-prioritized). -
Josef Glatz commented on patch set 7 01/08/26, 21:08
Reply
I can delete the example. I know that there might be troubles. From my POV we can only provide a data attribute that some frontend magic can do whatever it needs. -
Garvin Hicking updated the commit message in patch set 8
CR +1V +101/09/26, 07:19 -
Garvin Hicking commented on patch set 8 CR +1 V +1 01/09/26, 07:19
Reply
Done -
core-ci voted on patch set 8 V +1 01/09/26, 07:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93136
-
Georg Ringer voted on patch set 8 CR +1 V +1 01/09/26, 08:38
-
Garvin Hicking voted on patch set 8 CR +2 V +2 01/09/26, 08:59
-
Garvin Hicking merged patch set 9 01/09/26, 09:41