Review main Merged

92238[TASK] Properly parse prioritized countries with a data attribute

Josef Glatz CR +2 V +2 Easy +6 −1 updated 01/09/26, 09:41

Commit message

The implementation of prioritized countries (rendering of prioritized
countries at first in the select) does not differentiate them from
non-prioritized countries. This patch changes this by adding a data
attribute `data-prioritized="1"` on the option HTML element.

This allows to apply modifications (like JavaScript DOM manipulation or
limited CCS scaling depending on browser capabilities).

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 2229

Show 4 earlier messages
  1. Josef Glatz uploaded patch set 1 12/31/25, 21:23

  2. Josef Glatz rebased onto patch set 2 12/31/25, 21:24

  3. Josef Glatz commented on patch set 2 12/31/25, 21:27

    This change is ready for review.
  4. Josef Glatz updated the commit message in patch set 3 12/31/25, 21:29

  1. core-ci voted on patch set 1 V -1 12/31/25, 21:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92850

  2. core-ci voted on patch set 2 V -1 12/31/25, 21:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92851

  3. core-ci voted on patch set 3 V -1 12/31/25, 21:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92852

  4. Josef Glatz marked it work in progress 01/01/26, 06:37

  5. Josef Glatz uploaded patch set 4 V -1 01/01/26, 12:51

  6. core-ci voted on patch set 4 V +1 01/01/26, 12:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92871

  7. Josef Glatz commented on patch set 4 01/01/26, 13:00

    This change is ready for review.
  8. Oliver Klee updated the commit message in patch set 5 V +1 01/01/26, 13:15

  9. core-ci voted on patch set 5 V +1 01/01/26, 13:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92873

  10. Simon Schaufelberger updated the commit message in patch set 6 V +1 01/01/26, 13:57

  11. Simon Schaufelberger uploaded patch set 7 01/01/26, 14:00

  12. core-ci voted on patch set 7 V +1 01/01/26, 14:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92875

  13. Simon Schaufelberger voted on patch set 7 CR +1 V +1 01/01/26, 15:56

  14. Josua Vogel voted on patch set 7 CR +1 V +1 01/06/26, 16:01

  15. Georg Ringer voted on patch set 7 CR +1 V +1 01/06/26, 18:57

  16. Garvin Hicking voted on patch set 7 CR +1 V +1 01/07/26, 08:59

  17. Andreas Kienast commented on patch set 7 01/07/26, 09:45

    I understand your intent, but I'm rather reluctant to promote this kind of use-case. The main reason is Safari, which has poor to none support for styling of `option` tags.
  18. Garvin Hicking commented on patch set 7 01/07/26, 09:54

    Reply

    Since this only occurs here in the commit message, maybe that's more an issue of the VH's (external) documentation later on? There, we could either attach a disclaimer, or we could hint at a JS use case that adds "[prioritized]" or something like that to the option title (not the value). Or reworks the DOM to introduce optgroups (prioritized, non-prioritized).
  19. Josef Glatz commented on patch set 7 01/08/26, 21:08

    Reply

    I can delete the example. I know that there might be troubles. From my POV we can only provide a data attribute that some frontend magic can do whatever it needs.
  20. Garvin Hicking updated the commit message in patch set 8 CR +1 V +1 01/09/26, 07:19

  21. Garvin Hicking commented on patch set 8 CR +1 V +1 01/09/26, 07:19

    Reply

    Done
  22. core-ci voted on patch set 8 V +1 01/09/26, 07:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93136

  23. Georg Ringer voted on patch set 8 CR +1 V +1 01/09/26, 08:38

  24. Garvin Hicking voted on patch set 8 CR +2 V +2 01/09/26, 08:59

  25. Garvin Hicking merged patch set 9 01/09/26, 09:41