Review main Merged

92239[BUGFIX] Fix undefined array key warning in language menu processing

Himanshu Nitsan CR +2 V +2 Easy +4 −0 updated 01/04/26, 20:54

Commit message

When processing language menu items with manually specified language IDs
that don't exist in the site configuration, the code attempted to access
`$languages[$sUid]` without checking if the key exists, causing a PHP
warning.

This fix adds an `isset()` check before accessing the language array to
gracefully skip invalid language IDs instead of throwing a warning.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Josef Glatz +1
    • Oliver Klee +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Josef Glatz +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1013

  1. Himanshu Nitsan uploaded patch set 1 01/01/26, 11:32

  2. core-ci voted on patch set 1 V +1 01/01/26, 11:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92870

  3. Himanshu Nitsan voted on patch set 1 CR +1 V +1 01/01/26, 11:43

  4. Oliver Klee updated the commit message in patch set 2 CR +1 V +1 01/01/26, 13:15

  5. core-ci voted on patch set 2 V +1 01/01/26, 13:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92872

  6. Simon Schaufelberger voted on patch set 2 CR +1 V +1 01/01/26, 17:26

  7. Josef Glatz updated the commit message in patch set 3 CR +1 V +1 01/02/26, 19:45

  8. Josef Glatz voted on patch set 3 CR +1 V +1 01/02/26, 19:45

  9. core-ci voted on patch set 3 V +1 01/02/26, 19:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92894

  10. Simon Schaufelberger voted on patch set 3 CR +1 V +1 01/03/26, 08:11

  11. Oliver Klee voted on patch set 3 CR +1 01/04/26, 09:15

  12. Benni Mack voted on patch set 3 CR +2 V +2 01/04/26, 20:54

  13. Benni Mack merged patch set 4 01/04/26, 20:54