92241[FEATURE] Introduce database storage for form extension
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Sven Liebert +1
-
Verified V +2 Done
- Garvin Hicking +2
- Sven Liebert +1
- core-ci +1 CI
Issues 1
Files 51
- Build/Sources/TypeScript/form/backend/form-wizard/finisher/create-form-submission-service.ts+2 −1
- Build/Sources/TypeScript/form/backend/form-wizard/finisher/duplicate-form-submission-service.ts+2 −1
- Build/Sources/TypeScript/form/backend/form-wizard/steps/settings-step.ts+31 −16
- Build/Sources/TypeScript/form/backend/form-wizard/steps/storage-step.tsnew+128 −0
- Build/Sources/TypeScript/form/backend/form-wizard/form-wizard.ts+6 −4
- Build/Sources/TypeScript/form/backend/form-manager.ts+26 −9
- typo3/sysext/core/Documentation/Changelog/14.2/Deprecation-108653-FormFileBasedStorageAdapter.rst10new+146 −0
- typo3/sysext/core/Documentation/Changelog/14.2/Feature-108653-DatabaseStorageForFormExtension.rst22new+166 −0
- typo3/sysext/form/Classes/Command/TransferFormDefinitionCommand.php4new+289 −0
- typo3/sysext/form/Classes/Controller/FormEditorController.php2+8 −8
- typo3/sysext/form/Classes/Controller/FormManagerController.php2+61 −63
- typo3/sysext/form/Classes/Domain/Configuration/PersistenceConfigurationService.php7+27 −40
- typo3/sysext/form/Classes/Domain/DTO/FormMetadata.php+18 −1
- typo3/sysext/form/Classes/Domain/DTO/StorageContext.phpnew+36 −0
- typo3/sysext/form/Classes/Domain/Repository/FormDefinitionRepository.phpnew+282 −0
- typo3/sysext/form/Classes/EventListener/ModifyFormDefinitionRecordActionsEventListener.phpnew+76 −0
- typo3/sysext/form/Classes/EventListener/ModifyFormDefinitionRecordListRowEventListener.phpnew+68 −0
- typo3/sysext/form/Classes/Hooks/FormPagePreviewRenderer.php+2 −21
- typo3/sysext/form/Classes/Mvc/Persistence/FormPersistenceManager.php11+65 −87
- typo3/sysext/form/Classes/Mvc/Persistence/FormPersistenceManagerInterface.php6+21 −22
Show 31 more files
- typo3/sysext/form/Classes/Service/DatabaseService.php1+40 −6
- typo3/sysext/form/Classes/Service/FormTransferResult.phpnew+40 −0
- typo3/sysext/form/Classes/Service/FormTransferService.php1new+330 −0
- typo3/sysext/form/Classes/SoftReference/FormPersistenceIdentifierSoftReferenceParser.php2+29 −0
- typo3/sysext/form/Classes/Storage/Permission/DatabasePermissionChecker.phpnew+131 −0
- typo3/sysext/form/Classes/Storage/AbstractFileStorageAdapter.php+16 −52
- typo3/sysext/form/Classes/Storage/DatabaseStorageAdapter.php8new+333 −0
- typo3/sysext/form/Classes/Storage/ExtensionStorageAdapter.php+89 −35
- typo3/sysext/form/Classes/Storage/FileMountStorageAdapter.php+114 −33
- typo3/sysext/form/Classes/Storage/StorageAdapterInterface.php10+82 −2
- typo3/sysext/form/Classes/Upgrades/FileFormsToDatabaseUpgradeWizard.php22new+270 −0
- typo3/sysext/form/Configuration/TCA/form_definition.php11new+58 −0
- typo3/sysext/form/Configuration/page.tsconfignew+4 −0
- typo3/sysext/form/Resources/Private/Language/Database.xlf18+27 −3
- typo3/sysext/form/Resources/Private/Language/locallang_db.xlfnew+20 −0
- typo3/sysext/form/Resources/Private/Language/locallang_formManager_javascript.xlf2+21 −3
- typo3/sysext/form/Resources/Private/Templates/Backend/FormManager/Index.fluid.html6+45 −24
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-wizard/finisher/create-form-submission-service.js+1 −1
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-wizard/finisher/duplicate-form-submission-service.js+1 −1
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-wizard/steps/settings-step.js+1 −1
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-wizard/steps/storage-step.jsnew+13 −0
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-wizard/form-wizard.js+1 −1
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-manager.js+1 −1
- typo3/sysext/form/Tests/Functional/Controller/Fixtures/DatabaseImports/form_definition.csvnew+3 −0
- typo3/sysext/form/Tests/Functional/Controller/FormEditorControllerTest.php3+5 −5
- typo3/sysext/form/Tests/Functional/Controller/FormManagerControllerTest.php+44 −96
- typo3/sysext/form/Tests/Functional/Mvc/Persistence/Fixtures/DatabaseImports/form_definition.csvnew+3 −0
- typo3/sysext/form/Tests/Functional/Mvc/Persistence/FormPersistenceManagerTest.php+33 −0
- typo3/sysext/form/Tests/Functional/RequestHandling/RequestHandlingTest.php+2 −0
- typo3/sysext/impexp/Tests/Functional/Export/PagesAndTtContentWithRelationsAndSoftrefsTest.php+2 −0
- typo3/sysext/impexp/Tests/Functional/Import/PagesAndTtContentWithImagesInFilledDatabaseTest.php+4 −0
Review log 100152
Show 80127 earlier messages
-
Josua Vogel uploaded patch set 1 01/02/26, 15:32
-
core-ci voted on patch set 1 V -1 01/02/26, 15:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92889
-
Josua Vogel uploaded patch set 2
V -101/08/26, 17:51 -
core-ci voted on patch set 2 V -1 01/08/26, 18:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93108
-
Josua Vogel uploaded patch set 3
V -101/09/26, 07:54 -
core-ci voted on patch set 3 V -1 01/09/26, 08:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93138
-
Josua Vogel uploaded patch set 4
V -101/10/26, 12:55 -
core-ci voted on patch set 4 V -1 01/10/26, 13:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93205
-
Josua Vogel uploaded patch set 5
V -101/10/26, 13:24 -
Josua Vogel uploaded patch set 6 01/10/26, 13:34
-
core-ci voted on patch set 5 V -1 01/10/26, 13:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93206
-
core-ci voted on patch set 6 V -1 01/10/26, 13:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93207
-
Josua Vogel uploaded patch set 7
V -101/12/26, 15:08 -
core-ci voted on patch set 7 V -1 01/12/26, 15:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93276
-
Josua Vogel uploaded patch set 8
V -101/15/26, 16:29 -
core-ci voted on patch set 8 V -1 01/15/26, 16:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93531
-
Josua Vogel uploaded patch set 9
V -101/15/26, 17:05 -
core-ci voted on patch set 9 V -1 01/15/26, 17:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93532
-
Josua Vogel uploaded patch set 10
V -101/16/26, 10:09 -
core-ci voted on patch set 10 V -1 01/16/26, 10:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93579
-
Josua Vogel uploaded patch set 11
V -101/16/26, 10:58 -
core-ci voted on patch set 11 V -1 01/16/26, 11:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93587
-
Josua Vogel uploaded patch set 12
V -101/16/26, 11:23 -
core-ci voted on patch set 12 V -1 01/16/26, 11:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93588
-
Josua Vogel uploaded patch set 13
V -101/16/26, 11:39 -
Josua Vogel uploaded patch set 14 01/16/26, 11:40
-
core-ci voted on patch set 13 V +1 01/16/26, 11:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93590
-
core-ci voted on patch set 14 V +1 01/16/26, 11:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93591
-
Josua Vogel uploaded patch set 15
V +101/16/26, 15:23 -
core-ci voted on patch set 15 V +1 01/16/26, 15:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93614
-
Garvin Hicking commented on patch set 15 01/17/26, 10:58
-
Garvin Hicking commented on patch set 15 01/17/26, 10:59
Index.fluid.html:95maybe name this "persistenceLocation", "storageLocation" or something more explicit? Also helps in search later on, and not be confused with geo-locations ;) -
Josua Vogel uploaded patch set 16
V +101/17/26, 16:22 -
Josua Vogel commented on patch set 16 01/17/26, 16:23
FormPersistenceIdentifierSoftReferenceParser.php:48ReplyDoneIndex.fluid.html:95ReplyDone -
core-ci voted on patch set 16 V -1 01/17/26, 16:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93683
-
Josua Vogel uploaded patch set 17
V -101/17/26, 16:36 -
core-ci voted on patch set 17 V +1 01/17/26, 16:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93684
-
Josua Vogel uploaded patch set 18
V +101/18/26, 15:11 -
core-ci voted on patch set 18 V +1 01/18/26, 15:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93719
-
Simon Schaufelberger commented on patch set 18 01/18/26, 23:34
Database.xlf:1311please remove xml:space="preserve" in all new labelslocallang_tca.xlf:6please remove xml:space="preserve" in all new labels and format the file correcty -
Josua Vogel rebased onto patch set 19
V +101/22/26, 13:00 -
core-ci voted on patch set 19 V +1 01/22/26, 13:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94032
-
Josua Vogel uploaded patch set 20
V +101/22/26, 13:27 -
Josua Vogel commented on patch set 20 01/22/26, 13:29
Database.xlf:1311ReplyDonelocallang_tca.xlf:6ReplyDone -
core-ci voted on patch set 20 V -1 01/22/26, 13:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94034
-
Josua Vogel uploaded patch set 21
V -101/22/26, 13:56 -
core-ci voted on patch set 21 V -1 01/22/26, 14:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94035
-
Josua Vogel uploaded patch set 22
V -101/22/26, 15:06 -
Josua Vogel uploaded patch set 23 01/22/26, 15:16
-
core-ci voted on patch set 22 V -1 01/22/26, 15:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94046
-
core-ci voted on patch set 23 V -1 01/22/26, 15:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94049
-
Josua Vogel uploaded patch set 24
V -101/22/26, 15:31 -
Josua Vogel uploaded patch set 25 01/22/26, 15:40
-
core-ci voted on patch set 24 V -1 01/22/26, 15:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94052
-
core-ci voted on patch set 25 V +1 01/22/26, 15:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94056
-
Josua Vogel uploaded patch set 26
V +101/22/26, 17:38 -
Josua Vogel uploaded patch set 27 01/22/26, 17:48
-
core-ci voted on patch set 26 V -1 01/22/26, 17:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94072
-
core-ci voted on patch set 27 V +1 01/22/26, 17:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94073
-
Josua Vogel uploaded patch set 28
V +101/23/26, 07:08 -
core-ci voted on patch set 28 V +1 01/23/26, 07:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94129
-
Sven Liebert voted on patch set 28 CR +1 V +1 01/27/26, 14:48
-
Georg Ringer commented on patch set 28 CR -1 02/06/26, 19:08
PersistenceConfigurationService.php:109I haven't checked but does it also limit by user permissions? so editors with webmount to site A must not see form pages of Site Bpages.php:7use new syntaxform_definition.php:4we don't have doc header in tcaform_definition.php:18use new syntax, also belowform_definition.php:41IMO the exclude should be removed. either an editor got access to the table or not. there is no usecase where the editor should see only parts - and it is more work to setup -
Benni Mack uploaded patch set 29
CR +1V +102/21/26, 18:07 -
core-ci voted on patch set 29 V +1 02/21/26, 18:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96464
-
Josua Vogel commented on patch set 29 02/22/26, 14:29
PersistenceConfigurationService.php:109ReplyYes, this check takes place in the DatabaseStorageAdapter. -
Josua Vogel commented on patch set 29 02/23/26, 20:05
After the new wizard has been merged, the code must be adjusted here. I'm already working on it. -
Josua Vogel uploaded patch set 30
V +102/24/26, 12:41 -
Josua Vogel commented on patch set 30 02/24/26, 12:41
pages.php:7ReplyDoneform_definition.php:4ReplyDoneform_definition.php:18ReplyDoneform_definition.php:41ReplyDone -
Josua Vogel uploaded patch set 31 02/24/26, 12:50
-
core-ci voted on patch set 30 V +1 02/24/26, 12:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96729
-
core-ci voted on patch set 31 V +1 02/24/26, 13:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96730
-
Josua Vogel uploaded patch set 32
V +102/24/26, 13:49 -
Josua Vogel uploaded patch set 33 02/24/26, 14:43
-
core-ci voted on patch set 32 V -1 02/24/26, 15:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96744
-
core-ci voted on patch set 33 V +1 02/24/26, 15:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96752
-
Josua Vogel uploaded patch set 34
V +103/09/26, 18:46 -
core-ci voted on patch set 34 V +1 03/09/26, 18:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97617
-
Josua Vogel uploaded patch set 35
V +103/10/26, 10:49 -
core-ci voted on patch set 35 V -1 03/10/26, 11:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97678
-
Josua Vogel uploaded patch set 36
V -103/10/26, 11:48 -
core-ci voted on patch set 36 V -1 03/10/26, 12:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97683
-
Garvin Hicking commented on patch set 36 V +1 03/14/26, 23:35
On the editor's side, this seems to "just work" quite well. Huge kudos (once again), this one is a beast and will open up so many opportunities. It would be nice for the "Form" plugin itself to open the record browser to pick a record from that popup, and not to browse that giant select dropdown in the flexform. Maybe that can be a later task, but it would greatly improve the editor's UX there. Also it would be nice from the GUI editing form interface to jump to the recordlist of the PID, that the form holds. And to access the record history from there?Deprecation-108653-FormFileBasedStorageAdapter.rst:48"Note: YAML form files provided within extension directories still work as before." ?FormEditorController.php:104Can we do this somehow without creating a state variable for the controller? Pass returnUrl as part of request? (not sure what happens here exactly)FormManagerController.php:498redundant params phpdocPersistenceConfigurationService.php:141(could be part of the service that the upgrade wizard uses too)FormPersistenceManager.php:94(see note in the interface, maybe we can do without a BC here)FormPersistenceManagerInterface.php:58I know this is internal, but I see a few extensions utilizing the interface. Could we instead add the storageLocation as a fourth argument and leave array $formSettings untouched? Same with the other signature changes below.DatabaseStorageAdapter.php:54Is there a chance that "int" could be supplied here? Should we allow string|int?DatabaseStorageAdapter.php:340I wonder if we should apply the concept of "Voters" here like typo3/sysext/core/Classes/Domain/Access/RecordAccessVoter.php - the ACL check logic feels as if it should not all be contained here inside the adapter...? IMO the scope of this class is a bit too godlike.StorageAdapterInterface.php:60This is not a translation key?StorageAdapterInterface.php:85can we specify an array shape here (e.g. array depth levels or so?) Otherwise, this return statement is too redundant and sounds AI-generated ;)StorageAdapterInterface.php:92redundant return annotationStorageAdapterInterface.php:121these first two @param notations are redundant and IMO the current description doesn't add valueFileFormsToDatabaseUpgradeWizard.php:86```suggestion 'Found %d file-based form definition(s) that will be moved to database storage:', ``` I think we need to emphasize that files will be removed.FileFormsToDatabaseUpgradeWizard.php:99```suggestion $description .= LF . 'The original YAML files WILL BE DELETED after successful migration. Please ensure backups exist. Failures will be logged and can be found in their configured log locations after execution, and should be reviewed. '; ``` I get a bit sweaty when migration wizards remove my files, so I'd like to be really clear here also, not just in the confirmation prompt. :)FileFormsToDatabaseUpgradeWizard.php:108```suggestion 'This will move all filemount-based form definitions into the database (using a custom SysFolder on pid=0 level) ' ```FileFormsToDatabaseUpgradeWizard.php:110```suggestion . 'The original YAML files will be deleted after successful migration. YAML files in extension directories are not affected. ' ```FileFormsToDatabaseUpgradeWizard.php:226I would like this wizard logic to also be a Symfony Command that I can easily run on specified directories or later data migrations. Ideally allowing an option for "no-remove-files" and "no-adapt-tt-content" and the pid source. This would be done in a service, and the service can be called in both the CLI and this wizard. Do you think that is possible within this patch? We might be able to do this with a follow-up, but if possible I'd like to have it in the initial patch.FileFormsToDatabaseUpgradeWizard.php:336```suggestion if (empty($yamlContent['identifier'] ?? '') || empty($yamlContent['type'] ?? '')) { ```FileFormsToDatabaseUpgradeWizard.php:464How about using "(auto-created)" here like fileadmin initialisation? So people know they might want to rename it.FileFormsToDatabaseUpgradeWizard.php:541What about references in custom database tables / flexforms outside tt_content? (That's where a CLI-based migration could help) The wizard should also note about that maybe not all references can be updated (which could result in broken records after moving?)FileFormsToDatabaseUpgradeWizard.php:574I have a bad feeling about this and wonder if it could be too broad for extensions that may have adapted the pi_flexform ds, and used identifiers that might be so generic that they occur in multiple places. I think we MUST specifically restrict this to `<field index="settings.persistenceIdentifier">` XML contents only. Probably, actually do XML DOM parsing here and not naive regexps.Icons.php:3(see below, I think this should not be custom-provided but use a core icon)form_definition.php:5I would prefer the tablename to be "tx_form_definition" to better indicate its relation to an extension (like tx_scheduler_..., tx_impexp_presets, tx_linkvalidator_link).Database.xlf:193I think we need a new identifier for this. Otherwise when the german translation is updated, "Folder" will show up in earlier TYPO3 versions too (label translations are fetched version-agnostic). Same for "formManager.headline" - the "old" terminology is part of handbooks and training data and we should not break that.Database.xlf:211Sounds a bit clunky. How about just "No forms exist" or "Empty storage" / "Empty folder"?Database.xlf:214```suggestion <source>Once created, forms will be displayed here.</source> ``` Something like this, "create your first form" sounds a bit like a tutorial would be embedded here.Database.xlf:1432```suggestion <source>Page (database)</source> ``` This might help to understand more of the impact.Database.xlf:1440I think this should be streamlined and also read "Database (Page)" then to correlate to formManager.sotrageLocation.database? It feels a bit like unclear terminology.Database.xlf:1444```suggestion <source>Store the form as a page-record in the database. Recommended for most use cases, because it treats forms as user-generated content and allows integrated versioning and permission management.</source> ```Database.xlf:1450```suggestion <source>Store the form as a YAML file inside "fileadmin". This option will be removed in a future TYPO3 version. Use "Database" instead. Files can still be provided within extensions.</source> ```Database.xlf:1456```suggestion <source>Store the form inside an extension. Such forms are then not meant for editing, but provided as-is.</source> ```locallang_formManager_javascript.xlf:88"Storage location"?Index.fluid.html:82please use new language domain syntax hereIndex.fluid.html:205and hererecord-folder-contains-form.svgLet's not add distinct icons for this, but make use of existing TYPO3 Iconsets. Maybe one of these would fit: apps-pagetree-folder-contains-board apps-pagetree-folder-contains-shop apps-filetree-folder-list files-folder-content This would have the better option to go with new backend themes and dark/light mode improvements. -
Garvin Hicking commented on patch set 36 03/15/26, 00:16
FileFormsToDatabaseUpgradeWizard.php:101How about a notice like "Forms will all be imported into a central sysfolder. You may want to divert them to dedicated different sysfolders, and also adjust editor permissions to match prior storage locations. Otherwise, forms may no longer be editable by the same editors like before." (I might have gotten this wrong though, so feedback appreciated) -
Josua Vogel marked it work in progress 03/16/26, 19:47
-
Josua Vogel uploaded patch set 37
V +103/17/26, 08:57 -
Josua Vogel commented on patch set 37 03/17/26, 08:59
Deprecation-108653-FormFileBasedStorageAdapter.rst:48ReplyDoneFormManagerController.php:498ReplyDonePersistenceConfigurationService.php:141ReplyDoneDatabase.xlf:193ReplyDoneDatabase.xlf:211ReplyDoneDatabase.xlf:214ReplyDoneDatabase.xlf:1432ReplyDoneDatabase.xlf:1444ReplyDoneDatabase.xlf:1450ReplyDoneDatabase.xlf:1456ReplyDonelocallang_formManager_javascript.xlf:88ReplyDone -
Josua Vogel commented on patch set 37 03/17/26, 09:01
Reply
AcknowledgedFileFormsToDatabaseUpgradeWizard.php:86ReplyFix applied.FileFormsToDatabaseUpgradeWizard.php:99ReplyFix applied.FileFormsToDatabaseUpgradeWizard.php:110ReplyFix applied.FileFormsToDatabaseUpgradeWizard.php:336ReplyFix applied.FileFormsToDatabaseUpgradeWizard.php:464ReplyDonerecord-folder-contains-form.svgReplyDone -
Josua Vogel commented on patch set 38 03/17/26, 09:01
Published edit on patch set 37. -
core-ci voted on patch set 37 V -1 03/17/26, 09:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98078
-
core-ci voted on patch set 38 V -1 03/17/26, 09:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98079
-
Josua Vogel uploaded patch set 39
V -103/17/26, 10:15 -
core-ci voted on patch set 39 V -1 03/17/26, 10:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98082
-
Simon Schaufelberger wrote 03/17/26, 10:59
Removed cc Simon Schaufelberger. -
Josua Vogel uploaded patch set 40
V -103/17/26, 12:58 -
core-ci voted on patch set 40 V -1 03/17/26, 13:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98091
-
Josua Vogel commented on patch set 40 03/17/26, 13:42
FormPersistenceManager.php:94ReplyIMO that´s not breaking, bc it´s internalFormPersistenceManagerInterface.php:58Replyidk, I'd like to clean it upDatabaseStorageAdapter.php:54ReplyNot in the ext:form code. And if anyone uses the method, they should use it accordingly. :) I think it's better to define the types very strictly.DatabaseStorageAdapter.php:340ReplyMovedStorageAdapterInterface.php:60ReplyDoneStorageAdapterInterface.php:85Replyhm I wouldn´t define any array shape, it´s flexible 😊StorageAdapterInterface.php:92ReplyDoneStorageAdapterInterface.php:121ReplyDoneFileFormsToDatabaseUpgradeWizard.php:574ReplyDoneform_definition.php:5Replysys_redirect doesn't have a prefix either. Is there a rule for this?Database.xlf:1440ReplyAcknowledgedIndex.fluid.html:82ReplyDoneIndex.fluid.html:205ReplyDone -
Josua Vogel commented on patch set 40 03/17/26, 13:45
DatabaseStorageAdapter.php:340ReplyDone -
Garvin Hicking commented on patch set 40 03/17/26, 13:53
FormPersistenceManager.php:94ReplyResolving this one in favor of the comment below: https://review.typo3.org/c/Packages/TYPO3.CMS/+/92241/comment/18a429fa_23e8e7a8/FormPersistenceManagerInterface.php:58ReplyLets do this cleanup in following steps and keep the arguments for now. Shouldn't matter in terms of functionality, and may allow us more breathing room, and less readons for third parties to complain and follow along with the improvements.DatabaseStorageAdapter.php:54ReplyI'm thinking about PHPs internal "these are all numbers in your shiny areay keys, its an int" possibilitiesStorageAdapterInterface.php:85ReplyAlright then just drop redundancy declarationform_definition.php:5ReplyIt does, it's "sys_", like the others. IMO it would prevent clutter in the DB by having clear relations and existing patterns like tx_. -
Josua Vogel uploaded patch set 41
V -103/17/26, 15:13 -
Josua Vogel marked it ready for review 03/17/26, 15:13
-
core-ci voted on patch set 41 V -1 03/17/26, 15:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98098
-
Josua Vogel uploaded patch set 42
V -103/17/26, 15:35 -
Josua Vogel commented on patch set 42 03/17/26, 15:35
FileFormsToDatabaseUpgradeWizard.php:101ReplyDoneFileFormsToDatabaseUpgradeWizard.php:108ReplyDoneFileFormsToDatabaseUpgradeWizard.php:226ReplyDone -
Benni Mack commented on patch set 42 03/17/26, 15:39
form_definition.php:5ReplyI was in favor of "form_definition" - form_ is a good prefix that isn't cluttered. And it shows, that's it's not a "regular extension". -
Garvin Hicking commented on patch set 42 03/17/26, 16:03
form_definition.php:5ReplyUnderstood. -
Josua Vogel commented on patch set 42 03/17/26, 16:07
FormEditorController.php:104ReplyDoneFileFormsToDatabaseUpgradeWizard.php:541ReplyI think such references are very custom :) idk if we can update those references in a good way. Maybe just adding a hint?Icons.php:3ReplyDone -
Garvin Hicking commented on patch set 42 03/17/26, 16:13
FileFormsToDatabaseUpgradeWizard.php:541ReplyMaybe something like the Abstract Ctype migration wizards that ects can opt in. Or we could iterate the schema api and check any schemas that contain flexforms and then check form these fields. Having said that; this is beyond the scope of this first patch that we discussed in the working group. I would say let's document this in the wizard as a caveat like "permissions", where you have to continue using the FAL way for now if needed, or how a custom migration can be done. -
core-ci voted on patch set 42 V -1 03/17/26, 16:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98099
-
Garvin Hicking commented on patch set 42 03/17/26, 16:47
Deprecation-108653-FormFileBasedStorageAdapter.rst:31```suggestion An upgrade wizard as well as a CLI command is available to migrate existing file-based form definitions ```Deprecation-108653-FormFileBasedStorageAdapter.rst:39```suggestion and are not affected by this deprecation until further concepts are evaluated. ```Deprecation-108653-FormFileBasedStorageAdapter.rst:81this sounds fair to me!Deprecation-108653-FormFileBasedStorageAdapter.rst:97```suggestion possible :yaml:`allowedFileMounts` configuration from your YAML setup: ``` These are optional right? I think I've never used this.Feature-108653-DatabaseStorageForFormExtension.rst:70Page path is now no longer relevant with pid.=0?Feature-108653-DatabaseStorageForFormExtension.rst:97This is outdated now with pid=0?Feature-108653-DatabaseStorageForFormExtension.rst:107```suggestion migrating file-based forms to database storage from the command line. It can also be used not only one-time on upgrades, but also for continuously importing version-controlled data to the database in deployment contexts. ```Feature-108653-DatabaseStorageForFormExtension.rst:142Obsolete?Feature-108653-DatabaseStorageForFormExtension.rst:170```suggestion isolation) for database-stored forms is planned, but not yet implemented. ```Feature-108653-DatabaseStorageForFormExtension.rst:179Its root level so also does not apply any more, right?Feature-108653-DatabaseStorageForFormExtension.rst:186Adjust to pid=0Feature-108653-DatabaseStorageForFormExtension.rst:195```suggestion The extension-based storage continues to work unchanged, and future mechanisms for this will be evaluated. ```Feature-108653-DatabaseStorageForFormExtension.rst:197```suggestion The :sql:`pages` TCA now includes a new **Forms** option in the **Contains Plugin** ```Feature-108653-DatabaseStorageForFormExtension.rst:198Thats also gone with pid=0 right? -
Josua Vogel uploaded patch set 43
V -103/17/26, 16:54 -
Josua Vogel commented on patch set 42 03/17/26, 16:55
DatabaseStorageAdapter.php:54Replywell, the code will never provide an int. In addition it would mean to adapt the StorageAdapterInterface, change the methods of the other storage adapters, ... I think we shouldnt do thisStorageAdapterInterface.php:85ReplyDoneFileFormsToDatabaseUpgradeWizard.php:541ReplyDone -
Josua Vogel commented on patch set 43 03/17/26, 16:56
Deprecation-108653-FormFileBasedStorageAdapter.rst:31ReplyFix applied.Deprecation-108653-FormFileBasedStorageAdapter.rst:39ReplyFix applied.Feature-108653-DatabaseStorageForFormExtension.rst:107ReplyFix applied.Feature-108653-DatabaseStorageForFormExtension.rst:170ReplyFix applied.Feature-108653-DatabaseStorageForFormExtension.rst:195ReplyFix applied. -
Josua Vogel commented on patch set 44 03/17/26, 16:57
Published edit on patch set 43. -
Josua Vogel commented on patch set 44 03/17/26, 17:09
Deprecation-108653-FormFileBasedStorageAdapter.rst:97ReplypersistenceManager: allowedFileMounts: 10: '1:/form_definitions/' Is default, so in order to disable the file mount option, you need to set the allowedFileMounts to an empty value -
core-ci voted on patch set 44 V -1 03/17/26, 17:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98106
-
Josua Vogel commented on patch set 45
V -103/17/26, 17:13Published edit on patch set 44. -
Josua Vogel commented on patch set 45 03/17/26, 17:13
Feature-108653-DatabaseStorageForFormExtension.rst:70ReplyDoneFeature-108653-DatabaseStorageForFormExtension.rst:97ReplyDoneFeature-108653-DatabaseStorageForFormExtension.rst:142ReplyDoneFeature-108653-DatabaseStorageForFormExtension.rst:179ReplyDoneFeature-108653-DatabaseStorageForFormExtension.rst:186ReplyDoneFeature-108653-DatabaseStorageForFormExtension.rst:198ReplyDone -
Josua Vogel commented on patch set 46 03/17/26, 17:13
Published edit on patch set 45. -
Josua Vogel commented on patch set 46 03/17/26, 17:14
Feature-108653-DatabaseStorageForFormExtension.rst:197ReplyDone -
Josua Vogel commented on patch set 47 03/17/26, 17:16
Published edit on patch set 46. -
Garvin Hicking commented on patch set 47 03/17/26, 17:27
Deprecation-108653-FormFileBasedStorageAdapter.rst:97ReplyAh, I see, thanks!FormPersistenceManagerInterface.php:58ReplyMaybe @benni@typo3.org can chime in on this, I don't mean to pry if you feel it's alright.DatabaseStorageAdapter.php:54ReplyAll good then. It was an honest question if it could be relevant here. Case closed. -
core-ci voted on patch set 43 V -1 03/17/26, 17:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98105
-
core-ci voted on patch set 45 V -1 03/17/26, 17:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98107
-
core-ci voted on patch set 46 V -1 03/17/26, 17:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98108
-
core-ci voted on patch set 47 V -1 03/17/26, 17:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98109
-
Josua Vogel uploaded patch set 48
V -103/17/26, 18:13
-
core-ci voted on patch set 48 V -1 03/17/26, 18:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98110
-
Garvin Hicking commented on patch set 48 03/17/26, 18:29
FormPersistenceManagerInterface.php:58ReplyLet's take the safe road here, we clean it in a follow up step and keep the signature for now, is that ok with you Josua? -
Josua Vogel uploaded patch set 49
V -103/18/26, 06:45 -
Josua Vogel commented on patch set 49 03/18/26, 06:49
FormPersistenceManagerInterface.php:58ReplyDone -
core-ci voted on patch set 49 V +1 03/18/26, 06:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98136
-
Garvin Hicking commented on patch set 49 03/18/26, 08:12
FormEditorControllerTest.php:532If I read this right, we shouldn't replace these file-based tests just yet. Please add new ones for the DB-based ones so we can test both? Or am I maybe missing something? -
Josua Vogel commented on patch set 49 03/18/26, 08:19
FormEditorControllerTest.php:532ReplyI only made changes in the parts that involve triggering an event. In those cases, the storage type doesn't really matter, and this seemed like the most sustainable option to me. -
Garvin Hicking commented on patch set 49 03/18/26, 08:35
FormEditorControllerTest.php:532ReplyAh, now I see. Thanks for explaining. Fine by me! -
Garvin Hicking commented on patch set 49 03/20/26, 10:12
Using this: vendor/bin/typo3 form:formdefinition:transfer --target=database --source=filemount --form-identifier=persist-file --move my expectation would be to have a DB entry with identifier "persist-file", but in fact it uses "persist-file_1". This would only be expected by me without the "--move" command. If this is needed, the command should emit a warning that existing form-ctype plugins would need to be adapted to reference the new identifier. But I would prefer if you could make it so that the identifier stays identical when being moved. -
Garvin Hicking commented on patch set 49 03/20/26, 10:15
The CLI command description for "--target-location" including its error message needs adaption. The "1:/xxx" FAL option should not exist, the "pid" should not be configurable (only 0). Instead the "EXT:" notation could be added, it seems I can neither specify. ``` vendor/bin/typo3 form:formdefinition:transfer --target=extension --source=filemount --form-identifier=persist-file --move --target-location="my_extension" ``` nor ``` vendor/bin/typo3 form:formdefinition:transfer --target=extension --source=filemount --form-identifier=persist-file --move --target-location="EXT:my_extension/Configuration/Forms" vendor/bin/typo3 form:formdefinition:transfer --target=extension --source=filemount --form-identifier=persist-file --move --target-location="EXT:my_extension" ``` -
Josua Vogel uploaded patch set 50
V +103/20/26, 11:15 -
Josua Vogel commented on patch set 49 03/20/26, 11:17
Reply
Pls retryReply
Improved the description. Pls note: https://docs.typo3.org/c/typo3/cms-form/main/en-us/I/Config/persistenceManager/Index.html#persistencemanager-allowedextensionpaths and allowSaveToExtensionPaths: true IMO the FAL option can exists - in this way the transfer command is most generic. -
core-ci voted on patch set 50 V +1 03/20/26, 11:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98286
-
Garvin Hicking commented on patch set 50 V +1 03/20/26, 13:26
```suggestion - FormPersistenceManager is refactored to add the storage location to several internal public methods (save, delete, hasForms, getUniqueIdentifier). New methods isAllowedStorageLocation() and isAllowedPersistenceIdentifier() replace the former isAllowedPersistencePath(). The getAccessibleStorageAdapters() method provides storage metadata for the frontend. ```This is out for nowFeature-108653-DatabaseStorageForFormExtension.rst:52Can you replace all double backticks with a single backtick please, we try to avoid this older ReST-markup usageTransferFormDefinitionCommand.php:83If you like to go an extra mile here, setup auto-completion like in `SetupDefaultBackendUserGroupsCommand.php` (extra argument to `->addOption()`). That would help for `source`, `target` here. (You could even use the `->ask()` methodology when in interactive mode and guide the user through it, since this command has a few settings. But feel free to resolve this and we can do it in a future iteration)TransferFormDefinitionCommand.php:270Could we have a "skip-update-content-elements" or so option to be able to prevent this step? Also the help interface should IMO mention that "tt_content" is updated (and not any others). And maybe even we could allow the CLI to specify arguments: --content-element-db-table="tt_content" --content-element-db-ctype="CType" --content-element-db-flexform="pi_flexform" --content-element-ctype="form_framework" and adjust this method below to pass arbitrary custom content element storages to it. One could repeat these arguments then to migrate multiple tables with an InputOption::VALUE_IS_ARRAY: ``` typo3 form:formdefinition:transfer \ --content-element-db-table="tx_myextension_domain_model_form" \ --content-element-db-ctype="" \ --content-element-db-flexform="pi_flexform" \ --content-element-ctype="" \ \ --content-element-db-table="tx_myextension_domain_model_objects" \ --content-element-db-ctype="custom_type" \ --content-element-db-flexform="my_flexform" \ --content-element-ctype="my_custom_type" \ ``` This would make the migration quite powerful IMO. (This could be done in a follow-up, feel free to resolve too)PersistenceConfigurationService.php:166I know it's internal, but since we bear some things in mind here, could we leave the method(s) in here and add a removal for v15 only (no "official" deprecation becaues official).FormPersistenceManager.php:190Since we're keeping the other public signatures to not break this, can we keep these two here as well? Feel free to add a "@deprecated" notice here (even though it's not really deprecated because of internal), but then we won't forget to clean this up in v15?FormPersistenceManager.php:227Can you do this without being "breaking" for existing consumers too?FormPersistenceManager.php:256Same here, for the public method preferrable non-breaking for this signatureFormPersistenceManager.php:283Can we keep the old method as a stub?DatabaseService.php:168(I think we should be able to use constructor DI for this service, but other methods also do it like this)FormTransferService.php:308I must admit I'm thinking if utilizing FlexFormTools here is a safer bet. However constructing that monster is always a bit painful. So I'd argue we can leave this pragmatic approach in here.TransferResult.php:25Call this FormTransferResult for scoping? -
Josua Vogel updated the commit message in patch set 51
V +103/20/26, 16:45 -
Josua Vogel commented on patch set 51 03/20/26, 16:45
Reply
Fix applied.TransferFormDefinitionCommand.php:83ReplyAcknowledged. I resolve this, but keep this in mind 😊 -
core-ci voted on patch set 51 V -1 03/20/26, 16:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98312
-
Josua Vogel uploaded patch set 52
V -103/20/26, 17:00 -
Josua Vogel commented on patch set 51 03/20/26, 17:00
Reply
DoneFeature-108653-DatabaseStorageForFormExtension.rst:52ReplyDoneTransferFormDefinitionCommand.php:270ReplyDonePersistenceConfigurationService.php:166ReplyI don't think that's necessary; this class wasn't introduced until v14. It's very unlikely that anyone would use this methodTransferResult.php:25ReplyDone -
core-ci voted on patch set 52 V +1 03/20/26, 17:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98314
-
Garvin Hicking commented on patch set 52 CR +1 V +1 03/20/26, 20:07
PersistenceConfigurationService.php:166ReplyAcknowledgedFormPersistenceManager.php:190ReplyDoneFormPersistenceManager.php:227ReplyDoneFormPersistenceManager.php:256ReplyDoneFormPersistenceManager.php:283ReplyDone -
Sven Liebert commented on patch set 52 CR +1 V +1 03/20/26, 20:14
Love it :) -
Garvin Hicking commented on patch set 52 CR +2 V +2 03/20/26, 20:16
(I'm good to address possible remarks in a followup ir discard them. Great work IMO!) -
Garvin Hicking merged patch set 53 03/20/26, 20:16
FormPersistenceIdentifierSoftReferenceParser.php:48