92246[TASK] Streamline pagination in Media module
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Garvin Hicking +1
-
Verified V +2 Done
- Oli Bartsch +2
- Garvin Hicking +1
Issues 1
Files 9
- Build/Sources/TypeScript/filelist/file-list.ts+25 −0
- typo3/sysext/filelist/Classes/Dto/PaginationLink.phpdeleted+0 −29
- typo3/sysext/filelist/Classes/Type/NavigationDirection.phpdeleted+0 −27
- typo3/sysext/filelist/Classes/FileList.php+47 −91
- typo3/sysext/filelist/Resources/Private/Language/locallang_mod_file_list.xlf+3 −0
- typo3/sysext/filelist/Resources/Private/Partials/Pagination.fluid.html4new+51 −0
- typo3/sysext/filelist/Resources/Private/Templates/Filelist/List.fluid.html+16 −2
- typo3/sysext/filelist/Resources/Private/Templates/Filelist/Tiles.fluid.html+15 −36
- typo3/sysext/filelist/Resources/Public/JavaScript/file-list.js+1 −1
Review log 2736
Show 711 earlier messages
-
Simon Schaufelberger uploaded patch set 1 01/04/26, 21:00
-
Simon Schaufelberger uploaded patch set 2 01/04/26, 21:01
-
core-ci voted on patch set 1 V +1 01/04/26, 21:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92941
-
core-ci voted on patch set 2 V +1 01/04/26, 21:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92942
-
Simon Schaufelberger uploaded patch set 3
V +101/18/26, 22:00 -
Simon Schaufelberger uploaded patch set 4 01/18/26, 22:07
-
Simon Schaufelberger marked it ready for review 01/18/26, 22:07
-
Simon Schaufelberger updated the commit message in patch set 5 01/18/26, 22:08
-
core-ci voted on patch set 3 V -1 01/18/26, 22:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93733
-
core-ci voted on patch set 5 V +1 01/18/26, 22:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93735
-
Simon Schaufelberger uploaded patch set 6
V +101/18/26, 22:19
-
core-ci voted on patch set 6 V +1 01/18/26, 22:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93736
-
Simon Schaufelberger updated the commit message in patch set 7
V +101/18/26, 23:23 -
core-ci voted on patch set 7 V +1 01/18/26, 23:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93737
-
Juliane Wundermann voted on patch set 7 CR +1 V +1 02/04/26, 09:34
-
Oli Bartsch uploaded patch set 8
CR +1V +102/04/26, 16:08 -
Simon Schaufelberger voted on patch set 8 CR +1 V +1 02/04/26, 16:15
-
core-ci voted on patch set 8 V +1 02/04/26, 16:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95065
-
Oli Bartsch voted on patch set 8 CR +1 V +1 02/04/26, 16:20
-
Simon Schaufelberger commented on patch set 8 CR -1 02/04/26, 16:40
@bo@cedev.de Juliane meint, dass es jetzt inkonsistent ist, da in der Listenansicht die Paginierung auch oben ist. -
Oli Bartsch commented on patch set 8 02/04/26, 16:50
Reply
@simonschaufi+typo3@gmail.com and I think that actually records module is inconsitent in comparison to form, beuser, redirects, webhooks, reactions, etc. 🙃 -
Simon Schaufelberger commented on patch set 8 CR +1 02/04/26, 16:54
Reply
Done -
Juliane Wundermann voted on patch set 8 CR +1 V +1 02/04/26, 16:55
-
Garvin Hicking commented on patch set 8 02/04/26, 17:48
Pagination.fluid.html:11Can we use the new label translation domain syntax for new code? -
Garvin Hicking voted on patch set 8 CR -1 02/04/26, 17:49
-
Oli Bartsch commented on patch set 8 02/04/26, 19:18
Pagination.fluid.html:11ReplySure, would you mind update the patch? -
Garvin Hicking commented on patch set 8 02/04/26, 19:51
Pagination.fluid.html:11ReplyYes. On it. -
Garvin Hicking uploaded patch set 9
CR +1V +102/04/26, 19:59use domain language syntax -
Garvin Hicking commented on patch set 9 CR +1 V +1 02/04/26, 20:00
Pagination.fluid.html:11ReplyDone -
Garvin Hicking commented on patch set 9 V 0 CR -1 02/04/26, 20:06
sorry hang on, I made an error -
core-ci voted on patch set 9 V +1 02/04/26, 20:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95080
-
Garvin Hicking uploaded patch set 10
CR -1V +102/04/26, 20:11use seperate domain atttribute -
Garvin Hicking commented on patch set 10 CR +1 V +1 02/04/26, 20:11
sorry, but I recognized the recommendation is to use "domain" attribute -
Oli Bartsch voted on patch set 10 CR +2 V +2 02/04/26, 20:16
-
Oli Bartsch merged patch set 11 02/04/26, 20:16
-
core-ci voted on patch set 10 V +1 02/04/26, 20:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95082