Review main Merged

92246[TASK] Streamline pagination in Media module

Simon Schaufelberger CR +2 V +2 Hard +158 −186 updated 02/04/26, 20:19

Commit message

The pagination in the Media module is streamlined to
match current UI and also use shared functionality.

However, it does duplicate a bit of code (from recordlist),
which could ideally be merged together in further patches.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1

Issues 1

Files 9

Review log 2736

Show 711 earlier messages
  1. Simon Schaufelberger uploaded patch set 1 01/04/26, 21:00

  2. Simon Schaufelberger uploaded patch set 2 01/04/26, 21:01

  3. core-ci voted on patch set 1 V +1 01/04/26, 21:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92941

  4. core-ci voted on patch set 2 V +1 01/04/26, 21:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92942

  5. Simon Schaufelberger uploaded patch set 3 V +1 01/18/26, 22:00

  6. Simon Schaufelberger uploaded patch set 4 01/18/26, 22:07

  7. Simon Schaufelberger marked it ready for review 01/18/26, 22:07

  8. Simon Schaufelberger updated the commit message in patch set 5 01/18/26, 22:08

  9. core-ci voted on patch set 3 V -1 01/18/26, 22:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93733

  10. core-ci voted on patch set 5 V +1 01/18/26, 22:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93735

  11. Simon Schaufelberger uploaded patch set 6 V +1 01/18/26, 22:19

  1. core-ci voted on patch set 6 V +1 01/18/26, 22:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93736

  2. Simon Schaufelberger updated the commit message in patch set 7 V +1 01/18/26, 23:23

  3. core-ci voted on patch set 7 V +1 01/18/26, 23:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93737

  4. Juliane Wundermann voted on patch set 7 CR +1 V +1 02/04/26, 09:34

  5. Oli Bartsch uploaded patch set 8 CR +1 V +1 02/04/26, 16:08

  6. Simon Schaufelberger voted on patch set 8 CR +1 V +1 02/04/26, 16:15

  7. core-ci voted on patch set 8 V +1 02/04/26, 16:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95065

  8. Oli Bartsch voted on patch set 8 CR +1 V +1 02/04/26, 16:20

  9. Simon Schaufelberger commented on patch set 8 CR -1 02/04/26, 16:40

    @bo@cedev.de Juliane meint, dass es jetzt inkonsistent ist, da in der Listenansicht die Paginierung auch oben ist.
  10. Oli Bartsch commented on patch set 8 02/04/26, 16:50

    Reply

    @simonschaufi+typo3@gmail.com and I think that actually records module is inconsitent in comparison to form, beuser, redirects, webhooks, reactions, etc. 🙃
  11. Simon Schaufelberger commented on patch set 8 CR +1 02/04/26, 16:54

    Reply

    Done
  12. Juliane Wundermann voted on patch set 8 CR +1 V +1 02/04/26, 16:55

  13. Garvin Hicking commented on patch set 8 02/04/26, 17:48

    Pagination.fluid.html:11

    Can we use the new label translation domain syntax for new code?
  14. Garvin Hicking voted on patch set 8 CR -1 02/04/26, 17:49

  15. Oli Bartsch commented on patch set 8 02/04/26, 19:18

    Pagination.fluid.html:11 Reply

    Sure, would you mind update the patch?
  16. Garvin Hicking commented on patch set 8 02/04/26, 19:51

    Pagination.fluid.html:11 Reply

    Yes. On it.
  17. Garvin Hicking uploaded patch set 9 CR +1 V +1 02/04/26, 19:59

    use domain language syntax
  18. Garvin Hicking commented on patch set 9 CR +1 V +1 02/04/26, 20:00

    Pagination.fluid.html:11 Reply

    Done
  19. Garvin Hicking commented on patch set 9 V 0 CR -1 02/04/26, 20:06

    sorry hang on, I made an error
  20. core-ci voted on patch set 9 V +1 02/04/26, 20:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95080

  21. Garvin Hicking uploaded patch set 10 CR -1 V +1 02/04/26, 20:11

    use seperate domain atttribute
  22. Garvin Hicking commented on patch set 10 CR +1 V +1 02/04/26, 20:11

    sorry, but I recognized the recommendation is to use "domain" attribute
  23. Oli Bartsch voted on patch set 10 CR +2 V +2 02/04/26, 20:16

  24. Oli Bartsch merged patch set 11 02/04/26, 20:16

  25. core-ci voted on patch set 10 V +1 02/04/26, 20:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95082