Review main Merged

92253[TASK] Handle ext:extensionmanager phpstan baseline entries

Torben Hansen CR +2 V +2 Normal +18 −86 updated 01/06/26, 11:24

Commit message

This change handles all ext:extensionmanaher related phpstan
baseline entries by:

- Providing expected types for function arguments
- Removing multiple superfluous `is_array` checks
- Removing a superfluous comparison for `$highestVersion`
- Adapting types in `RemoteRegistry`
- Providing type doc comments where suitable

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 56

  1. Torben Hansen uploaded patch set 1 01/06/26, 06:48

  2. core-ci voted on patch set 1 V +1 01/06/26, 06:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93023

  3. Benni Mack voted on patch set 1 CR +1 V +1 01/06/26, 09:45

  4. Oliver Klee voted on patch set 1 CR +1 V +1 01/06/26, 10:06

  5. Benni Mack voted on patch set 1 CR +2 V +2 01/06/26, 11:24

  6. Benni Mack merged patch set 2 01/06/26, 11:24