92264[TASK] Handle phpstan baseline entries for extbase unit tests
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oliver Klee +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Benni Mack +2
- Oliver Klee +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 15
- Build/phpstan/phpstan-baseline.neon+0 −144
- typo3/sysext/extbase/Classes/Service/CacheService.php+2 −1
- typo3/sysext/extbase/Tests/Unit/Error/ResultTest.php2+28 −26
- typo3/sysext/extbase/Tests/Unit/Mvc/Controller/ArgumentsTest.php2+3 −3
- typo3/sysext/extbase/Tests/Unit/Mvc/Controller/ArgumentTest.php+2 −2
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/QueryResultTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/QueryTest.php+2 −0
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Typo3QuerySettingsTest.php+0 −40
- typo3/sysext/extbase/Tests/Unit/Reflection/Fixture/DummyClassWithAllTypesOfMethods.php+1 −0
- typo3/sysext/extbase/Tests/Unit/Reflection/Fixture/DummyClassWithAllTypesOfProperties.php+1 −0
- typo3/sysext/extbase/Tests/Unit/Reflection/Fixture/DummyClassWithInvalidTypeHint.php+1 −0
- typo3/sysext/extbase/Tests/Unit/Reflection/ClassSchemaTest.php3+3 −3
- typo3/sysext/extbase/Tests/Unit/Reflection/ObjectAccessTest.php+1 −3
- typo3/sysext/extbase/Tests/Unit/Reflection/ReflectionServiceTest.php+0 −3
- typo3/sysext/extbase/Tests/Unit/Utility/ExtensionUtilityTest.php+33 −25
Review log 912
-
Torben Hansen uploaded patch set 1 01/09/26, 06:54
-
core-ci voted on patch set 1 V -1 01/09/26, 07:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93134
-
Torben Hansen uploaded patch set 2
V -101/09/26, 07:14 -
core-ci voted on patch set 2 V +1 01/09/26, 07:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93135
-
Oliver Klee commented on patch set 2 V +1 01/09/26, 09:03
ArgumentsTest.php:213Could we add the type of warning here to narrow down the blocklisting?ClassSchemaTest.php:136Does this PHPDoc type annotation then still make sense, or should we remove it? -
Torben Hansen uploaded patch set 3
V +101/09/26, 09:19 -
Torben Hansen commented on patch set 3 01/09/26, 09:20
ResultTest.php:47ReplyDoneArgumentsTest.php:213ReplyDoneClassSchemaTest.php:136ReplyThe test tests, if class schema resolves the type from method parameter. If this would not be the case, the type `ClassSchema` would be returned. Therefore, the type annotation must remain here. -
Oliver Klee commented on patch set 3 CR +1 V +1 01/09/26, 09:22
ClassSchemaTest.php:136ReplyAh, I see. Thanks for the background explanation! -
core-ci voted on patch set 3 V +1 01/09/26, 09:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93140
-
Simon Schaufelberger voted on patch set 3 CR +1 V +1 01/09/26, 10:32
-
Benni Mack voted on patch set 3 CR +2 V +2 01/09/26, 14:03
-
Benni Mack merged patch set 4 01/09/26, 14:04
ResultTest.php:47